From: Andrew Morton <akpm@linux-foundation.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Christoph Lameter <cl@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Rik van Riel <riel@redhat.com>,
Wu Fengguang <fengguang.wu@intel.com>,
linuxram@us.ibm.com, linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
stable@kernel.org
Subject: Re: [PATCH 2/3] Do not unconditionally treat zones that fail zone_reclaim() as full
Date: Mon, 15 Jun 2009 08:58:40 -0700 [thread overview]
Message-ID: <20090615085840.63aa6cde.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090615102829.GC23198@csn.ul.ie>
On Mon, 15 Jun 2009 11:28:30 +0100 Mel Gorman <mel@csn.ul.ie> wrote:
> On Fri, Jun 12, 2009 at 08:44:56AM -0700, Andrew Morton wrote:
> > On Fri, 12 Jun 2009 11:36:17 +0100 Mel Gorman <mel@csn.ul.ie> wrote:
> >
> > > On Thu, Jun 11, 2009 at 09:48:53AM -0400, Christoph Lameter wrote:
> > > > It needs to be mentioned that this fixes a bug introduced in 2.6.19.
> > > > Possibly a portion of this code needs to be backported to stable.
> > > >
> > >
> > > Andrew has sucked up the patch already so I can't patch it. Andrew, there
> > > is a further note below on the patch if you'd like to pick it up.
> >
> > OK.
> >
> > > On the stable front, I'm think that patches 1 and 2 should being considered
> > > -stable candidates. Patch 1 is certainly needed because it fixes up the
> > > malloc() stall and should be picked up by distro kernels as well. This patch
> > > closes another obvious hole albeit one harder to trigger.
> > >
> > > Ideally patch 3 would also be in -stable so distro kernels will suck it up
> > > as it will help identify this problem in the field if it occurs again but
> > > I'm not sure what the -stable policy is on such things are.
> >
> > Well, I tagged the patches for stable but they don't apply at all well
> > to even 2.6.30 base.
> >
>
> What's the proper way to handle such a situation? Wait until the patches
> go to mainline and post a rebased version to stable?
Yes please. I assume that when Greg&Chris try to apply the patch,
we'll hear squawks to remind us of this.
Of course, it'd be better if the patch didn't get rejects. Perhaps
whatever-patch-clashed should also be backported.
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Morton <akpm@linux-foundation.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Christoph Lameter <cl@linux-foundation.org>,
KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>,
Rik van Riel <riel@redhat.com>,
Wu Fengguang <fengguang.wu@intel.com>,
linuxram@us.ibm.com, linux-mm <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
stable@kernel.org
Subject: Re: [PATCH 2/3] Do not unconditionally treat zones that fail zone_reclaim() as full
Date: Mon, 15 Jun 2009 08:58:40 -0700 [thread overview]
Message-ID: <20090615085840.63aa6cde.akpm@linux-foundation.org> (raw)
In-Reply-To: <20090615102829.GC23198@csn.ul.ie>
On Mon, 15 Jun 2009 11:28:30 +0100 Mel Gorman <mel@csn.ul.ie> wrote:
> On Fri, Jun 12, 2009 at 08:44:56AM -0700, Andrew Morton wrote:
> > On Fri, 12 Jun 2009 11:36:17 +0100 Mel Gorman <mel@csn.ul.ie> wrote:
> >
> > > On Thu, Jun 11, 2009 at 09:48:53AM -0400, Christoph Lameter wrote:
> > > > It needs to be mentioned that this fixes a bug introduced in 2.6.19.
> > > > Possibly a portion of this code needs to be backported to stable.
> > > >
> > >
> > > Andrew has sucked up the patch already so I can't patch it. Andrew, there
> > > is a further note below on the patch if you'd like to pick it up.
> >
> > OK.
> >
> > > On the stable front, I'm think that patches 1 and 2 should being considered
> > > -stable candidates. Patch 1 is certainly needed because it fixes up the
> > > malloc() stall and should be picked up by distro kernels as well. This patch
> > > closes another obvious hole albeit one harder to trigger.
> > >
> > > Ideally patch 3 would also be in -stable so distro kernels will suck it up
> > > as it will help identify this problem in the field if it occurs again but
> > > I'm not sure what the -stable policy is on such things are.
> >
> > Well, I tagged the patches for stable but they don't apply at all well
> > to even 2.6.30 base.
> >
>
> What's the proper way to handle such a situation? Wait until the patches
> go to mainline and post a rebased version to stable?
Yes please. I assume that when Greg&Chris try to apply the patch,
we'll hear squawks to remind us of this.
Of course, it'd be better if the patch didn't get rejects. Perhaps
whatever-patch-clashed should also be backported.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-06-15 16:01 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-11 10:47 [PATCH 0/3] Fix malloc() stall in zone_reclaim() and bring behaviour more in line with expectations V3 Mel Gorman
2009-06-11 10:47 ` Mel Gorman
2009-06-11 10:47 ` [PATCH 1/3] Properly account for the number of page cache pages zone_reclaim() can reclaim Mel Gorman
2009-06-11 10:47 ` Mel Gorman
2009-06-11 11:37 ` KOSAKI Motohiro
2009-06-11 11:37 ` KOSAKI Motohiro
2009-06-12 10:17 ` Mel Gorman
2009-06-12 10:17 ` Mel Gorman
2009-06-15 4:51 ` KOSAKI Motohiro
2009-06-15 4:51 ` KOSAKI Motohiro
2009-06-15 10:05 ` Mel Gorman
2009-06-15 10:05 ` Mel Gorman
2009-06-11 10:47 ` [PATCH 2/3] Do not unconditionally treat zones that fail zone_reclaim() as full Mel Gorman
2009-06-11 10:47 ` Mel Gorman
2009-06-11 13:48 ` Christoph Lameter
2009-06-11 13:48 ` Christoph Lameter
2009-06-12 10:36 ` Mel Gorman
2009-06-12 10:36 ` Mel Gorman
2009-06-12 15:44 ` Andrew Morton
2009-06-12 15:44 ` Andrew Morton
2009-06-15 10:28 ` Mel Gorman
2009-06-15 10:28 ` Mel Gorman
2009-06-15 15:58 ` Andrew Morton [this message]
2009-06-15 15:58 ` Andrew Morton
2009-06-11 10:47 ` [PATCH 3/3] Count the number of times zone_reclaim() scans and fails Mel Gorman
2009-06-11 10:47 ` Mel Gorman
2009-06-11 11:33 ` KOSAKI Motohiro
2009-06-11 11:33 ` KOSAKI Motohiro
2009-06-15 21:19 ` Andrew Morton
2009-06-15 21:19 ` Andrew Morton
2009-06-16 9:05 ` Mel Gorman
2009-06-16 9:05 ` Mel Gorman
2009-06-11 23:30 ` [PATCH 0/3] Fix malloc() stall in zone_reclaim() and bring behaviour more in line with expectations V3 Andrew Morton
2009-06-11 23:30 ` Andrew Morton
2009-06-12 11:04 ` Mel Gorman
2009-06-12 11:04 ` Mel Gorman
2009-06-12 16:08 ` Andrew Morton
2009-06-12 16:08 ` Andrew Morton
2009-06-15 9:42 ` KOSAKI Motohiro
2009-06-15 9:42 ` KOSAKI Motohiro
2009-06-15 10:56 ` Mel Gorman
2009-06-15 10:56 ` Mel Gorman
2009-06-15 15:01 ` Christoph Lameter
2009-06-15 15:01 ` Christoph Lameter
2009-06-15 15:25 ` Mel Gorman
2009-06-15 15:25 ` Mel Gorman
2009-06-16 12:08 ` KOSAKI Motohiro
2009-06-16 12:08 ` KOSAKI Motohiro
2009-06-16 12:20 ` Mel Gorman
2009-06-16 12:20 ` Mel Gorman
2009-06-16 12:30 ` KOSAKI Motohiro
2009-06-16 12:30 ` KOSAKI Motohiro
2009-06-16 12:57 ` KOSAKI Motohiro
2009-06-16 12:57 ` KOSAKI Motohiro
2009-06-16 13:44 ` Mel Gorman
2009-06-16 13:44 ` Mel Gorman
2009-06-16 14:51 ` Christoph Lameter
2009-06-16 14:51 ` Christoph Lameter
2009-06-17 10:06 ` KOSAKI Motohiro
2009-06-17 10:06 ` KOSAKI Motohiro
2009-06-17 12:03 ` Mel Gorman
2009-06-17 12:03 ` Mel Gorman
2009-06-17 18:48 ` Christoph Lameter
2009-06-17 18:48 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090615085840.63aa6cde.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=fengguang.wu@intel.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxram@us.ibm.com \
--cc=mel@csn.ul.ie \
--cc=riel@redhat.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.