From: Ingo Molnar <mingo@elte.hu>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
"menage@google.com" <menage@google.com>
Subject: Re: [RFC][PATCH] cgroup: fix permanent wait in rmdir
Date: Mon, 22 Jun 2009 14:26:15 +0200 [thread overview]
Message-ID: <20090622122615.GA28503@elte.hu> (raw)
In-Reply-To: <ec48fff1916d3e82c3c4fc610245f0b6.squirrel@webmail-b.css.fujitsu.com>
* KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> KAMEZAWA Hiroyuki wrote:
> > Ingo Molnar wrote:
> >>
> >> FYI, there's a new cgroup related list corruption warning/crash that
> >> i've seen a lot of times in latest -tip tests:
> >>
> >> [ 478.555544] ------------[ cut here ]------------
> >> [ 478.556523] WARNING: at lib/list_debug.c:26 __list_add+0x70/0xa0()
> >> [ 478.556523] Hardware name:
> >> [ 478.556523] list_add corruption. next->prev should be prev
> >> (ffff88003e640448), but was ffff88003fa1a6e8. (next=ffff88003fa1a8a0).
> >> [ 478.556523] Modules linked in:
> >> [ 478.556523] Pid: 470, comm: kswapd0 Not tainted 2.6.30-tip #10989
> >> [ 478.556523] Call Trace:
> >> [ 478.556523] [<ffffffff81306150>] ? __list_add+0x70/0xa0
> >> [ 478.556523] [<ffffffff810598dc>] warn_slowpath_common+0x8c/0xc0
> >> [ 478.556523] [<ffffffff81059999>] warn_slowpath_fmt+0x69/0x70
> >> [ 478.556523] [<ffffffff81086e3b>] ? __lock_acquired+0x18b/0x2b0
> >> [ 478.556523] [<ffffffff811022f0>] ? page_check_address+0x110/0x1a0
> >> [ 478.556523] [<ffffffff812ebcf2>] ? cpumask_any_but+0x42/0xb0
> >> [ 478.556523] [<ffffffff8108c528>] ? __lock_release+0x38/0x90
> >> [ 478.556523] [<ffffffff811024e1>] ? page_referenced_one+0x91/0x120
> >> [ 478.556523] [<ffffffff81306150>] __list_add+0x70/0xa0
> >> [ 478.556523] [<ffffffff8111dc63>] mem_cgroup_add_lru_list+0x63/0x70
> >> [ 478.556523] [<ffffffff810eaee4>] move_active_pages_to_lru+0xf4/0x180
> >> [ 478.556523] [<ffffffff810eb758>] ? shrink_active_list+0x1f8/0x2a0
> >> [ 478.556523] [<ffffffff810eb758>] ? shrink_active_list+0x1f8/0x2a0
> >> [ 478.556523] [<ffffffff810eb794>] shrink_active_list+0x234/0x2a0
> >> [ 478.556523] [<ffffffff810ec3c3>] shrink_zone+0x173/0x1f0
> >> [ 478.556523] [<ffffffff810ece0a>] balance_pgdat+0x4da/0x4e0
> >> [ 478.556523] [<ffffffff810eb240>] ? isolate_pages_global+0x0/0x60
> >> [ 478.556523] [<ffffffff810ed3b6>] kswapd+0x106/0x150
> >> [ 478.556523] [<ffffffff810752f0>] ? autoremove_wake_function+0x0/0x40
> >> [ 478.556523] [<ffffffff810ed2b0>] ? kswapd+0x0/0x150
> >> [ 478.556523] [<ffffffff8107516e>] kthread+0x9e/0xb0
> >> [ 478.556523] [<ffffffff8100d2ba>] child_rip+0xa/0x20
> >> [ 478.556523] [<ffffffff8100cc40>] ? restore_args+0x0/0x30
> >> [ 478.556523] [<ffffffff81075085>] ? kthreadd+0xb5/0x100
> >> [ 478.556523] [<ffffffff810750d0>] ? kthread+0x0/0xb0
> >> [ 478.556523] [<ffffffff8100d2b0>] ? child_rip+0x0/0x20
> >> [ 478.556523] ---[ end trace 9f3122957c34141e ]---
> >> [ 484.923530] ------------[ cut here ]------------
> >> [ 484.924525] WARNING: at lib/list_debug.c:26 __list_add+0x70/0xa0()
> >> [ 484.924525] Hardware name:
> >> [ 484.924525] list_add corruption. next->prev should be prev
> >> (ffff88003e640448), but was ffff88003fa192e8. (next=ffff88003fa14d88).
> >> [ 484.941152] Modules linked in:
> >> [ 484.941152] Pid: 470, comm: kswapd0 Tainted: G W 2.6.30-tip
> >> #10989
> >> [ 484.941152] Call Trace:
> >> [ 484.941152] [<ffffffff81306150>] ? __list_add+0x70/0xa0
> >> [ 484.941152] [<ffffffff810598dc>] warn_slowpath_common+0x8c/0xc0
> >> [ 484.941152] [<ffffffff81059999>] warn_slowpath_fmt+0x69/0x70
> >> [ 484.941152] [<ffffffff81086e3b>] ? __lock_acquired+0x18b/0x2b0
> >> [ 484.941152] [<ffffffff811022f0>] ? page_check_address+0x110/0x1a0
> >> [ 484.941152] [<ffffffff812ebcf2>] ? cpumask_any_but+0x42/0xb0
> >> [ 484.941152] [<ffffffff8108c528>] ? __lock_release+0x38/0x90
> >> [ 484.941152] [<ffffffff811024e1>] ? page_referenced_one+0x91/0x120
> >> [ 484.941152] [<ffffffff81306150>] __list_add+0x70/0xa0
> >> [ 484.941152] [<ffffffff8111dc63>] mem_cgroup_add_lru_list+0x63/0x70
> >> [ 484.941152] [<ffffffff810eaee4>] move_active_pages_to_lru+0xf4/0x180
> >> [ 484.941152] [<ffffffff810eb758>] ? shrink_active_list+0x1f8/0x2a0
> >> [ 484.941152] [<ffffffff810eb758>] ? shrink_active_list+0x1f8/0x2a0
> >> [ 484.941152] [<ffffffff810eb794>] shrink_active_list+0x234/0x2a0
> >> [ 484.941152] [<ffffffff810ec3c3>] shrink_zone+0x173/0x1f0
> >> [ 484.941152] [<ffffffff810ece0a>] balance_pgdat+0x4da/0x4e0
> >> [ 484.941152] [<ffffffff810eb240>] ? isolate_pages_global+0x0/0x60
> >> [ 484.941152] [<ffffffff810ed3b6>] kswapd+0x106/0x150
> >> [ 484.941152] [<ffffffff810752f0>] ? autoremove_wake_function+0x0/0x40
> >> [ 484.941152] [<ffffffff810ed2b0>] ? kswapd+0x0/0x150
> >> [ 484.941152] [<ffffffff8107516e>] kthread+0x9e/0xb0
> >> [ 484.941152] [<ffffffff8100d2ba>] child_rip+0xa/0x20
> >> [ 484.941152] [<ffffffff8100cc40>] ? restore_args+0x0/0x30
> >> [ 484.941152] [<ffffffff81075085>] ? kthreadd+0xb5/0x100
> >> [ 484.941152] [<ffffffff810750d0>] ? kthread+0x0/0xb0
> >> [ 484.941152] [<ffffffff8100d2b0>] ? child_rip+0x0/0x20
> >> [ 484.941152] ---[ end trace 9f3122957c34141f ]---
> >> [ 485.365631] ------------[ cut here ]------------
> >> [ 485.368029] WARNING: at lib/list_debug.c:26 __list_add+0x70/0xa0()
> >>
> >> has this been reported before? Is there a fix for it i missed?
> >>
> > Hmm, looks new one.
> >
> > Maybe related to my latest post which modifies __isolate_lru_page()
> > memcg: fix lru rotation in isolate_pages
> >
> > I'll dig tomorrow, sorry.
> >
> Ah, while I test 2.6.30-git18 (includes above patch), I don't see
> above stack dump (with LIST_DEBUG=y) under quick memory pressure
> test...
Note, it still occurs even with latest -git (f234012).
Ingo
WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
"menage@google.com" <menage@google.com>
Subject: Re: [RFC][PATCH] cgroup: fix permanent wait in rmdir
Date: Mon, 22 Jun 2009 14:26:15 +0200 [thread overview]
Message-ID: <20090622122615.GA28503@elte.hu> (raw)
In-Reply-To: <ec48fff1916d3e82c3c4fc610245f0b6.squirrel@webmail-b.css.fujitsu.com>
* KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> wrote:
> KAMEZAWA Hiroyuki wrote:
> > Ingo Molnar wrote:
> >>
> >> FYI, there's a new cgroup related list corruption warning/crash that
> >> i've seen a lot of times in latest -tip tests:
> >>
> >> [ 478.555544] ------------[ cut here ]------------
> >> [ 478.556523] WARNING: at lib/list_debug.c:26 __list_add+0x70/0xa0()
> >> [ 478.556523] Hardware name:
> >> [ 478.556523] list_add corruption. next->prev should be prev
> >> (ffff88003e640448), but was ffff88003fa1a6e8. (next=ffff88003fa1a8a0).
> >> [ 478.556523] Modules linked in:
> >> [ 478.556523] Pid: 470, comm: kswapd0 Not tainted 2.6.30-tip #10989
> >> [ 478.556523] Call Trace:
> >> [ 478.556523] [<ffffffff81306150>] ? __list_add+0x70/0xa0
> >> [ 478.556523] [<ffffffff810598dc>] warn_slowpath_common+0x8c/0xc0
> >> [ 478.556523] [<ffffffff81059999>] warn_slowpath_fmt+0x69/0x70
> >> [ 478.556523] [<ffffffff81086e3b>] ? __lock_acquired+0x18b/0x2b0
> >> [ 478.556523] [<ffffffff811022f0>] ? page_check_address+0x110/0x1a0
> >> [ 478.556523] [<ffffffff812ebcf2>] ? cpumask_any_but+0x42/0xb0
> >> [ 478.556523] [<ffffffff8108c528>] ? __lock_release+0x38/0x90
> >> [ 478.556523] [<ffffffff811024e1>] ? page_referenced_one+0x91/0x120
> >> [ 478.556523] [<ffffffff81306150>] __list_add+0x70/0xa0
> >> [ 478.556523] [<ffffffff8111dc63>] mem_cgroup_add_lru_list+0x63/0x70
> >> [ 478.556523] [<ffffffff810eaee4>] move_active_pages_to_lru+0xf4/0x180
> >> [ 478.556523] [<ffffffff810eb758>] ? shrink_active_list+0x1f8/0x2a0
> >> [ 478.556523] [<ffffffff810eb758>] ? shrink_active_list+0x1f8/0x2a0
> >> [ 478.556523] [<ffffffff810eb794>] shrink_active_list+0x234/0x2a0
> >> [ 478.556523] [<ffffffff810ec3c3>] shrink_zone+0x173/0x1f0
> >> [ 478.556523] [<ffffffff810ece0a>] balance_pgdat+0x4da/0x4e0
> >> [ 478.556523] [<ffffffff810eb240>] ? isolate_pages_global+0x0/0x60
> >> [ 478.556523] [<ffffffff810ed3b6>] kswapd+0x106/0x150
> >> [ 478.556523] [<ffffffff810752f0>] ? autoremove_wake_function+0x0/0x40
> >> [ 478.556523] [<ffffffff810ed2b0>] ? kswapd+0x0/0x150
> >> [ 478.556523] [<ffffffff8107516e>] kthread+0x9e/0xb0
> >> [ 478.556523] [<ffffffff8100d2ba>] child_rip+0xa/0x20
> >> [ 478.556523] [<ffffffff8100cc40>] ? restore_args+0x0/0x30
> >> [ 478.556523] [<ffffffff81075085>] ? kthreadd+0xb5/0x100
> >> [ 478.556523] [<ffffffff810750d0>] ? kthread+0x0/0xb0
> >> [ 478.556523] [<ffffffff8100d2b0>] ? child_rip+0x0/0x20
> >> [ 478.556523] ---[ end trace 9f3122957c34141e ]---
> >> [ 484.923530] ------------[ cut here ]------------
> >> [ 484.924525] WARNING: at lib/list_debug.c:26 __list_add+0x70/0xa0()
> >> [ 484.924525] Hardware name:
> >> [ 484.924525] list_add corruption. next->prev should be prev
> >> (ffff88003e640448), but was ffff88003fa192e8. (next=ffff88003fa14d88).
> >> [ 484.941152] Modules linked in:
> >> [ 484.941152] Pid: 470, comm: kswapd0 Tainted: G W 2.6.30-tip
> >> #10989
> >> [ 484.941152] Call Trace:
> >> [ 484.941152] [<ffffffff81306150>] ? __list_add+0x70/0xa0
> >> [ 484.941152] [<ffffffff810598dc>] warn_slowpath_common+0x8c/0xc0
> >> [ 484.941152] [<ffffffff81059999>] warn_slowpath_fmt+0x69/0x70
> >> [ 484.941152] [<ffffffff81086e3b>] ? __lock_acquired+0x18b/0x2b0
> >> [ 484.941152] [<ffffffff811022f0>] ? page_check_address+0x110/0x1a0
> >> [ 484.941152] [<ffffffff812ebcf2>] ? cpumask_any_but+0x42/0xb0
> >> [ 484.941152] [<ffffffff8108c528>] ? __lock_release+0x38/0x90
> >> [ 484.941152] [<ffffffff811024e1>] ? page_referenced_one+0x91/0x120
> >> [ 484.941152] [<ffffffff81306150>] __list_add+0x70/0xa0
> >> [ 484.941152] [<ffffffff8111dc63>] mem_cgroup_add_lru_list+0x63/0x70
> >> [ 484.941152] [<ffffffff810eaee4>] move_active_pages_to_lru+0xf4/0x180
> >> [ 484.941152] [<ffffffff810eb758>] ? shrink_active_list+0x1f8/0x2a0
> >> [ 484.941152] [<ffffffff810eb758>] ? shrink_active_list+0x1f8/0x2a0
> >> [ 484.941152] [<ffffffff810eb794>] shrink_active_list+0x234/0x2a0
> >> [ 484.941152] [<ffffffff810ec3c3>] shrink_zone+0x173/0x1f0
> >> [ 484.941152] [<ffffffff810ece0a>] balance_pgdat+0x4da/0x4e0
> >> [ 484.941152] [<ffffffff810eb240>] ? isolate_pages_global+0x0/0x60
> >> [ 484.941152] [<ffffffff810ed3b6>] kswapd+0x106/0x150
> >> [ 484.941152] [<ffffffff810752f0>] ? autoremove_wake_function+0x0/0x40
> >> [ 484.941152] [<ffffffff810ed2b0>] ? kswapd+0x0/0x150
> >> [ 484.941152] [<ffffffff8107516e>] kthread+0x9e/0xb0
> >> [ 484.941152] [<ffffffff8100d2ba>] child_rip+0xa/0x20
> >> [ 484.941152] [<ffffffff8100cc40>] ? restore_args+0x0/0x30
> >> [ 484.941152] [<ffffffff81075085>] ? kthreadd+0xb5/0x100
> >> [ 484.941152] [<ffffffff810750d0>] ? kthread+0x0/0xb0
> >> [ 484.941152] [<ffffffff8100d2b0>] ? child_rip+0x0/0x20
> >> [ 484.941152] ---[ end trace 9f3122957c34141f ]---
> >> [ 485.365631] ------------[ cut here ]------------
> >> [ 485.368029] WARNING: at lib/list_debug.c:26 __list_add+0x70/0xa0()
> >>
> >> has this been reported before? Is there a fix for it i missed?
> >>
> > Hmm, looks new one.
> >
> > Maybe related to my latest post which modifies __isolate_lru_page()
> > memcg: fix lru rotation in isolate_pages
> >
> > I'll dig tomorrow, sorry.
> >
> Ah, while I test 2.6.30-git18 (includes above patch), I don't see
> above stack dump (with LIST_DEBUG=y) under quick memory pressure
> test...
Note, it still occurs even with latest -git (f234012).
Ingo
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-06-22 12:26 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 9:37 [RFC][PATCH] cgroup: fix permanent wait in rmdir KAMEZAWA Hiroyuki
2009-06-22 9:37 ` KAMEZAWA Hiroyuki
2009-06-22 10:52 ` Ingo Molnar
2009-06-22 10:52 ` Ingo Molnar
2009-06-22 11:27 ` KAMEZAWA Hiroyuki
2009-06-22 11:27 ` KAMEZAWA Hiroyuki
2009-06-22 12:16 ` Balbir Singh
2009-06-22 12:16 ` Balbir Singh
2009-06-22 12:20 ` KAMEZAWA Hiroyuki
2009-06-22 12:20 ` KAMEZAWA Hiroyuki
2009-06-22 12:26 ` Ingo Molnar [this message]
2009-06-22 12:26 ` Ingo Molnar
2009-06-22 12:32 ` KAMEZAWA Hiroyuki
2009-06-22 12:32 ` KAMEZAWA Hiroyuki
2009-06-22 23:57 ` [BUGFIX][PATCH] fix bad page removal from LRU (Was " KAMEZAWA Hiroyuki
2009-06-22 23:57 ` KAMEZAWA Hiroyuki
2009-06-23 0:47 ` Balbir Singh
2009-06-23 0:47 ` Balbir Singh
2009-06-23 7:27 ` Daisuke Nishimura
2009-06-23 7:27 ` Daisuke Nishimura
2009-06-23 7:29 ` KAMEZAWA Hiroyuki
2009-06-23 7:29 ` KAMEZAWA Hiroyuki
2009-06-23 0:22 ` KAMEZAWA Hiroyuki
2009-06-23 0:22 ` KAMEZAWA Hiroyuki
2009-06-23 4:13 ` Daisuke Nishimura
2009-06-23 4:13 ` Daisuke Nishimura
2009-06-23 4:44 ` KAMEZAWA Hiroyuki
2009-06-23 4:44 ` KAMEZAWA Hiroyuki
2009-06-23 4:54 ` Daisuke Nishimura
2009-06-23 4:54 ` Daisuke Nishimura
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090622122615.GA28503@elte.hu \
--to=mingo@elte.hu \
--cc=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=menage@google.com \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.