All of lore.kernel.org
 help / color / mirror / Atom feed
From: "KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
	"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
	"menage@google.com" <menage@google.com>
Subject: Re: [RFC][PATCH] cgroup: fix permanent wait in rmdir
Date: Mon, 22 Jun 2009 21:32:26 +0900 (JST)	[thread overview]
Message-ID: <f9931fe09c239cd30222bf8532e62b65.squirrel@webmail-b.css.fujitsu.com> (raw)
In-Reply-To: <20090622122615.GA28503@elte.hu>

Ingo Molnar wrote:
>> Ah, while I test 2.6.30-git18 (includes above patch), I don't see
>> above stack dump (with LIST_DEBUG=y) under quick memory pressure
>> test...
>
> Note, it still occurs even with latest -git (f234012).
>
Could you try this ? (Sorry, I can't send a patch right now)
== vmscan.c
865 static unsigned long isolate_lru_pages(unsigned long nr_to_scan,
866                 struct list_head *src, struct list_head *dst,
867                 unsigned long *scanned, int order, int mode, int file)
868 {
869         unsigned long nr_taken = 0;
870         unsigned long scan;
871
<snip>
 930                         /* Check that we have not crossed a zone
boundary. */
931                         if (unlikely(page_zone_id(cursor_page) !=
zone_id))
932                                 continue;
933                         if (__isolate_lru_page(cursor_page, mode,
file) == 0) {
934                                 list_move(&cursor_page->lru, dst);
935                                 mem_cgroup_del_lru(page);
936                                 nr_taken++;
937                                 scan++;
938                         }


change line 935
from
  mem_cgroup_del_lru(page);
to
  mem_cgroup_del_lru(cursor_page);


Thanks,
-Kame





WARNING: multiple messages have this Message-ID (diff)
From: "KAMEZAWA Hiroyuki" <kamezawa.hiroyu@jp.fujitsu.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"balbir@linux.vnet.ibm.com" <balbir@linux.vnet.ibm.com>,
	"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
	"menage@google.com" <menage@google.com>
Subject: Re: [RFC][PATCH] cgroup: fix permanent wait in rmdir
Date: Mon, 22 Jun 2009 21:32:26 +0900 (JST)	[thread overview]
Message-ID: <f9931fe09c239cd30222bf8532e62b65.squirrel@webmail-b.css.fujitsu.com> (raw)
In-Reply-To: <20090622122615.GA28503@elte.hu>

Ingo Molnar wrote:
>> Ah, while I test 2.6.30-git18 (includes above patch), I don't see
>> above stack dump (with LIST_DEBUG=y) under quick memory pressure
>> test...
>
> Note, it still occurs even with latest -git (f234012).
>
Could you try this ? (Sorry, I can't send a patch right now)
== vmscan.c
865 static unsigned long isolate_lru_pages(unsigned long nr_to_scan,
866                 struct list_head *src, struct list_head *dst,
867                 unsigned long *scanned, int order, int mode, int file)
868 {
869         unsigned long nr_taken = 0;
870         unsigned long scan;
871
<snip>
 930                         /* Check that we have not crossed a zone
boundary. */
931                         if (unlikely(page_zone_id(cursor_page) !=
zone_id))
932                                 continue;
933                         if (__isolate_lru_page(cursor_page, mode,
file) == 0) {
934                                 list_move(&cursor_page->lru, dst);
935                                 mem_cgroup_del_lru(page);
936                                 nr_taken++;
937                                 scan++;
938                         }


change line 935
from
  mem_cgroup_del_lru(page);
to
  mem_cgroup_del_lru(cursor_page);


Thanks,
-Kame




--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-06-22 12:32 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-22  9:37 [RFC][PATCH] cgroup: fix permanent wait in rmdir KAMEZAWA Hiroyuki
2009-06-22  9:37 ` KAMEZAWA Hiroyuki
2009-06-22 10:52 ` Ingo Molnar
2009-06-22 10:52   ` Ingo Molnar
2009-06-22 11:27   ` KAMEZAWA Hiroyuki
2009-06-22 11:27     ` KAMEZAWA Hiroyuki
2009-06-22 12:16     ` Balbir Singh
2009-06-22 12:16       ` Balbir Singh
2009-06-22 12:20     ` KAMEZAWA Hiroyuki
2009-06-22 12:20       ` KAMEZAWA Hiroyuki
2009-06-22 12:26       ` Ingo Molnar
2009-06-22 12:26         ` Ingo Molnar
2009-06-22 12:32         ` KAMEZAWA Hiroyuki [this message]
2009-06-22 12:32           ` KAMEZAWA Hiroyuki
2009-06-22 23:57   ` [BUGFIX][PATCH] fix bad page removal from LRU (Was " KAMEZAWA Hiroyuki
2009-06-22 23:57     ` KAMEZAWA Hiroyuki
2009-06-23  0:47     ` Balbir Singh
2009-06-23  0:47       ` Balbir Singh
2009-06-23  7:27     ` Daisuke Nishimura
2009-06-23  7:27       ` Daisuke Nishimura
2009-06-23  7:29       ` KAMEZAWA Hiroyuki
2009-06-23  7:29         ` KAMEZAWA Hiroyuki
2009-06-23  0:22 ` KAMEZAWA Hiroyuki
2009-06-23  0:22   ` KAMEZAWA Hiroyuki
2009-06-23  4:13   ` Daisuke Nishimura
2009-06-23  4:13     ` Daisuke Nishimura
2009-06-23  4:44     ` KAMEZAWA Hiroyuki
2009-06-23  4:44       ` KAMEZAWA Hiroyuki
2009-06-23  4:54       ` Daisuke Nishimura
2009-06-23  4:54         ` Daisuke Nishimura

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f9931fe09c239cd30222bf8532e62b65.squirrel@webmail-b.css.fujitsu.com \
    --to=kamezawa.hiroyu@jp.fujitsu.com \
    --cc=balbir@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=menage@google.com \
    --cc=mingo@elte.hu \
    --cc=nishimura@mxp.nes.nec.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.