From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] ath9k: ath9k_ps_restore used after ath9k_hw_detach
Date: Tue, 23 Jun 2009 11:05:02 +0530 [thread overview]
Message-ID: <20090623053500.GA32640@vasanth-laptop> (raw)
In-Reply-To: <4A3FB00F.1020104@gmail.com>
On Mon, Jun 22, 2009 at 09:53:43PM +0530, Jiri Slaby wrote:
> Hi,
>
> In ath_detach, there is:
> ath9k_hw_detach(sc->sc_ah);
> ath9k_exit_debug(sc);
> ath9k_ps_restore(sc);
> which is obviously wrong. sc->ah is dereferenced in restore, but it's
> already freed since detach.
Yes, this is wrong.
>
> I don't quite understand why you try to set power while it's being
> already set to full sleep in ath9k_hw_detach.
>So I think the fix is to
> remove the restore call.
Yes, restoring the power state in ath_detach() is pointless.
I'll fix it,Thanks!.
Vasanth
WARNING: multiple messages have this Message-ID (diff)
From: Vasanthakumar Thiagarajan <vasanth@atheros.com>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
Jouni Malinen <Jouni.Malinen@Atheros.com>,
Sujith Manoharan <Sujith.Manoharan@Atheros.com>,
Vasanth Thiagarajan <Vasanth.Thiagarajan@Atheros.com>,
Senthilkumar Balasubramanian
<Senthilkumar.Balasubramanian@Atheros.com>,
"ath9k-devel@lists.ath9k.org" <ath9k-devel@lists.ath9k.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: Re: ath9k: ath9k_ps_restore used after ath9k_hw_detach
Date: Tue, 23 Jun 2009 11:05:02 +0530 [thread overview]
Message-ID: <20090623053500.GA32640@vasanth-laptop> (raw)
In-Reply-To: <4A3FB00F.1020104@gmail.com>
On Mon, Jun 22, 2009 at 09:53:43PM +0530, Jiri Slaby wrote:
> Hi,
>
> In ath_detach, there is:
> ath9k_hw_detach(sc->sc_ah);
> ath9k_exit_debug(sc);
> ath9k_ps_restore(sc);
> which is obviously wrong. sc->ah is dereferenced in restore, but it's
> already freed since detach.
Yes, this is wrong.
>
> I don't quite understand why you try to set power while it's being
> already set to full sleep in ath9k_hw_detach.
>So I think the fix is to
> remove the restore call.
Yes, restoring the power state in ath_detach() is pointless.
I'll fix it,Thanks!.
Vasanth
next prev parent reply other threads:[~2009-06-23 5:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 16:23 [ath9k-devel] ath9k: ath9k_ps_restore used after ath9k_hw_detach Jiri Slaby
2009-06-22 16:23 ` Jiri Slaby
2009-06-23 5:35 ` Vasanthakumar Thiagarajan [this message]
2009-06-23 5:35 ` Vasanthakumar Thiagarajan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090623053500.GA32640@vasanth-laptop \
--to=vasanth@atheros.com \
--cc=ath9k-devel@lists.ath9k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.