All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jiri Slaby <jirislaby@gmail.com>
To: ath9k-devel@lists.ath9k.org
Subject: [ath9k-devel] ath9k: ath9k_ps_restore used after ath9k_hw_detach
Date: Mon, 22 Jun 2009 18:23:43 +0200	[thread overview]
Message-ID: <4A3FB00F.1020104@gmail.com> (raw)

Hi,

In ath_detach, there is:
ath9k_hw_detach(sc->sc_ah);
ath9k_exit_debug(sc);
ath9k_ps_restore(sc);
which is obviously wrong. sc->ah is dereferenced in restore, but it's
already freed since detach.

I don't quite understand why you try to set power while it's being
already set to full sleep in ath9k_hw_detach. So I think the fix is to
remove the restore call, but dunno. So please fix it anyhow :).

WARNING: multiple messages have this Message-ID (diff)
From: Jiri Slaby <jirislaby@gmail.com>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: jmalinen@atheros.com, Sujith.Manoharan@atheros.com,
	vasanth@atheros.com, senthilkumar@atheros.com,
	ath9k-devel@lists.ath9k.org, linux-wireless@vger.kernel.org
Subject: ath9k: ath9k_ps_restore used after ath9k_hw_detach
Date: Mon, 22 Jun 2009 18:23:43 +0200	[thread overview]
Message-ID: <4A3FB00F.1020104@gmail.com> (raw)

Hi,

In ath_detach, there is:
ath9k_hw_detach(sc->sc_ah);
ath9k_exit_debug(sc);
ath9k_ps_restore(sc);
which is obviously wrong. sc->ah is dereferenced in restore, but it's
already freed since detach.

I don't quite understand why you try to set power while it's being
already set to full sleep in ath9k_hw_detach. So I think the fix is to
remove the restore call, but dunno. So please fix it anyhow :).

             reply	other threads:[~2009-06-22 16:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-22 16:23 Jiri Slaby [this message]
2009-06-22 16:23 ` ath9k: ath9k_ps_restore used after ath9k_hw_detach Jiri Slaby
2009-06-23  5:35 ` [ath9k-devel] " Vasanthakumar Thiagarajan
2009-06-23  5:35   ` Vasanthakumar Thiagarajan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A3FB00F.1020104@gmail.com \
    --to=jirislaby@gmail.com \
    --cc=ath9k-devel@lists.ath9k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.