* [ath9k-devel] ath9k: ath9k_ps_restore used after ath9k_hw_detach
@ 2009-06-22 16:23 ` Jiri Slaby
0 siblings, 0 replies; 4+ messages in thread
From: Jiri Slaby @ 2009-06-22 16:23 UTC (permalink / raw)
To: ath9k-devel
Hi,
In ath_detach, there is:
ath9k_hw_detach(sc->sc_ah);
ath9k_exit_debug(sc);
ath9k_ps_restore(sc);
which is obviously wrong. sc->ah is dereferenced in restore, but it's
already freed since detach.
I don't quite understand why you try to set power while it's being
already set to full sleep in ath9k_hw_detach. So I think the fix is to
remove the restore call, but dunno. So please fix it anyhow :).
^ permalink raw reply [flat|nested] 4+ messages in thread
* ath9k: ath9k_ps_restore used after ath9k_hw_detach
@ 2009-06-22 16:23 ` Jiri Slaby
0 siblings, 0 replies; 4+ messages in thread
From: Jiri Slaby @ 2009-06-22 16:23 UTC (permalink / raw)
To: Luis R. Rodriguez
Cc: jmalinen, Sujith.Manoharan, vasanth, senthilkumar, ath9k-devel,
linux-wireless
Hi,
In ath_detach, there is:
ath9k_hw_detach(sc->sc_ah);
ath9k_exit_debug(sc);
ath9k_ps_restore(sc);
which is obviously wrong. sc->ah is dereferenced in restore, but it's
already freed since detach.
I don't quite understand why you try to set power while it's being
already set to full sleep in ath9k_hw_detach. So I think the fix is to
remove the restore call, but dunno. So please fix it anyhow :).
^ permalink raw reply [flat|nested] 4+ messages in thread
* [ath9k-devel] ath9k: ath9k_ps_restore used after ath9k_hw_detach
2009-06-22 16:23 ` Jiri Slaby
@ 2009-06-23 5:35 ` Vasanthakumar Thiagarajan
-1 siblings, 0 replies; 4+ messages in thread
From: Vasanthakumar Thiagarajan @ 2009-06-23 5:35 UTC (permalink / raw)
To: ath9k-devel
On Mon, Jun 22, 2009 at 09:53:43PM +0530, Jiri Slaby wrote:
> Hi,
>
> In ath_detach, there is:
> ath9k_hw_detach(sc->sc_ah);
> ath9k_exit_debug(sc);
> ath9k_ps_restore(sc);
> which is obviously wrong. sc->ah is dereferenced in restore, but it's
> already freed since detach.
Yes, this is wrong.
>
> I don't quite understand why you try to set power while it's being
> already set to full sleep in ath9k_hw_detach.
>So I think the fix is to
> remove the restore call.
Yes, restoring the power state in ath_detach() is pointless.
I'll fix it,Thanks!.
Vasanth
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ath9k: ath9k_ps_restore used after ath9k_hw_detach
@ 2009-06-23 5:35 ` Vasanthakumar Thiagarajan
0 siblings, 0 replies; 4+ messages in thread
From: Vasanthakumar Thiagarajan @ 2009-06-23 5:35 UTC (permalink / raw)
To: Jiri Slaby
Cc: Luis Rodriguez, Jouni Malinen, Sujith Manoharan,
Vasanth Thiagarajan, Senthilkumar Balasubramanian,
ath9k-devel@lists.ath9k.org, linux-wireless@vger.kernel.org
On Mon, Jun 22, 2009 at 09:53:43PM +0530, Jiri Slaby wrote:
> Hi,
>
> In ath_detach, there is:
> ath9k_hw_detach(sc->sc_ah);
> ath9k_exit_debug(sc);
> ath9k_ps_restore(sc);
> which is obviously wrong. sc->ah is dereferenced in restore, but it's
> already freed since detach.
Yes, this is wrong.
>
> I don't quite understand why you try to set power while it's being
> already set to full sleep in ath9k_hw_detach.
>So I think the fix is to
> remove the restore call.
Yes, restoring the power state in ath_detach() is pointless.
I'll fix it,Thanks!.
Vasanth
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-06-23 5:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-22 16:23 [ath9k-devel] ath9k: ath9k_ps_restore used after ath9k_hw_detach Jiri Slaby
2009-06-22 16:23 ` Jiri Slaby
2009-06-23 5:35 ` [ath9k-devel] " Vasanthakumar Thiagarajan
2009-06-23 5:35 ` Vasanthakumar Thiagarajan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.