All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Avi Kivity <avi@redhat.com>,
	Andre Przywara <andre.przywara@amd.com>,
	aliguori@us.ibm.com, kvm@vger.kernel.org
Subject: Re: [Qemu-devel] Re: [PATCH 1/2] allow hypervisor CPUID bit to be overriden
Date: Tue, 23 Jun 2009 12:31:12 +0100	[thread overview]
Message-ID: <200906231231.15206.paul@codesourcery.com> (raw)
In-Reply-To: <4A40A7EC.8070100@redhat.com>

On Tuesday 23 June 2009, Avi Kivity wrote:
> On 06/23/2009 12:47 AM, Andre Przywara wrote:
> > KVM defaults to the hypervisor CPUID bit to be set, whereas pure QEMU
> > clears it. On some occasions one want to set or clear it the other way
> > round (for instance to get HyperV running inside a guest).
> > Allow the default to be overridden on the command line and fix some
> > whitespace damage on the way.
>
> It makes sense for qemu to set the hypervisor bit unconditionally.  A
> guest running under qemu is not bare metal.

I see no reason why a guest has to be told that it's running inside a VM.
In principle an appropriately configured qemu should be indistinguishable from 
real hardware. In practice it's technically infeasible to cover absolutely 
everything, but if we set this bit we're not even trying.

I have no objection to the bit being set by default for the QEMU CPU types.

Paul

WARNING: multiple messages have this Message-ID (diff)
From: Paul Brook <paul@codesourcery.com>
To: qemu-devel@nongnu.org
Cc: Andre Przywara <andre.przywara@amd.com>,
	aliguori@us.ibm.com, Avi Kivity <avi@redhat.com>,
	kvm@vger.kernel.org
Subject: Re: [Qemu-devel] Re: [PATCH 1/2] allow hypervisor CPUID bit to be overriden
Date: Tue, 23 Jun 2009 12:31:12 +0100	[thread overview]
Message-ID: <200906231231.15206.paul@codesourcery.com> (raw)
In-Reply-To: <4A40A7EC.8070100@redhat.com>

On Tuesday 23 June 2009, Avi Kivity wrote:
> On 06/23/2009 12:47 AM, Andre Przywara wrote:
> > KVM defaults to the hypervisor CPUID bit to be set, whereas pure QEMU
> > clears it. On some occasions one want to set or clear it the other way
> > round (for instance to get HyperV running inside a guest).
> > Allow the default to be overridden on the command line and fix some
> > whitespace damage on the way.
>
> It makes sense for qemu to set the hypervisor bit unconditionally.  A
> guest running under qemu is not bare metal.

I see no reason why a guest has to be told that it's running inside a VM.
In principle an appropriately configured qemu should be indistinguishable from 
real hardware. In practice it's technically infeasible to cover absolutely 
everything, but if we set this bit we're not even trying.

I have no objection to the bit being set by default for the QEMU CPU types.

Paul

  reply	other threads:[~2009-06-23 11:31 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-22 21:47 [PATCH 1/2] allow hypervisor CPUID bit to be overriden Andre Przywara
2009-06-22 21:47 ` [Qemu-devel] " Andre Przywara
2009-06-23 10:01 ` Avi Kivity
2009-06-23 10:01   ` [Qemu-devel] " Avi Kivity
2009-06-23 11:31   ` Paul Brook [this message]
2009-06-23 11:31     ` Paul Brook
2009-06-23 11:35     ` Avi Kivity
2009-06-23 11:35       ` Avi Kivity
2009-06-23 11:43       ` Paul Brook
2009-06-23 11:43         ` Paul Brook
2009-06-24 21:20       ` Jamie Lokier
2009-06-24 21:20         ` Jamie Lokier
2009-06-25  5:23         ` Gleb Natapov
2009-06-25  5:23           ` Gleb Natapov
2009-06-23 12:37 ` [PATCH 1/2 v2] " Andre Przywara
2009-06-23 12:37   ` [Qemu-devel] " Andre Przywara
2009-06-23 14:17   ` Anthony Liguori
2009-06-23 14:17     ` [Qemu-devel] " Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200906231231.15206.paul@codesourcery.com \
    --to=paul@codesourcery.com \
    --cc=aliguori@us.ibm.com \
    --cc=andre.przywara@amd.com \
    --cc=avi@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.