From: Theodore Tso <tytso-3s7WtUTddSA@public.gmane.org>
To: Jesper Dangaard Brouer <hawk-4UpuNZONu4c@public.gmane.org>
Cc: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
"Paul E. McKenney"
<paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
dougthompson-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org,
bluesmoke-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org,
Patrick McHardy <kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org>,
christine.caulfield-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org,
Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org,
yoshfuji-VfPWfsRibaP+Ru+s062T9g@public.gmane.org,
shemminger-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org,
linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org,
neilb-l3A5Bk7waGM@public.gmane.org,
linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
adilger-xsfywfwIY+M@public.gmane.org,
netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 01/10] ext4: Use rcu_barrier() on module unload.
Date: Sun, 5 Jul 2009 22:31:13 -0400 [thread overview]
Message-ID: <20090706023113.GE6706@mit.edu> (raw)
In-Reply-To: <20090623150358.22490.24818.stgit@localhost>
On Tue, Jun 23, 2009 at 05:03:59PM +0200, Jesper Dangaard Brouer wrote:
> The ext4 module uses rcu_call() thus it should use rcu_barrier()on
> module unload.
>
> The kmem cache ext4_pspace_cachep is sometimes free'ed using
> call_rcu() callbacks. Thus, we must wait for completion of call_rcu()
> before doing kmem_cache_destroy().
>
> I have difficult determining if no new call_rcu() callbacks can be envoked.
> Would the maintainer please verify this?
Yes, that's correct. Thanks; I've included this in the ext4 patch
queue.
- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Theodore Tso <tytso@mit.edu>
To: Jesper Dangaard Brouer <hawk-4UpuNZONu4c@public.gmane.org>
Cc: "David S. Miller" <davem@davemloft.net>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dougthompson@xmission.com, bluesmoke-devel@lists.sourceforge.net,
axboe@kernel.dk, Patrick McHardy <kaber@trash.net>,
christine.caulfield@googlemail.com, Trond.Myklebust@netapp.com,
linux-wireless@vger.kernel.org, johannes@sipsolutions.net,
yoshfuji@linux-ipv6.org, shemminger@linux-foundation.org,
linux-nfs@vger.kernel.org, bfields@fieldses.org, neilb@suse.de,
linux-ext4@vger.kernel.org, adilger-xsfywfwIY+M@public.gmane.org,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 01/10] ext4: Use rcu_barrier() on module unload.
Date: Sun, 5 Jul 2009 22:31:13 -0400 [thread overview]
Message-ID: <20090706023113.GE6706@mit.edu> (raw)
In-Reply-To: <20090623150358.22490.24818.stgit@localhost>
On Tue, Jun 23, 2009 at 05:03:59PM +0200, Jesper Dangaard Brouer wrote:
> The ext4 module uses rcu_call() thus it should use rcu_barrier()on
> module unload.
>
> The kmem cache ext4_pspace_cachep is sometimes free'ed using
> call_rcu() callbacks. Thus, we must wait for completion of call_rcu()
> before doing kmem_cache_destroy().
>
> I have difficult determining if no new call_rcu() callbacks can be envoked.
> Would the maintainer please verify this?
Yes, that's correct. Thanks; I've included this in the ext4 patch
queue.
- Ted
WARNING: multiple messages have this Message-ID (diff)
From: Theodore Tso <tytso@mit.edu>
To: Jesper Dangaard Brouer <hawk@comx.dk>
Cc: "David S. Miller" <davem@davemloft.net>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
dougthompson@xmission.com, bluesmoke-devel@lists.sourceforge.net,
axboe@kernel.dk, Patrick McHardy <kaber@trash.net>,
christine.caulfield@googlemail.com, Trond.Myklebust@netapp.com,
linux-wireless@vger.kernel.org, johannes@sipsolutions.net,
yoshfuji@linux-ipv6.org, shemminger@linux-foundation.org,
linux-nfs@vger.kernel.org, bfields@fieldses.org, neilb@suse.de,
linux-ext4@vger.kernel.org, adilger@sun.com,
netfilter-devel@vger.kernel.org
Subject: Re: [PATCH 01/10] ext4: Use rcu_barrier() on module unload.
Date: Sun, 5 Jul 2009 22:31:13 -0400 [thread overview]
Message-ID: <20090706023113.GE6706@mit.edu> (raw)
In-Reply-To: <20090623150358.22490.24818.stgit@localhost>
On Tue, Jun 23, 2009 at 05:03:59PM +0200, Jesper Dangaard Brouer wrote:
> The ext4 module uses rcu_call() thus it should use rcu_barrier()on
> module unload.
>
> The kmem cache ext4_pspace_cachep is sometimes free'ed using
> call_rcu() callbacks. Thus, we must wait for completion of call_rcu()
> before doing kmem_cache_destroy().
>
> I have difficult determining if no new call_rcu() callbacks can be envoked.
> Would the maintainer please verify this?
Yes, that's correct. Thanks; I've included this in the ext4 patch
queue.
- Ted
next prev parent reply other threads:[~2009-07-06 2:31 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-23 15:03 [PATCH 00/10] We must use rcu_barrier() on module unload Jesper Dangaard Brouer
2009-06-23 15:03 ` [PATCH 01/10] ext4: Use " Jesper Dangaard Brouer
2009-07-06 2:31 ` Theodore Tso [this message]
2009-07-06 2:31 ` Theodore Tso
2009-07-06 2:31 ` Theodore Tso
2009-06-23 15:04 ` [PATCH 02/10] bridge: Use rcu_barrier() instead of syncronize_net() on unload Jesper Dangaard Brouer
2009-06-23 15:04 ` [PATCH 03/10] mac80211: Use rcu_barrier() " Jesper Dangaard Brouer
2009-06-23 15:15 ` Johannes Berg
[not found] ` <1245770155.21314.38.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-06-24 10:06 ` Jesper Dangaard Brouer
2009-06-24 10:06 ` Jesper Dangaard Brouer
2009-06-24 10:06 ` Jesper Dangaard Brouer
2009-06-24 10:21 ` Johannes Berg
[not found] ` <1245838862.21314.48.camel-YfaajirXv2244ywRPIzf9A@public.gmane.org>
2009-06-24 11:32 ` Jesper Dangaard Brouer
2009-06-24 11:32 ` Jesper Dangaard Brouer
2009-06-24 11:32 ` Jesper Dangaard Brouer
2009-06-24 11:39 ` Johannes Berg
2009-06-23 15:04 ` [PATCH 04/10] sunrpc: " Jesper Dangaard Brouer
2009-06-23 16:59 ` Trond Myklebust
2009-06-23 15:04 ` [PATCH 05/10] nfs: Use rcu_barrier() on module unload Jesper Dangaard Brouer
2009-06-23 15:04 ` Jesper Dangaard Brouer
2009-06-23 15:04 ` Jesper Dangaard Brouer
2009-06-23 15:04 ` [PATCH 06/10] ipv6: " Jesper Dangaard Brouer
2009-06-23 15:04 ` Jesper Dangaard Brouer
2009-06-23 15:04 ` Jesper Dangaard Brouer
2009-06-23 15:04 ` [PATCH 07/10] decnet: " Jesper Dangaard Brouer
2009-06-24 6:23 ` Chrissie Caulfield
2009-06-24 11:44 ` Jesper Dangaard Brouer
[not found] ` <1245843884.6695.54.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-06-24 12:09 ` Jesper Dangaard Brouer
2009-06-24 12:09 ` Jesper Dangaard Brouer
2009-06-24 12:09 ` Jesper Dangaard Brouer
[not found] ` <1245845367.24921.3.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-06-24 13:50 ` Chrissie Caulfield
2009-06-24 13:50 ` Chrissie Caulfield
2009-06-24 13:50 ` Chrissie Caulfield
[not found] ` <5A680E0A-EFEB-44EA-9F06-F338E6CBD6D1-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org>
2009-06-25 11:52 ` Jesper Dangaard Brouer
2009-06-25 11:52 ` Jesper Dangaard Brouer
2009-06-25 11:52 ` Jesper Dangaard Brouer
[not found] ` <1245930729.24921.67.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-06-25 23:10 ` David Miller
2009-06-25 23:10 ` David Miller
2009-06-25 23:10 ` David Miller
[not found] ` <20090625.161046.19938291.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2009-06-26 19:18 ` Jesper Dangaard Brouer
2009-06-26 19:18 ` Jesper Dangaard Brouer
2009-06-26 19:18 ` Jesper Dangaard Brouer
2009-06-27 3:15 ` Christian Kujau
2009-06-27 7:35 ` Jesper Dangaard Brouer
2009-06-23 15:04 ` [PATCH 08/10] edac_core: Uses call_rcu() and its own wait_for_completion scheme Jesper Dangaard Brouer
2009-06-23 15:04 ` Jesper Dangaard Brouer
2009-06-23 15:04 ` Jesper Dangaard Brouer
2009-06-23 15:04 ` [PATCH 09/10] cfq-iosched: Uses its own open-coded rcu_barrier Jesper Dangaard Brouer
2009-06-23 15:04 ` Jesper Dangaard Brouer
2009-06-23 15:04 ` Jesper Dangaard Brouer
2009-06-24 6:42 ` Jens Axboe
2009-06-24 6:42 ` Jens Axboe
2009-06-24 6:42 ` Jens Axboe
[not found] ` <20090624064236.GE31415-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org>
2009-06-24 14:05 ` Paul E. McKenney
2009-06-24 14:05 ` Paul E. McKenney
2009-06-24 14:05 ` Paul E. McKenney
2009-06-23 15:04 ` [PATCH 10/10] nf_conntrack: Use rcu_barrier() Jesper Dangaard Brouer
2009-06-23 15:04 ` Jesper Dangaard Brouer
2009-06-23 15:04 ` Jesper Dangaard Brouer
2009-06-23 16:23 ` Patrick McHardy
2009-06-24 9:02 ` Jesper Dangaard Brouer
2009-06-24 9:40 ` [PATCH v2 10/10] nf_conntrack: Use rcu_barrier() and fix kmem_cache_create flags Jesper Dangaard Brouer
2009-06-24 13:58 ` Patrick McHardy
2009-06-25 9:29 ` Jesper Dangaard Brouer
2009-06-25 9:29 ` Jesper Dangaard Brouer
2009-06-25 10:02 ` [PATCH v3 10/10] nf_conntrack: Use rcu_barrier() Jesper Dangaard Brouer
2009-06-25 10:02 ` Jesper Dangaard Brouer
2009-06-25 14:33 ` Patrick McHardy
2009-06-25 14:33 ` Patrick McHardy
2009-06-25 13:59 ` [PATCH v2 10/10] nf_conntrack: Use rcu_barrier() and fix kmem_cache_create flags Patrick McHardy
2009-06-25 13:59 ` Patrick McHardy
2009-06-25 19:32 ` Paul E. McKenney
2009-06-25 19:32 ` Paul E. McKenney
2009-06-24 1:44 ` [PATCH 00/10] We must use rcu_barrier() on module unload Paul E. McKenney
2009-06-24 1:44 ` Paul E. McKenney
2009-06-24 1:44 ` Paul E. McKenney
2009-06-24 7:02 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090706023113.GE6706@mit.edu \
--to=tytso-3s7wtutddsa@public.gmane.org \
--cc=Trond.Myklebust-HgOvQuBEEgTQT0dZR+AlfA@public.gmane.org \
--cc=adilger-xsfywfwIY+M@public.gmane.org \
--cc=axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org \
--cc=bfields-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org \
--cc=bluesmoke-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=christine.caulfield-gM/Ye1E23mwN+BqQ9rBEUg@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=dougthompson-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
--cc=hawk-4UpuNZONu4c@public.gmane.org \
--cc=johannes-cdvu00un1VgdHxzADdlk8Q@public.gmane.org \
--cc=kaber-dcUjhNyLwpNeoWH0uzbU5w@public.gmane.org \
--cc=linux-ext4-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-nfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=neilb-l3A5Bk7waGM@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=netfilter-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=paulmck-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=shemminger-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=yoshfuji-VfPWfsRibaP+Ru+s062T9g@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.