* [PATCH 1/2] ppc vdso: make sure rc is defined
@ 2009-07-06 23:34 Serge E. Hallyn
[not found] ` <20090706233425.GA3186-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Serge E. Hallyn @ 2009-07-06 23:34 UTC (permalink / raw)
To: Oren Laadan, Nathan T Lynch, Alexey Dobriyan; +Cc: Linux Containers
Signed-off-by: Serge Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
---
arch/powerpc/kernel/vdso.c | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/arch/powerpc/kernel/vdso.c b/arch/powerpc/kernel/vdso.c
index 48beff6..679b394 100644
--- a/arch/powerpc/kernel/vdso.c
+++ b/arch/powerpc/kernel/vdso.c
@@ -240,8 +240,10 @@ int arch_setup_additional_pages(struct linux_binprm *bprm,
}
/* for restart(2), double check that we got we asked for */
- if (start && vdso_base != start)
+ if (start && vdso_base != start) {
+ rc = -EBUSY;
goto fail_mmapsem;
+ }
/*
* our vma flags don't have VM_WRITE so by default, the process isn't
--
1.6.2.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] ppc vdso: make sure rc is defined
[not found] ` <20090706233425.GA3186-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
@ 2009-07-07 20:47 ` Nathan Lynch
[not found] ` <m3my7gp6dw.fsf-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 3+ messages in thread
From: Nathan Lynch @ 2009-07-07 20:47 UTC (permalink / raw)
To: Serge E. Hallyn; +Cc: Linux Containers, Alexey Dobriyan
"Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> writes:
> Signed-off-by: Serge Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> ---
> arch/powerpc/kernel/vdso.c | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/arch/powerpc/kernel/vdso.c b/arch/powerpc/kernel/vdso.c
> index 48beff6..679b394 100644
> --- a/arch/powerpc/kernel/vdso.c
> +++ b/arch/powerpc/kernel/vdso.c
> @@ -240,8 +240,10 @@ int arch_setup_additional_pages(struct linux_binprm *bprm,
> }
>
> /* for restart(2), double check that we got we asked for */
> - if (start && vdso_base != start)
> + if (start && vdso_base != start) {
> + rc = -EBUSY;
> goto fail_mmapsem;
> + }
>
> /*
> * our vma flags don't have VM_WRITE so by default, the process isn't
Is this why you sent this patch?
cc1: warnings being treated as errors
arch/powerpc/kernel/vdso.c: In function arch_setup_additional_pages:
arch/powerpc/kernel/vdso.c:194: error: rc may be used uninitialized in this function
If so, looks fine to me.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/2] ppc vdso: make sure rc is defined
[not found] ` <m3my7gp6dw.fsf-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
@ 2009-07-07 20:58 ` Serge E. Hallyn
0 siblings, 0 replies; 3+ messages in thread
From: Serge E. Hallyn @ 2009-07-07 20:58 UTC (permalink / raw)
To: Nathan Lynch; +Cc: Linux Containers, Alexey Dobriyan
Quoting Nathan Lynch (ntl-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org):
> "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org> writes:
> > Signed-off-by: Serge Hallyn <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
> > ---
> > arch/powerpc/kernel/vdso.c | 4 +++-
> > 1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/powerpc/kernel/vdso.c b/arch/powerpc/kernel/vdso.c
> > index 48beff6..679b394 100644
> > --- a/arch/powerpc/kernel/vdso.c
> > +++ b/arch/powerpc/kernel/vdso.c
> > @@ -240,8 +240,10 @@ int arch_setup_additional_pages(struct linux_binprm *bprm,
> > }
> >
> > /* for restart(2), double check that we got we asked for */
> > - if (start && vdso_base != start)
> > + if (start && vdso_base != start) {
> > + rc = -EBUSY;
> > goto fail_mmapsem;
> > + }
> >
> > /*
> > * our vma flags don't have VM_WRITE so by default, the process isn't
>
> Is this why you sent this patch?
>
> cc1: warnings being treated as errors
> arch/powerpc/kernel/vdso.c: In function arch_setup_additional_pages:
> arch/powerpc/kernel/vdso.c:194: error: rc may be used uninitialized in this function
Yup.
> If so, looks fine to me.
-serge
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-07-07 20:58 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-07-06 23:34 [PATCH 1/2] ppc vdso: make sure rc is defined Serge E. Hallyn
[not found] ` <20090706233425.GA3186-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
2009-07-07 20:47 ` Nathan Lynch
[not found] ` <m3my7gp6dw.fsf-e+AXbWqSrlAAvxtiuMwx3w@public.gmane.org>
2009-07-07 20:58 ` Serge E. Hallyn
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.