From: Nick Piggin <npiggin@suse.de>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [rfc][patch 4/4] fs: tmpfs, ext2 use new truncate
Date: Wed, 8 Jul 2009 14:22:50 +0200 [thread overview]
Message-ID: <20090708122250.GP2714@wotan.suse.de> (raw)
In-Reply-To: <20090708111420.GB20924@duck.suse.cz>
On Wed, Jul 08, 2009 at 01:14:20PM +0200, Jan Kara wrote:
> On Wed 08-07-09 08:53:27, Nick Piggin wrote:
> > On Tue, Jul 07, 2009 at 12:38:29PM -0400, Christoph Hellwig wrote:
> > > We can't move this to the caller easily. ext2_delete_inode gets
> > > called for all inodes, but we only want to go on truncating for the
> > > limited set that passes this check.
> >
> > Hmm, shouldn't they have no ->i_blocks in that case?
> Not necessarily. Inode can have extended attributes set and those can
> be stored in a special block which is accounted in i_blocks.
OK fair enough. But I don't know if all those checks are
realy appropriate. For example an IS_APPEND inode should
be able to have its blocks trimmed off if a write fails.
WARNING: multiple messages have this Message-ID (diff)
From: Nick Piggin <npiggin@suse.de>
To: Jan Kara <jack@suse.cz>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org
Subject: Re: [rfc][patch 4/4] fs: tmpfs, ext2 use new truncate
Date: Wed, 8 Jul 2009 14:22:50 +0200 [thread overview]
Message-ID: <20090708122250.GP2714@wotan.suse.de> (raw)
In-Reply-To: <20090708111420.GB20924@duck.suse.cz>
On Wed, Jul 08, 2009 at 01:14:20PM +0200, Jan Kara wrote:
> On Wed 08-07-09 08:53:27, Nick Piggin wrote:
> > On Tue, Jul 07, 2009 at 12:38:29PM -0400, Christoph Hellwig wrote:
> > > We can't move this to the caller easily. ext2_delete_inode gets
> > > called for all inodes, but we only want to go on truncating for the
> > > limited set that passes this check.
> >
> > Hmm, shouldn't they have no ->i_blocks in that case?
> Not necessarily. Inode can have extended attributes set and those can
> be stored in a special block which is accounted in i_blocks.
OK fair enough. But I don't know if all those checks are
realy appropriate. For example an IS_APPEND inode should
be able to have its blocks trimmed off if a write fails.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-07-08 12:23 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-07 14:44 [rfc][patch 1/4] fs: new truncate helpers Nick Piggin
2009-07-07 14:44 ` Nick Piggin
2009-07-07 14:46 ` [rfc][patch 2/4] fs: use " Nick Piggin
2009-07-07 14:46 ` Nick Piggin
2009-07-07 14:53 ` Christoph Hellwig
2009-07-07 14:53 ` Christoph Hellwig
2009-07-07 14:48 ` [rfc][patch 3/4] fs: new truncate sequence Nick Piggin
2009-07-07 14:48 ` Nick Piggin
2009-07-07 14:58 ` Christoph Hellwig
2009-07-07 14:58 ` Christoph Hellwig
2009-07-07 15:02 ` Nick Piggin
2009-07-07 15:02 ` Nick Piggin
2009-07-07 15:07 ` Christoph Hellwig
2009-07-07 15:07 ` Christoph Hellwig
2009-07-07 15:48 ` Nick Piggin
2009-07-07 15:48 ` Nick Piggin
2009-07-07 16:30 ` Christoph Hellwig
2009-07-07 16:30 ` Christoph Hellwig
2009-07-08 6:32 ` Nick Piggin
2009-07-08 6:32 ` Nick Piggin
2009-07-08 10:47 ` Christoph Hellwig
2009-07-08 10:47 ` Christoph Hellwig
2009-07-08 12:34 ` Nick Piggin
2009-07-08 12:34 ` Nick Piggin
2009-07-08 12:40 ` Christoph Hellwig
2009-07-08 12:40 ` Christoph Hellwig
2009-07-08 12:48 ` Nick Piggin
2009-07-08 12:48 ` Nick Piggin
2009-07-08 16:07 ` Boaz Harrosh
2009-07-08 16:07 ` Boaz Harrosh
2009-07-09 7:51 ` Nick Piggin
2009-07-09 7:51 ` Nick Piggin
2009-07-12 8:55 ` Boaz Harrosh
2009-07-12 8:55 ` Boaz Harrosh
2009-07-12 14:47 ` Christoph Hellwig
2009-07-12 14:47 ` Christoph Hellwig
2009-07-12 15:00 ` Boaz Harrosh
2009-07-12 15:00 ` Boaz Harrosh
2009-07-13 6:59 ` Nick Piggin
2009-07-13 6:59 ` Nick Piggin
2009-07-13 8:54 ` Boaz Harrosh
2009-07-13 8:54 ` Boaz Harrosh
2009-07-13 9:00 ` Nick Piggin
2009-07-13 9:00 ` Nick Piggin
2009-07-13 11:17 ` Boaz Harrosh
2009-07-13 11:17 ` Boaz Harrosh
2009-07-13 11:32 ` Nick Piggin
2009-07-13 11:32 ` Nick Piggin
2009-07-13 13:53 ` Christoph Hellwig
2009-07-13 13:53 ` Christoph Hellwig
2009-07-13 14:05 ` Nick Piggin
2009-07-13 14:05 ` Nick Piggin
2009-07-13 14:10 ` Christoph Hellwig
2009-07-13 14:10 ` Christoph Hellwig
2009-07-07 14:48 ` [rfc][patch 1/4] fs: new truncate helpers Christoph Hellwig
2009-07-07 14:48 ` Christoph Hellwig
2009-07-07 14:49 ` [rfc][patch 4/4] fs: tmpfs, ext2 use new truncate Nick Piggin
2009-07-07 14:49 ` Nick Piggin
2009-07-07 16:38 ` Christoph Hellwig
2009-07-07 16:38 ` Christoph Hellwig
2009-07-08 6:53 ` Nick Piggin
2009-07-08 6:53 ` Nick Piggin
2009-07-08 11:14 ` Jan Kara
2009-07-08 11:14 ` Jan Kara
2009-07-08 12:22 ` Nick Piggin [this message]
2009-07-08 12:22 ` Nick Piggin
2009-07-08 12:32 ` Christoph Hellwig
2009-07-08 12:32 ` Christoph Hellwig
2009-07-08 12:39 ` Nick Piggin
2009-07-08 12:39 ` Nick Piggin
2009-07-08 13:49 ` Christoph Hellwig
2009-07-08 13:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090708122250.GP2714@wotan.suse.de \
--to=npiggin@suse.de \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.