Re: [rfc][patch 3/4] fs: new truncate sequence

[Boaz Harrosh <bharrosh@panasas.com>]

On 07/13/2009 09:59 AM, Nick Piggin wrote:
> On Sun, Jul 12, 2009 at 10:47:18AM -0400, Christoph Hellwig wrote:
>> On Sun, Jul 12, 2009 at 11:55:51AM +0300, Boaz Harrosh wrote:
>>> I wish you would split it.
>>>
>>> one - helper to be called by converted file systems
>>>       (Which just ignores the ATTR_SIZE)
>>> second - to be set into .setattr which does the simple_setsize + above.
>>>
>>> More clear for FS users like me (and that ugly unmask of ATTR_SIZE)
>>>
>>> or it's just me?
>> Yeah, that seems be a lot cleaner.  But let's wait until we got
>> rid of ->truncate for all filesystems to have the bigger picture.
> 
> Agreed, if it is a common sequence / requirement for filesystems
> then of course I will not object to a helper to make things clearer
> or share code.
> 
> I would like to see inode_setattr renamed into simple_setattr, and
> then also .setattr made mandatory, so I don't like to cut code out
> of inode_setattr which makes it unable to be the simple_setattr
> after the old truncate code is removed.
> 

I thought you meant inode_setattr will go away. There will
only be simple_setattr() and inode_setattr_nosize()

For the time been simple_setattr() will also take care
of old ->truncate FSs. And in the absence of .setattr
simple_setattr() is called. Have I miss-understood?

again please tell me when all this is in effect I want
to do the conversion in exofs.

[BTW these changes are a life saver for me in regard to
the kind of things I need to do for pNFS-exports]

Thanks
Boaz