All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jamie Lokier <jamie@shareable.org>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Jan Kiszka <jan.kiszka@web.de>, Kevin Wolf <kwolf@redhat.com>,
	linuxram@us.ibm.com, qemu-devel@nongnu.org,
	kvm-devel <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [PATCH] rev3: support colon in filenames
Date: Wed, 15 Jul 2009 23:51:51 +0100	[thread overview]
Message-ID: <20090715225150.GU3056@shareable.org> (raw)
In-Reply-To: <4A5E5B00.10304@us.ibm.com>

Anthony Liguori wrote:
> Jamie Lokier wrote:
> >Anthony Liguori wrote:
> >  
> >>Jan Kiszka wrote:
> >>    
> >>>We would still have to deal with the fact that so far '\' had no special
> >>>meaning on Windows - except that is was the well-known path separator.
> >>>So redefining its meaning would break a bit...
> >>> 
> >>>      
> >>That's the problem.  You will break existing Windows users.
> >>
> >>I know this goes against the current momentum in qemu, but overloading 
> >>one option with a bunch of parameters seems absolutely silly to me.
> >>
> >>IMHO, -drive file=foo.img,if=virtio,cache=off should have always been at 
> >>least three parameters.
> >>    
> >
> >That's fine for command lines.  I don't necessarily disagree with you.
> >
> >But how do you propose to handle paths in monitor commands, when the
> >path contains a space/quote/whatever as it often does on Windows ("My
> >Documents", "Program Files")?
> >  
> 
> Same basic rules apply.  The monitor should use shell-style quoting.

So instead of consistency, you like the idea of using different
quoting rules for the monitor than for command line arguments?

-- Jamie

WARNING: multiple messages have this Message-ID (diff)
From: Jamie Lokier <jamie@shareable.org>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
	linuxram@us.ibm.com, Jan Kiszka <jan.kiszka@web.de>,
	qemu-devel@nongnu.org, kvm-devel <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [PATCH] rev3: support colon in filenames
Date: Wed, 15 Jul 2009 23:51:51 +0100	[thread overview]
Message-ID: <20090715225150.GU3056@shareable.org> (raw)
In-Reply-To: <4A5E5B00.10304@us.ibm.com>

Anthony Liguori wrote:
> Jamie Lokier wrote:
> >Anthony Liguori wrote:
> >  
> >>Jan Kiszka wrote:
> >>    
> >>>We would still have to deal with the fact that so far '\' had no special
> >>>meaning on Windows - except that is was the well-known path separator.
> >>>So redefining its meaning would break a bit...
> >>> 
> >>>      
> >>That's the problem.  You will break existing Windows users.
> >>
> >>I know this goes against the current momentum in qemu, but overloading 
> >>one option with a bunch of parameters seems absolutely silly to me.
> >>
> >>IMHO, -drive file=foo.img,if=virtio,cache=off should have always been at 
> >>least three parameters.
> >>    
> >
> >That's fine for command lines.  I don't necessarily disagree with you.
> >
> >But how do you propose to handle paths in monitor commands, when the
> >path contains a space/quote/whatever as it often does on Windows ("My
> >Documents", "Program Files")?
> >  
> 
> Same basic rules apply.  The monitor should use shell-style quoting.

So instead of consistency, you like the idea of using different
quoting rules for the monitor than for command line arguments?

-- Jamie

  reply	other threads:[~2009-07-15 22:51 UTC|newest]

Thread overview: 119+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-24 16:58 [PATCH] support colon in filenames Ram Pai
2009-06-24 17:08 ` Balbir Singh
2009-06-24 17:30   ` Ram Pai
2009-06-24 18:31     ` Balbir Singh
2009-06-24 17:26 ` Amit Shah
2009-06-24 17:27   ` Amit Shah
2009-06-24 17:57 ` Ram Pai
2009-06-24 17:57   ` [Qemu-devel] " Ram Pai
2009-06-25  9:14   ` Kevin Wolf
2009-06-25  9:14     ` [Qemu-devel] " Kevin Wolf
2009-06-25 17:52     ` Ram Pai
2009-06-25 17:52       ` [Qemu-devel] " Ram Pai
2009-06-26  6:53       ` Kevin Wolf
2009-06-26  6:53         ` [Qemu-devel] " Kevin Wolf
2009-06-26  6:38     ` rev1 " Ram Pai
2009-06-26  6:38       ` [Qemu-devel] " Ram Pai
2009-06-26  7:45       ` Kevin Wolf
2009-06-26  7:45         ` [Qemu-devel] " Kevin Wolf
2009-06-27  0:41         ` rev2 " Ram Pai
2009-06-27  0:41           ` [Qemu-devel] " Ram Pai
2009-07-02  5:08           ` [PATCH] rev3: " Ram Pai
2009-07-02  5:08             ` [Qemu-devel] " Ram Pai
2009-07-02  8:52             ` Kevin Wolf
2009-07-02 12:52               ` Anthony Liguori
2009-07-02 13:18                 ` Kevin Wolf
2009-07-08  8:30                   ` [PATCH] rev4: " Ram Pai
2009-07-08  8:30                     ` [Qemu-devel] " Ram Pai
2009-07-08 15:05                     ` Jan Kiszka
2009-07-08 15:05                       ` [Qemu-devel] " Jan Kiszka
2009-07-10 13:31                     ` Anthony Liguori
2009-07-10 13:31                       ` [Qemu-devel] " Anthony Liguori
2009-07-15  7:51                     ` [PATCH] rev5: " Ram Pai
2009-07-15  7:51                       ` [Qemu-devel] " Ram Pai
2009-07-15  9:30                       ` Jan Kiszka
2009-07-15  9:30                         ` [Qemu-devel] " Jan Kiszka
2009-07-15 17:03                         ` Ram Pai
2009-07-15 17:03                           ` [Qemu-devel] " Ram Pai
2009-07-15 18:20                           ` Jamie Lokier
2009-07-15 18:20                             ` Jamie Lokier
2009-07-15 18:44                             ` Ram Pai
2009-07-15 18:44                               ` Ram Pai
2009-07-15 21:04                               ` qcow2 relative paths (was: [PATCH] rev5: support colon in filenames) Jamie Lokier
2009-07-15 21:04                                 ` [Qemu-devel] " Jamie Lokier
2009-07-15 21:14                                 ` qcow2 relative paths Jan Kiszka
2009-07-15 21:14                                   ` [Qemu-devel] " Jan Kiszka
2009-07-16  2:28                                 ` qcow2 relative paths (was: [PATCH] rev5: support colon in filenames) Ram Pai
2009-07-16  2:28                                   ` [Qemu-devel] " Ram Pai
2009-07-16  7:38                                   ` qcow2 relative paths Kevin Wolf
2009-07-16  7:38                                     ` [Qemu-devel] " Kevin Wolf
2009-07-16  7:51                                     ` Ram Pai
2009-07-16  7:51                                       ` [Qemu-devel] " Ram Pai
2009-07-16  7:39                                 ` [PATCH] rev6: support colon in filenames Ram Pai
2009-07-16  7:39                                   ` [Qemu-devel] " Ram Pai
2009-07-17 23:17                                   ` [PATCH] rev7: " Ram Pai
2009-07-17 23:17                                     ` [Qemu-devel] " Ram Pai
2009-07-21 12:42                                     ` Kevin Wolf
2009-07-21 12:42                                       ` [Qemu-devel] " Kevin Wolf
2009-08-06  6:27                                       ` Ram Pai
2009-08-06  6:27                                         ` [Qemu-devel] " Ram Pai
2009-08-06  6:47                                         ` [PATCH] rev8: " Ram Pai
2009-08-06  6:47                                           ` [Qemu-devel] " Ram Pai
2009-07-15 15:04                       ` [Qemu-devel] [PATCH] rev5: " Blue Swirl
2009-07-15 15:04                         ` Blue Swirl
2009-07-15 15:14                         ` Anthony Liguori
2009-07-15 15:14                           ` Anthony Liguori
2009-07-15 15:29                           ` Blue Swirl
2009-07-15 15:29                             ` Blue Swirl
2009-07-15 15:40                             ` Anthony Liguori
2009-07-15 15:40                               ` Anthony Liguori
2009-07-15 16:42                               ` Kevin Wolf
2009-07-15 16:42                                 ` Kevin Wolf
2009-07-15 17:47                               ` Michael S. Tsirkin
2009-07-15 17:47                                 ` Michael S. Tsirkin
2009-07-16 10:57                               ` Amit Shah
2009-07-16 10:57                                 ` Amit Shah
2009-07-16 13:43                               ` Markus Armbruster
2009-07-16 13:43                                 ` Markus Armbruster
2009-07-16 14:10                                 ` Anthony Liguori
2009-07-16 14:10                                   ` Anthony Liguori
2009-07-16 15:13                                   ` Gerd Hoffmann
2009-07-16 15:13                                     ` Gerd Hoffmann
2009-07-16 15:12                                 ` Gerd Hoffmann
2009-07-16 15:12                                   ` Gerd Hoffmann
2009-07-15 15:34                           ` Kevin Wolf
2009-07-15 15:34                             ` Kevin Wolf
2009-07-15 15:41                             ` Anthony Liguori
2009-07-15 15:41                               ` Anthony Liguori
2009-07-15 15:52                           ` Paul Brook
2009-07-15 15:52                             ` Paul Brook
2009-07-15 16:03                           ` Gerd Hoffmann
2009-07-15 16:03                             ` Gerd Hoffmann
2009-07-15 16:08                             ` Paul Brook
2009-07-15 16:08                               ` Paul Brook
2009-07-16  7:39                         ` Ram Pai
2009-07-16  7:39                           ` Ram Pai
2009-07-16  7:43                           ` Kevin Wolf
2009-07-16  7:43                             ` Kevin Wolf
2009-07-15 18:14                   ` [Qemu-devel] [PATCH] rev3: " Jamie Lokier
2009-07-15 20:54                     ` Jan Kiszka
2009-07-15 21:36                       ` Jamie Lokier
2009-07-15 21:42                         ` Jan Kiszka
2009-07-15 22:00                           ` Jamie Lokier
2009-07-15 22:16                           ` Anthony Liguori
2009-07-15 22:16                             ` Anthony Liguori
2009-07-15 22:39                             ` Jamie Lokier
2009-07-15 22:39                               ` Jamie Lokier
2009-07-15 22:41                               ` Anthony Liguori
2009-07-15 22:41                                 ` Anthony Liguori
2009-07-15 22:51                                 ` Jamie Lokier [this message]
2009-07-15 22:51                                   ` Jamie Lokier
2009-07-16  0:03                                   ` Anthony Liguori
2009-07-16  0:03                                     ` Anthony Liguori
2009-07-16  7:20                                     ` Jan Kiszka
2009-07-16  7:20                                       ` Jan Kiszka
2009-07-16  7:16                             ` Jan Kiszka
2009-07-16  7:16                               ` Jan Kiszka
2009-07-16  8:01                     ` Kevin Wolf
2009-07-16 23:53                     ` Paul Brook
2009-07-16 23:53                       ` Paul Brook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090715225150.GU3056@shareable.org \
    --to=jamie@shareable.org \
    --cc=aliguori@us.ibm.com \
    --cc=jan.kiszka@web.de \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=linuxram@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.