All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kiszka <jan.kiszka@web.de>
To: Jamie Lokier <jamie@shareable.org>
Cc: Ram Pai <linuxram@us.ibm.com>, Kevin Wolf <kwolf@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	qemu-devel@nongnu.org, kvm-devel <kvm@vger.kernel.org>
Subject: Re: qcow2 relative paths
Date: Wed, 15 Jul 2009 23:14:32 +0200	[thread overview]
Message-ID: <4A5E46B8.8040901@web.de> (raw)
In-Reply-To: <20090715210459.GJ3056@shareable.org>

[-- Attachment #1: Type: text/plain, Size: 1770 bytes --]

Jamie Lokier wrote:
> Ram Pai wrote:
>> I have successfully verified qcow2 files. But then I may not be trying
>> out the exact thing that you are talking about. Can you give me a test 
>> case that I can verify.
> 
> Commands tried with qemu-0.10.0-1ubuntu1:
> 
> $ mkdir unlikely_subdir
> $ cd unlikely_subdir
> $ qemu-img create -f qcow2 backing.img 10
> Formatting 'backing.img', fmt=qcow2, size=10 kB
> $ qemu-img create -f qcow2 -b ../unlikely_subdir/backing.img main.img 10
> Formatting 'main.img', fmt=qcow2, backing_file=../unlikely_subdir/backing.img, size=10 kB
> $ cd ..
> $ qemu-img info unlikely_subdir/main.img 
> image: unlikely_subdir/main.img
> file format: qcow2
> virtual size: 10K (10240 bytes)
> disk size: 16K
> cluster_size: 4096
> highest_alloc: 16384
> backing file: ../unlikely_subdir/backing.img (actual path: unlikely_subdir/../unlikely_subdir/backing.img)
> 
> See especially the "actual path" line.
> 
> $ mv unlikely_subdir other_subdir
> $ ls -l other_subdir
> total 32
> -rw-r--r-- 1 jamie jamie 16384 2009-07-15 21:59 backing.img
> -rw-r--r-- 1 jamie jamie 16384 2009-07-15 21:59 main.img
> $ qemu-img info other_subdir/main.img 
> qemu-img: Could not open 'other_subdir/main.img'
> 
> What an unhelpful error message...  There isn't even a way to find out
> the backing file path which the tool is looking for.

strace :p

But I feel your pain. This screams for better error reporting.

> 
>> And one other thing. Let me know if there a test-suite that I can try
>> for regressions.
> 
> Sorry, I don't know anything about any QEMU test suites.

There is kvm autotest, but that's testing at a coarser level. Well,
Anthony promised to push some unit test framework for QEMU...

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Jan Kiszka <jan.kiszka@web.de>
To: Jamie Lokier <jamie@shareable.org>
Cc: Kevin Wolf <kwolf@redhat.com>,
	Anthony Liguori <aliguori@us.ibm.com>,
	Ram Pai <linuxram@us.ibm.com>,
	qemu-devel@nongnu.org, kvm-devel <kvm@vger.kernel.org>
Subject: [Qemu-devel] Re: qcow2 relative paths
Date: Wed, 15 Jul 2009 23:14:32 +0200	[thread overview]
Message-ID: <4A5E46B8.8040901@web.de> (raw)
In-Reply-To: <20090715210459.GJ3056@shareable.org>

[-- Attachment #1: Type: text/plain, Size: 1770 bytes --]

Jamie Lokier wrote:
> Ram Pai wrote:
>> I have successfully verified qcow2 files. But then I may not be trying
>> out the exact thing that you are talking about. Can you give me a test 
>> case that I can verify.
> 
> Commands tried with qemu-0.10.0-1ubuntu1:
> 
> $ mkdir unlikely_subdir
> $ cd unlikely_subdir
> $ qemu-img create -f qcow2 backing.img 10
> Formatting 'backing.img', fmt=qcow2, size=10 kB
> $ qemu-img create -f qcow2 -b ../unlikely_subdir/backing.img main.img 10
> Formatting 'main.img', fmt=qcow2, backing_file=../unlikely_subdir/backing.img, size=10 kB
> $ cd ..
> $ qemu-img info unlikely_subdir/main.img 
> image: unlikely_subdir/main.img
> file format: qcow2
> virtual size: 10K (10240 bytes)
> disk size: 16K
> cluster_size: 4096
> highest_alloc: 16384
> backing file: ../unlikely_subdir/backing.img (actual path: unlikely_subdir/../unlikely_subdir/backing.img)
> 
> See especially the "actual path" line.
> 
> $ mv unlikely_subdir other_subdir
> $ ls -l other_subdir
> total 32
> -rw-r--r-- 1 jamie jamie 16384 2009-07-15 21:59 backing.img
> -rw-r--r-- 1 jamie jamie 16384 2009-07-15 21:59 main.img
> $ qemu-img info other_subdir/main.img 
> qemu-img: Could not open 'other_subdir/main.img'
> 
> What an unhelpful error message...  There isn't even a way to find out
> the backing file path which the tool is looking for.

strace :p

But I feel your pain. This screams for better error reporting.

> 
>> And one other thing. Let me know if there a test-suite that I can try
>> for regressions.
> 
> Sorry, I don't know anything about any QEMU test suites.

There is kvm autotest, but that's testing at a coarser level. Well,
Anthony promised to push some unit test framework for QEMU...

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 257 bytes --]

  reply	other threads:[~2009-07-15 21:14 UTC|newest]

Thread overview: 119+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-24 16:58 [PATCH] support colon in filenames Ram Pai
2009-06-24 17:08 ` Balbir Singh
2009-06-24 17:30   ` Ram Pai
2009-06-24 18:31     ` Balbir Singh
2009-06-24 17:26 ` Amit Shah
2009-06-24 17:27   ` Amit Shah
2009-06-24 17:57 ` Ram Pai
2009-06-24 17:57   ` [Qemu-devel] " Ram Pai
2009-06-25  9:14   ` Kevin Wolf
2009-06-25  9:14     ` [Qemu-devel] " Kevin Wolf
2009-06-25 17:52     ` Ram Pai
2009-06-25 17:52       ` [Qemu-devel] " Ram Pai
2009-06-26  6:53       ` Kevin Wolf
2009-06-26  6:53         ` [Qemu-devel] " Kevin Wolf
2009-06-26  6:38     ` rev1 " Ram Pai
2009-06-26  6:38       ` [Qemu-devel] " Ram Pai
2009-06-26  7:45       ` Kevin Wolf
2009-06-26  7:45         ` [Qemu-devel] " Kevin Wolf
2009-06-27  0:41         ` rev2 " Ram Pai
2009-06-27  0:41           ` [Qemu-devel] " Ram Pai
2009-07-02  5:08           ` [PATCH] rev3: " Ram Pai
2009-07-02  5:08             ` [Qemu-devel] " Ram Pai
2009-07-02  8:52             ` Kevin Wolf
2009-07-02 12:52               ` Anthony Liguori
2009-07-02 13:18                 ` Kevin Wolf
2009-07-08  8:30                   ` [PATCH] rev4: " Ram Pai
2009-07-08  8:30                     ` [Qemu-devel] " Ram Pai
2009-07-08 15:05                     ` Jan Kiszka
2009-07-08 15:05                       ` [Qemu-devel] " Jan Kiszka
2009-07-10 13:31                     ` Anthony Liguori
2009-07-10 13:31                       ` [Qemu-devel] " Anthony Liguori
2009-07-15  7:51                     ` [PATCH] rev5: " Ram Pai
2009-07-15  7:51                       ` [Qemu-devel] " Ram Pai
2009-07-15  9:30                       ` Jan Kiszka
2009-07-15  9:30                         ` [Qemu-devel] " Jan Kiszka
2009-07-15 17:03                         ` Ram Pai
2009-07-15 17:03                           ` [Qemu-devel] " Ram Pai
2009-07-15 18:20                           ` Jamie Lokier
2009-07-15 18:20                             ` Jamie Lokier
2009-07-15 18:44                             ` Ram Pai
2009-07-15 18:44                               ` Ram Pai
2009-07-15 21:04                               ` qcow2 relative paths (was: [PATCH] rev5: support colon in filenames) Jamie Lokier
2009-07-15 21:04                                 ` [Qemu-devel] " Jamie Lokier
2009-07-15 21:14                                 ` Jan Kiszka [this message]
2009-07-15 21:14                                   ` [Qemu-devel] Re: qcow2 relative paths Jan Kiszka
2009-07-16  2:28                                 ` qcow2 relative paths (was: [PATCH] rev5: support colon in filenames) Ram Pai
2009-07-16  2:28                                   ` [Qemu-devel] " Ram Pai
2009-07-16  7:38                                   ` qcow2 relative paths Kevin Wolf
2009-07-16  7:38                                     ` [Qemu-devel] " Kevin Wolf
2009-07-16  7:51                                     ` Ram Pai
2009-07-16  7:51                                       ` [Qemu-devel] " Ram Pai
2009-07-16  7:39                                 ` [PATCH] rev6: support colon in filenames Ram Pai
2009-07-16  7:39                                   ` [Qemu-devel] " Ram Pai
2009-07-17 23:17                                   ` [PATCH] rev7: " Ram Pai
2009-07-17 23:17                                     ` [Qemu-devel] " Ram Pai
2009-07-21 12:42                                     ` Kevin Wolf
2009-07-21 12:42                                       ` [Qemu-devel] " Kevin Wolf
2009-08-06  6:27                                       ` Ram Pai
2009-08-06  6:27                                         ` [Qemu-devel] " Ram Pai
2009-08-06  6:47                                         ` [PATCH] rev8: " Ram Pai
2009-08-06  6:47                                           ` [Qemu-devel] " Ram Pai
2009-07-15 15:04                       ` [Qemu-devel] [PATCH] rev5: " Blue Swirl
2009-07-15 15:04                         ` Blue Swirl
2009-07-15 15:14                         ` Anthony Liguori
2009-07-15 15:14                           ` Anthony Liguori
2009-07-15 15:29                           ` Blue Swirl
2009-07-15 15:29                             ` Blue Swirl
2009-07-15 15:40                             ` Anthony Liguori
2009-07-15 15:40                               ` Anthony Liguori
2009-07-15 16:42                               ` Kevin Wolf
2009-07-15 16:42                                 ` Kevin Wolf
2009-07-15 17:47                               ` Michael S. Tsirkin
2009-07-15 17:47                                 ` Michael S. Tsirkin
2009-07-16 10:57                               ` Amit Shah
2009-07-16 10:57                                 ` Amit Shah
2009-07-16 13:43                               ` Markus Armbruster
2009-07-16 13:43                                 ` Markus Armbruster
2009-07-16 14:10                                 ` Anthony Liguori
2009-07-16 14:10                                   ` Anthony Liguori
2009-07-16 15:13                                   ` Gerd Hoffmann
2009-07-16 15:13                                     ` Gerd Hoffmann
2009-07-16 15:12                                 ` Gerd Hoffmann
2009-07-16 15:12                                   ` Gerd Hoffmann
2009-07-15 15:34                           ` Kevin Wolf
2009-07-15 15:34                             ` Kevin Wolf
2009-07-15 15:41                             ` Anthony Liguori
2009-07-15 15:41                               ` Anthony Liguori
2009-07-15 15:52                           ` Paul Brook
2009-07-15 15:52                             ` Paul Brook
2009-07-15 16:03                           ` Gerd Hoffmann
2009-07-15 16:03                             ` Gerd Hoffmann
2009-07-15 16:08                             ` Paul Brook
2009-07-15 16:08                               ` Paul Brook
2009-07-16  7:39                         ` Ram Pai
2009-07-16  7:39                           ` Ram Pai
2009-07-16  7:43                           ` Kevin Wolf
2009-07-16  7:43                             ` Kevin Wolf
2009-07-15 18:14                   ` [Qemu-devel] [PATCH] rev3: " Jamie Lokier
2009-07-15 20:54                     ` Jan Kiszka
2009-07-15 21:36                       ` Jamie Lokier
2009-07-15 21:42                         ` Jan Kiszka
2009-07-15 22:00                           ` Jamie Lokier
2009-07-15 22:16                           ` Anthony Liguori
2009-07-15 22:16                             ` Anthony Liguori
2009-07-15 22:39                             ` Jamie Lokier
2009-07-15 22:39                               ` Jamie Lokier
2009-07-15 22:41                               ` Anthony Liguori
2009-07-15 22:41                                 ` Anthony Liguori
2009-07-15 22:51                                 ` Jamie Lokier
2009-07-15 22:51                                   ` Jamie Lokier
2009-07-16  0:03                                   ` Anthony Liguori
2009-07-16  0:03                                     ` Anthony Liguori
2009-07-16  7:20                                     ` Jan Kiszka
2009-07-16  7:20                                       ` Jan Kiszka
2009-07-16  7:16                             ` Jan Kiszka
2009-07-16  7:16                               ` Jan Kiszka
2009-07-16  8:01                     ` Kevin Wolf
2009-07-16 23:53                     ` Paul Brook
2009-07-16 23:53                       ` Paul Brook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A5E46B8.8040901@web.de \
    --to=jan.kiszka@web.de \
    --cc=aliguori@us.ibm.com \
    --cc=jamie@shareable.org \
    --cc=kvm@vger.kernel.org \
    --cc=kwolf@redhat.com \
    --cc=linuxram@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.