From: Alessandro Rubini <rubini-list@gnudd.com>
To: dbrownell@users.sourceforge.net
Cc: linux-input@vger.kernel.org, linux@arm.linux.org.uk,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [PATCH] ads7846: allocate separate cache lines for tx and rx data
Date: Thu, 16 Jul 2009 10:15:27 +0200 [thread overview]
Message-ID: <20090716081527.GA29374@mail.gnudd.com> (raw)
In-Reply-To: <200907160051.04506.david-b@pacbell.net>
> If you're referring to the way the spi_message and spi_transfer
> structs sit in the same cache lines as the data buffers, that's
> something that should get fixed.
Yes, that's what my patch did. The "strange" part is using a single
malloc instead of three (re-reading your message, the full-duplex
isn't involved here, so I'm not sure tx and rx data can safely be
merged in a cache line).
> It seems that e8f462d202026d8e99f553ed5a09422321226ac9 wasn't a
> complete fix ... this explains why the touchscreen behaves but
> not the ADC inputs (as you noted).
Yes, basically I did the same split of data from control.
> Note that this issue is unrelated to full duplex DMA support.
Yes, that's right. But full duplex is not involved here, it's
just 2 or 3 rounds of "one byte tx then two bytes rx".
/alessandro
next prev parent reply other threads:[~2009-07-16 8:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-15 9:33 [PATCH] ads7846: allocate separate cache lines for tx and rx data Alessandro Rubini
2009-07-15 18:06 ` David Brownell
2009-07-15 19:33 ` Alessandro Rubini
2009-07-16 7:15 ` Russell King - ARM Linux
2009-07-16 7:22 ` Russell King - ARM Linux
2009-07-16 7:56 ` David Brownell
2009-07-16 7:28 ` David Brownell
2009-07-16 10:00 ` Marek Vasut
2009-07-16 15:35 ` David Brownell
2009-07-16 20:06 ` Russell King - ARM Linux
2009-07-16 7:51 ` David Brownell
2009-07-16 8:15 ` Alessandro Rubini [this message]
2009-07-16 8:35 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090716081527.GA29374@mail.gnudd.com \
--to=rubini-list@gnudd.com \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-input@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.