Commit 9b57896e removed my Vaio S1 S2 keys for brightness +/-.

Commit 9b57896e removed my Vaio S1 S2 keys for brightness +/-.

[Robin Holt]

Matthew,

I am not sure whether this is a bug or just something not configured
correctly.  I am running Ubuntu 9.04 and finally decided to find out why
the S1 and S2 buttons no longer brighten or dim the display.  Prior to
commit 9b57896e, they behaved equivalent to the Fn-F5 and Fn-F6 keys
for brightness up/down.

I am willing to help isolate this further.  What can I provide?

Thanks,
Robin

Re: Commit 9b57896e removed my Vaio S1 S2 keys for brightness +/-.

[Matthew Garrett]

On Sun, Jul 19, 2009 at 05:22:36PM -0500, Robin Holt wrote:
> Matthew,
> 
> I am not sure whether this is a bug or just something not configured
> correctly.  I am running Ubuntu 9.04 and finally decided to find out why
> the S1 and S2 buttons no longer brighten or dim the display.  Prior to
> commit 9b57896e, they behaved equivalent to the Fn-F5 and Fn-F6 keys
> for brightness up/down.

I suspect that they're now working correctly, whereas previously they 
weren't. Do they generate input events when you press them? You can 
probably map them back to KEY_BRIGHTNESSUP and KEY_BRIGHTNESSODNW.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

Re: Commit 9b57896e removed my Vaio S1 S2 keys for brightness +/-.

[Robin Holt]

On Sun, Jul 19, 2009 at 11:26:05PM +0100, Matthew Garrett wrote:
> On Sun, Jul 19, 2009 at 05:22:36PM -0500, Robin Holt wrote:
> > Matthew,
> > 
> > I am not sure whether this is a bug or just something not configured
> > correctly.  I am running Ubuntu 9.04 and finally decided to find out why
> > the S1 and S2 buttons no longer brighten or dim the display.  Prior to
> > commit 9b57896e, they behaved equivalent to the Fn-F5 and Fn-F6 keys
> > for brightness up/down.
> 
> I suspect that they're now working correctly, whereas previously they 
> weren't. Do they generate input events when you press them? You can 
> probably map them back to KEY_BRIGHTNESSUP and KEY_BRIGHTNESSODNW.

You are correct.  They now seem to generate XF86Launch1 and XF86Launch2.

Thanks,
Robin

Re: Commit 9b57896e removed my Vaio S1 S2 keys for brightness +/-.

[Matthew Garrett]

On Sun, Jul 19, 2009 at 06:02:12PM -0500, Robin Holt wrote:
> On Sun, Jul 19, 2009 at 11:26:05PM +0100, Matthew Garrett wrote:
> > On Sun, Jul 19, 2009 at 05:22:36PM -0500, Robin Holt wrote:
> > > Matthew,
> > > 
> > > I am not sure whether this is a bug or just something not configured
> > > correctly.  I am running Ubuntu 9.04 and finally decided to find out why
> > > the S1 and S2 buttons no longer brighten or dim the display.  Prior to
> > > commit 9b57896e, they behaved equivalent to the Fn-F5 and Fn-F6 keys
> > > for brightness up/down.
> > 
> > I suspect that they're now working correctly, whereas previously they 
> > weren't. Do they generate input events when you press them? You can 
> > probably map them back to KEY_BRIGHTNESSUP and KEY_BRIGHTNESSODNW.
> 
> You are correct.  They now seem to generate XF86Launch1 and XF86Launch2.

That's what I'd expect. Previously we were decoding some of the hotkeys 
incorrectly, resulting in the wrong codes being sent.

-- 
Matthew Garrett | mjg59@srcf.ucam.org