[U-Boot] [PATCH] ppc4xx: Fix EEPROM configuration on Kilauea

[Stefan Roese <sr@denx.de>]

On Wednesday 22 July 2009 09:27:45 Wolfgang Denk wrote:
> > -#define CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS	6	/* 24C02 requires 5ms
> > delay */ #define CONFIG_SYS_I2C_EEPROM_ADDR	0x52	/* I2C boot EEPROM
> > (24C02BN)	*/ #define CONFIG_SYS_I2C_EEPROM_ADDR_LEN	1	/* Bytes of
> > address		*/ +#define CONFIG_SYS_EEPROM_PAGE_WRITE_BITS	3
> > +#define CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS	10
>
> The commit message does not mention the increased write delay. Is htis
> really needed? The (removed) comment says 5ms should be sufficient?

10ms is also used on many other AMCC eval boards. It's more defensive. But you 
are correct. I should have mentioned it in the commit message. I'll add it and 
resubmit.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================