[U-Boot] [PATCH] ppc4xx: Fix EEPROM configuration on Kilauea

[U-Boot] [PATCH] ppc4xx: Fix EEPROM configuration on Kilauea

[Stefan Roese]

Kilauea has an AT24C02 EEPROM which has an 8 byte page. Without defining
CONFIG_SYS_EEPROM_PAGE_WRITE_BITS to 3 the "eeprom" command doesn't
work correctly.

Signed-off-by: Stefan Roese <sr@denx.de>
---
 include/configs/kilauea.h |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)

diff --git a/include/configs/kilauea.h b/include/configs/kilauea.h
index df1b061..1e7e731 100644
--- a/include/configs/kilauea.h
+++ b/include/configs/kilauea.h
@@ -374,9 +374,10 @@
  *----------------------------------------------------------------------*/
 #define CONFIG_SYS_I2C_SPEED		400000	/* I2C speed and slave address	*/
 
-#define CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS	6	/* 24C02 requires 5ms delay */
 #define CONFIG_SYS_I2C_EEPROM_ADDR	0x52	/* I2C boot EEPROM (24C02BN)	*/
 #define CONFIG_SYS_I2C_EEPROM_ADDR_LEN	1	/* Bytes of address		*/
+#define CONFIG_SYS_EEPROM_PAGE_WRITE_BITS	3
+#define CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS	10
 
 /* Standard DTT sensor configuration */
 #define CONFIG_DTT_DS1775	1
-- 
1.6.3.3

[U-Boot] [PATCH] ppc4xx: Fix EEPROM configuration on Kilauea

[Wolfgang Denk]

Dear Stefan Roese,

In message <1248182100-15318-1-git-send-email-sr@denx.de> you wrote:
> Kilauea has an AT24C02 EEPROM which has an 8 byte page. Without defining
> CONFIG_SYS_EEPROM_PAGE_WRITE_BITS to 3 the "eeprom" command doesn't
> work correctly.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
>  include/configs/kilauea.h |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/include/configs/kilauea.h b/include/configs/kilauea.h
> index df1b061..1e7e731 100644
> --- a/include/configs/kilauea.h
> +++ b/include/configs/kilauea.h
> @@ -374,9 +374,10 @@
>   *----------------------------------------------------------------------*/
>  #define CONFIG_SYS_I2C_SPEED		400000	/* I2C speed and slave address	*/
>  
> -#define CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS	6	/* 24C02 requires 5ms delay */
>  #define CONFIG_SYS_I2C_EEPROM_ADDR	0x52	/* I2C boot EEPROM (24C02BN)	*/
>  #define CONFIG_SYS_I2C_EEPROM_ADDR_LEN	1	/* Bytes of address		*/
> +#define CONFIG_SYS_EEPROM_PAGE_WRITE_BITS	3
> +#define CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS	10

The commit message does not mention the increased write delay. Is htis
really needed? The (removed) comment says 5ms should be sufficient?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If A equals success, then the formula is A = X + Y + Z. X is work.  Y
is play. Z is keep your mouth shut.                 - Albert Einstein

[U-Boot] [PATCH] ppc4xx: Fix EEPROM configuration on Kilauea

[Stefan Roese]

On Wednesday 22 July 2009 09:27:45 Wolfgang Denk wrote:
> > -#define CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS	6	/* 24C02 requires 5ms
> > delay */ #define CONFIG_SYS_I2C_EEPROM_ADDR	0x52	/* I2C boot EEPROM
> > (24C02BN)	*/ #define CONFIG_SYS_I2C_EEPROM_ADDR_LEN	1	/* Bytes of
> > address		*/ +#define CONFIG_SYS_EEPROM_PAGE_WRITE_BITS	3
> > +#define CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS	10
>
> The commit message does not mention the increased write delay. Is htis
> really needed? The (removed) comment says 5ms should be sufficient?

10ms is also used on many other AMCC eval boards. It's more defensive. But you 
are correct. I should have mentioned it in the commit message. I'll add it and 
resubmit.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================

[U-Boot] [PATCH] ppc4xx: Fix EEPROM configuration on Kilauea

[Wolfgang Denk]

Dear Stefan Roese,

In message <200907220944.50403.sr@denx.de> you wrote:
> >
> > The commit message does not mention the increased write delay. Is htis
> > really needed? The (removed) comment says 5ms should be sufficient?
> 
> 10ms is also used on many other AMCC eval boards. It's more defensive. But you 
> are correct. I should have mentioned it in the commit message. I'll add it and 
> resubmit.

Is there any reason for being so defensive here?

In any case I think you should add a comment, explaining your reasons.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I'm frequently appalled by the low regard you Earthmen have for life.
	-- Spock, "The Galileo Seven", stardate 2822.3