From: Alex Chiang <achiang@hp.com>
To: Jesse Barnes <jesse.barnes@intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
kernelnewbies@nl.linux.org
Subject: Re: [PATCH] Shut off pci_find_device warnings when the deprecated
Date: Wed, 29 Jul 2009 00:16:13 +0000 [thread overview]
Message-ID: <20090729001613.GA19369@ldl.fc.hp.com> (raw)
In-Reply-To: <20090728095552.72c41525@jbarnes-g45>
* Jesse Barnes <jesse.barnes@intel.com>:
> On Fri, 24 Jul 2009 11:41:15 +0200
> Andi Kleen <andi@firstfloor.org> wrote:
>
> > Shut off pci_find_device warnings when the deprecated pci functions
> > are enabled.
> >
> > Shut off the long standing
> >
> > linux/drivers/pci/search.c:144: warning: 'pci_find_device' is
> > deprecated (declared at linux/drivers/pci/search.c:136)
> > linux/drivers/pci/search.c:144: warning: 'pci_find_device' is
> > deprecated (declared at linux/drivers/pci/search.c:136)
> >
> > warnings that appear on every build when CONFIG_PCI_LEGACY is enabled.
> >
> > gcc warns for the use in EXPORT_SYMBOL
> >
> > I moved these to a separate file and disabled the warning in the
> > Makefile for that file.
> >
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
>
> Applied to linux-next, thanks.
Maybe it's too late now, but I thought those warnings were
supposed to motivate people to convert old, buggy drivers to get
off the deprecated interface.
That's what finally motivated me to get rid of pci_find_slot()
earlier...
By the way, this would also be a perfect kernelnewbies/kernel
janitor cleanup, as it would require actually digging into
drivers and making real, substantial changes as opposed to
whitespace/checkpatch/typo patches.
Just a thought.
/ac
WARNING: multiple messages have this Message-ID (diff)
From: Alex Chiang <achiang@hp.com>
To: Jesse Barnes <jesse.barnes@intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
kernelnewbies@nl.linux.org
Subject: Re: [PATCH] Shut off pci_find_device warnings when the deprecated pci functions are enabled.
Date: Tue, 28 Jul 2009 18:16:13 -0600 [thread overview]
Message-ID: <20090729001613.GA19369@ldl.fc.hp.com> (raw)
In-Reply-To: <20090728095552.72c41525@jbarnes-g45>
* Jesse Barnes <jesse.barnes@intel.com>:
> On Fri, 24 Jul 2009 11:41:15 +0200
> Andi Kleen <andi@firstfloor.org> wrote:
>
> > Shut off pci_find_device warnings when the deprecated pci functions
> > are enabled.
> >
> > Shut off the long standing
> >
> > linux/drivers/pci/search.c:144: warning: 'pci_find_device' is
> > deprecated (declared at linux/drivers/pci/search.c:136)
> > linux/drivers/pci/search.c:144: warning: 'pci_find_device' is
> > deprecated (declared at linux/drivers/pci/search.c:136)
> >
> > warnings that appear on every build when CONFIG_PCI_LEGACY is enabled.
> >
> > gcc warns for the use in EXPORT_SYMBOL
> >
> > I moved these to a separate file and disabled the warning in the
> > Makefile for that file.
> >
> > Signed-off-by: Andi Kleen <ak@linux.intel.com>
>
> Applied to linux-next, thanks.
Maybe it's too late now, but I thought those warnings were
supposed to motivate people to convert old, buggy drivers to get
off the deprecated interface.
That's what finally motivated me to get rid of pci_find_slot()
earlier...
By the way, this would also be a perfect kernelnewbies/kernel
janitor cleanup, as it would require actually digging into
drivers and making real, substantial changes as opposed to
whitespace/checkpatch/typo patches.
Just a thought.
/ac
next prev parent reply other threads:[~2009-07-29 0:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-24 9:41 [PATCH] Shut off pci_find_device warnings when the deprecated pci functions are enabled Andi Kleen
2009-07-28 16:55 ` Jesse Barnes
2009-07-29 0:16 ` Alex Chiang [this message]
2009-07-29 0:16 ` Alex Chiang
2009-07-29 0:28 ` [PATCH] Shut off pci_find_device warnings when the deprecated Andi Kleen
2009-07-29 0:28 ` [PATCH] Shut off pci_find_device warnings when the deprecated pci functions are enabled Andi Kleen
2009-07-29 0:32 ` [PATCH] Shut off pci_find_device warnings when the deprecated Alex Chiang
2009-07-29 0:32 ` [PATCH] Shut off pci_find_device warnings when the deprecated pci functions are enabled Alex Chiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090729001613.GA19369@ldl.fc.hp.com \
--to=achiang@hp.com \
--cc=andi@firstfloor.org \
--cc=jesse.barnes@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernelnewbies@nl.linux.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.