All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alex Chiang <achiang@hp.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Jesse Barnes <jesse.barnes@intel.com>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	kernelnewbies@nl.linux.org
Subject: Re: [PATCH] Shut off pci_find_device warnings when the deprecated
Date: Wed, 29 Jul 2009 00:32:08 +0000	[thread overview]
Message-ID: <20090729003208.GB3539@ldl.fc.hp.com> (raw)
In-Reply-To: <20090729002801.GR15310@basil.fritz.box>

* Andi Kleen <andi@firstfloor.org>:
> > Maybe it's too late now, but I thought those warnings were
> > supposed to motivate people to convert old, buggy drivers to get
> > off the deprecated interface.
> 
> Yes they are, but this warning instance was not for a old driver,
> but for the EXPORT_SYMBOL defining the legacy function.
> 
> If any driver uses it it'll still warn.

Ok, I've been corrected. :)

I still think it would be a good learning project for someone to
audit the tree and see if they can eliminate the usages of
pci_find_device().

Thanks,

/ac


WARNING: multiple messages have this Message-ID (diff)
From: Alex Chiang <achiang@hp.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Jesse Barnes <jesse.barnes@intel.com>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	kernelnewbies@nl.linux.org
Subject: Re: [PATCH] Shut off pci_find_device warnings when the deprecated pci functions are enabled.
Date: Tue, 28 Jul 2009 18:32:08 -0600	[thread overview]
Message-ID: <20090729003208.GB3539@ldl.fc.hp.com> (raw)
In-Reply-To: <20090729002801.GR15310@basil.fritz.box>

* Andi Kleen <andi@firstfloor.org>:
> > Maybe it's too late now, but I thought those warnings were
> > supposed to motivate people to convert old, buggy drivers to get
> > off the deprecated interface.
> 
> Yes they are, but this warning instance was not for a old driver,
> but for the EXPORT_SYMBOL defining the legacy function.
> 
> If any driver uses it it'll still warn.

Ok, I've been corrected. :)

I still think it would be a good learning project for someone to
audit the tree and see if they can eliminate the usages of
pci_find_device().

Thanks,

/ac


  reply	other threads:[~2009-07-29  0:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-24  9:41 [PATCH] Shut off pci_find_device warnings when the deprecated pci functions are enabled Andi Kleen
2009-07-28 16:55 ` Jesse Barnes
2009-07-29  0:16   ` [PATCH] Shut off pci_find_device warnings when the deprecated Alex Chiang
2009-07-29  0:16     ` [PATCH] Shut off pci_find_device warnings when the deprecated pci functions are enabled Alex Chiang
2009-07-29  0:28     ` [PATCH] Shut off pci_find_device warnings when the deprecated Andi Kleen
2009-07-29  0:28       ` [PATCH] Shut off pci_find_device warnings when the deprecated pci functions are enabled Andi Kleen
2009-07-29  0:32       ` Alex Chiang [this message]
2009-07-29  0:32         ` Alex Chiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090729003208.GB3539@ldl.fc.hp.com \
    --to=achiang@hp.com \
    --cc=andi@firstfloor.org \
    --cc=jesse.barnes@intel.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=kernelnewbies@nl.linux.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.