[PATCH 2/2] Alias cls as clear

[PATCH 2/2] Alias cls as clear

[Joe Auricchio]

* commands/minicmd.c: Add clear as alias for cls.

My background is in Unix, so 'clear' comes much more naturally to my
fingers than 'cls'. But it's bad to clutter grub with too many commands.
So I leave this to the maintainers: do we add both commands, only one,  
or
neither?

-joe


--- a/commands/minicmd.c	2009-07-22 15:43:30.000000000 -0700
+++ b/commands/minicmd.c	2009-07-22 15:43:16.000000000 -0700
@@ -348,7 +348,7 @@

static grub_command_t cmd_cat, cmd_help, cmd_root;
static grub_command_t cmd_dump, cmd_rmmod, cmd_lsmod, cmd_exit;
-static grub_command_t cmd_cls;
+static grub_command_t cmd_cls, cmd_clear;

GRUB_MOD_INIT(minicmd)
{
@@ -376,6 +376,9 @@
   cmd_cls =
     grub_register_command ("cls", grub_mini_cmd_cls,
			   0, "clear the screen");
+  cmd_clear =
+    grub_register_command ("clear", grub_mini_cmd_cls,
+			   0, "clear the screen");
}

GRUB_MOD_FINI(minicmd)
@@ -388,4 +391,5 @@
   grub_unregister_command (cmd_lsmod);
   grub_unregister_command (cmd_exit);
   grub_unregister_command (cmd_cls);
+  grub_unregister_command (cmd_clear);
}

Re: [PATCH 2/2] Alias cls as clear

[Pavel Roskin]

On Wed, 2009-07-22 at 22:08 -0700, Joe Auricchio wrote:
> * commands/minicmd.c: Add clear as alias for cls.
> 
> My background is in Unix, so 'clear' comes much more naturally to my
> fingers than 'cls'. But it's bad to clutter grub with too many commands.
> So I leave this to the maintainers: do we add both commands, only one,  
> or
> neither?

Let's have "clear" only, as it's more clear :-)

Please include the ChangeLog entry.

-- 
Regards,
Pavel Roskin

Re: [PATCH 2/2] Alias cls as clear

[Joe Auricchio]

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]


On 23 Jul, 2009, at 15:42 , Pavel Roskin wrote:
> On Wed, 2009-07-22 at 22:08 -0700, Joe Auricchio wrote:
>> * commands/minicmd.c: Add clear as alias for cls.
>>
>> My background is in Unix, so 'clear' comes much more naturally to my
>> fingers than 'cls'. But it's bad to clutter grub with too many  
>> commands.
>> So I leave this to the maintainers: do we add both commands, only  
>> one,
>> or
>> neither?
>
> Let's have "clear" only, as it's more clear :-)
>
> Please include the ChangeLog entry.


How's this?

-joe


[-- Attachment #2: add_clear_command.patch --]
[-- Type: application/octet-stream, Size: 1550 bytes --]

Index: grub2/commands/minicmd.c
===================================================================
--- grub2.orig/commands/minicmd.c	2009-07-23 16:02:58.000000000 -0700
+++ grub2/commands/minicmd.c	2009-07-23 16:03:28.000000000 -0700
@@ -336,8 +336,19 @@
   return 0;
 }
 
+/* clear */
+static grub_err_t
+grub_mini_cmd_clear (struct grub_command *cmd __attribute__ ((unused)),
+		   int argc __attribute__ ((unused)),
+		   char *argv[] __attribute__ ((unused)))
+{
+  grub_cls ();
+  return 0;
+}
+
 static grub_command_t cmd_cat, cmd_help, cmd_root;
 static grub_command_t cmd_dump, cmd_rmmod, cmd_lsmod, cmd_exit;
+static grub_command_t cmd_clear;
 
 GRUB_MOD_INIT(minicmd)
 {
@@ -362,6 +373,9 @@
   cmd_exit =
     grub_register_command ("exit", grub_mini_cmd_exit,
 			   0, "exit from GRUB");
+  cmd_clear =
+    grub_register_command ("clear", grub_mini_cmd_clear,
+			   0, "clear the screen");
 }
 
 GRUB_MOD_FINI(minicmd)
@@ -373,4 +387,5 @@
   grub_unregister_command (cmd_rmmod);
   grub_unregister_command (cmd_lsmod);
   grub_unregister_command (cmd_exit);
+  grub_unregister_command (cmd_clear);
 }
Index: grub2/ChangeLog
===================================================================
--- grub2.orig/ChangeLog	2009-07-23 16:02:58.000000000 -0700
+++ grub2/ChangeLog	2009-07-23 16:03:17.000000000 -0700
@@ -1,3 +1,7 @@
+2009-07-23  Joe Auricchio <jauricchio@gmail.com>
+
+	* commands/minicmd.c: Add clear command.
+
 2009-07-23  Pavel Roskin  <proski@gnu.org>
 
 	* include/grub/misc.h (ALIGN_UP): Cast align to the type of addr

Re: [PATCH 2/2] Alias cls as clear

[Robert Millan]

On Thu, Jul 23, 2009 at 04:05:00PM -0700, Joe Auricchio wrote:
>
> On 23 Jul, 2009, at 15:42 , Pavel Roskin wrote:
>> On Wed, 2009-07-22 at 22:08 -0700, Joe Auricchio wrote:
>>> * commands/minicmd.c: Add clear as alias for cls.
>>>
>>> My background is in Unix, so 'clear' comes much more naturally to my
>>> fingers than 'cls'. But it's bad to clutter grub with too many  
>>> commands.
>>> So I leave this to the maintainers: do we add both commands, only  
>>> one,
>>> or
>>> neither?
>>
>> Let's have "clear" only, as it's more clear :-)
>>
>> Please include the ChangeLog entry.
>
>
> How's this?

The ChangeLog entry is incomplete.  It should be e.g.:

	* commands/minicmd.c (grub_mini_cmd_clear): New function.

etc.  See other entries as an example.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

Re: [PATCH 2/2] Alias cls as clear

[Joe Auricchio]

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]


On 25 Jul, 2009, at 09:21 , Robert Millan wrote:
> On Thu, Jul 23, 2009 at 04:05:00PM -0700, Joe Auricchio wrote:
>>
>>
>> How's this?
>
> The ChangeLog entry is incomplete.  It should be e.g.:
>
> 	* commands/minicmd.c (grub_mini_cmd_clear): New function.
>
> etc.  See other entries as an example.

Updated patch attached.


[-- Attachment #2: add_clear_command.patch --]
[-- Type: application/octet-stream, Size: 1567 bytes --]

Index: grub2/commands/minicmd.c
===================================================================
--- grub2.orig/commands/minicmd.c	2009-07-23 16:02:58.000000000 -0700
+++ grub2/commands/minicmd.c	2009-07-23 16:03:28.000000000 -0700
@@ -336,8 +336,19 @@
   return 0;
 }
 
+/* clear */
+static grub_err_t
+grub_mini_cmd_clear (struct grub_command *cmd __attribute__ ((unused)),
+		   int argc __attribute__ ((unused)),
+		   char *argv[] __attribute__ ((unused)))
+{
+  grub_cls ();
+  return 0;
+}
+
 static grub_command_t cmd_cat, cmd_help, cmd_root;
 static grub_command_t cmd_dump, cmd_rmmod, cmd_lsmod, cmd_exit;
+static grub_command_t cmd_clear;
 
 GRUB_MOD_INIT(minicmd)
 {
@@ -362,6 +373,9 @@
   cmd_exit =
     grub_register_command ("exit", grub_mini_cmd_exit,
 			   0, "exit from GRUB");
+  cmd_clear =
+    grub_register_command ("clear", grub_mini_cmd_clear,
+			   0, "clear the screen");
 }
 
 GRUB_MOD_FINI(minicmd)
@@ -373,4 +387,5 @@
   grub_unregister_command (cmd_rmmod);
   grub_unregister_command (cmd_lsmod);
   grub_unregister_command (cmd_exit);
+  grub_unregister_command (cmd_clear);
 }
Index: grub2/ChangeLog
===================================================================
--- grub2.orig/ChangeLog	2009-07-23 16:02:58.000000000 -0700
+++ grub2/ChangeLog	2009-07-23 16:03:17.000000000 -0700
@@ -1,3 +1,7 @@
+2009-07-23  Joe Auricchio <jauricchio@gmail.com>
+
+	* commands/minicmd.c (grub_mini_cmd_clear): New function.
+
 2009-07-23  Pavel Roskin  <proski@gnu.org>
 
 	* include/grub/misc.h (ALIGN_UP): Cast align to the type of addr

[-- Attachment #3: Type: text/plain, Size: 1 bytes --]

Re: [PATCH 2/2] Alias cls as clear

[Robert Millan]

On Tue, Jul 28, 2009 at 10:58:55PM -0700, Joe Auricchio wrote:
>
> On 25 Jul, 2009, at 09:21 , Robert Millan wrote:
>> On Thu, Jul 23, 2009 at 04:05:00PM -0700, Joe Auricchio wrote:
>>>
>>>
>>> How's this?
>>
>> The ChangeLog entry is incomplete.  It should be e.g.:
>>
>> 	* commands/minicmd.c (grub_mini_cmd_clear): New function.
>>
>> etc.  See other entries as an example.
>
> Updated patch attached.

Hi,

The ChangeLog entry is incomplete, it should list the changes in
GRUB_MOD_INIT(minicmd) and GRUB_MOD_FINI(minicmd) too.

Btw, your mailer sends text attachments with Content-Type set to
application/octet-stream.  Please could you adjust it so that it
sets it to the standard text/plain MIME type?  Otherwise mail clients
may fail to recognize it as text, which makes context reply difficult.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

Re: [PATCH 2/2] Alias cls as clear

[Robert Millan]

Committed with some adjustments to ChangeLog.

On Tue, Jul 28, 2009 at 10:58:55PM -0700, Joe Auricchio wrote:
>
> On 25 Jul, 2009, at 09:21 , Robert Millan wrote:
>> On Thu, Jul 23, 2009 at 04:05:00PM -0700, Joe Auricchio wrote:
>>>
>>>
>>> How's this?
>>
>> The ChangeLog entry is incomplete.  It should be e.g.:
>>
>> 	* commands/minicmd.c (grub_mini_cmd_clear): New function.
>>
>> etc.  See other entries as an example.
>
> Updated patch attached.
>


>

> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel


-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."

Re: [PATCH 2/2] Alias cls as clear

[Robert Millan]

On Thu, Jul 23, 2009 at 06:42:11PM -0400, Pavel Roskin wrote:
> On Wed, 2009-07-22 at 22:08 -0700, Joe Auricchio wrote:
> > * commands/minicmd.c: Add clear as alias for cls.
> > 
> > My background is in Unix, so 'clear' comes much more naturally to my
> > fingers than 'cls'. But it's bad to clutter grub with too many commands.
> > So I leave this to the maintainers: do we add both commands, only one,  
> > or
> > neither?
> 
> Let's have "clear" only, as it's more clear :-)

Yes.  And GNU systems are our main target, so consistency with them is
usually preferrable.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."