From: Michael Buesch <mb@bu3sch.de>
To: David Miller <davem@davemloft.net>
Cc: johannes@sipsolutions.net, linuxrocks123@netscape.net,
linux-wireless@vger.kernel.org, dsd@gentoo.org,
kune@deine-taler.de
Subject: Re: [PATCH] Fix SPARC64 unaligned access in zd_mac_rx
Date: Sat, 1 Aug 2009 12:40:16 +0200 [thread overview]
Message-ID: <200908011240.17229.mb@bu3sch.de> (raw)
In-Reply-To: <20090731.222350.254918321.davem@davemloft.net>
On Saturday 01 August 2009 07:23:50 David Miller wrote:
> From: Johannes Berg <johannes@sipsolutions.net>
> Date: Fri, 31 Jul 2009 10:39:43 +0200
>
> > On Fri, 2009-07-31 at 01:59 -0600, Patrick Simmons wrote:
> >> I'm running zd1211rw on SPARC64 and was getting a lot of "unaligned
> >> access" messages in dmesg. I tracked the problem down to this line, and
> >> changing the cast to a memcpy fixes the issue.
> >>
> >> - fc = *(__le16 *)buffer;
> >> + memcpy(&fc,buffer,sizeof(__le16));
> >> need_padding = ieee80211_is_data_qos(fc) ^ ieee80211_has_a4(fc);
> >
> > Please use get_unaligned instead.
>
> And, more specifically, one of the endian get_unaligned variants.
No. fc is supposed to be LE.
--
Greetings, Michael.
next prev parent reply other threads:[~2009-08-01 10:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-31 7:59 [PATCH] Fix SPARC64 unaligned access in zd_mac_rx Patrick Simmons
2009-07-31 8:39 ` Johannes Berg
2009-08-01 5:23 ` David Miller
2009-08-01 10:40 ` Michael Buesch [this message]
2009-08-01 16:12 ` David Miller
2009-08-02 1:41 ` Patrick Simmons
2009-08-02 7:50 ` Johannes Berg
2009-08-02 8:24 ` Patrick Simmons
2009-08-02 8:34 ` Johannes Berg
2009-08-02 8:45 ` Patrick Simmons
2009-08-02 8:46 ` [PATCH] zd1211rw: fix " Patrick Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908011240.17229.mb@bu3sch.de \
--to=mb@bu3sch.de \
--cc=davem@davemloft.net \
--cc=dsd@gentoo.org \
--cc=johannes@sipsolutions.net \
--cc=kune@deine-taler.de \
--cc=linux-wireless@vger.kernel.org \
--cc=linuxrocks123@netscape.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.