Re: [PATCH] Fix SPARC64 unaligned access in zd_mac_rx

[Patrick Simmons <linuxrocks123@netscape.net>]

Johannes Berg wrote:
> On Sun, 2009-08-02 at 02:24 -0600, Patrick Simmons wrote:
>
>   
>> It does look wrong, now that I look at it further, but I'm pretty sure 
>> that what was happening was that only the lower 8 bits of the 
>> dereferenced value were being accessed. 
>>     
>
> Yes, you're right, because buffer is a "u8 *", I initially thought that
> it didn't take a pointer, but that wouldn't work, of course.
>
>   
>>  What's odd is that it works on 
>> my machine, though.  Whatever.  Your version is clearer, in any case.
>>
>> What follows is hopefully the last version of this patch.
>>     
>
> Looks good, but I think you should resubmit with
>  * a changed subject (e.g. "zd1211rw: fix unaligned access in zd_mac_rx")
>  * a standalone patch description so John doesn't have to pick it out of
>    your first patch etc.
>
>
> Thanks!
> johannes
>
>   
Sure thing; here it comes.  Thanks for the review.

--Patrick