All of lore.kernel.org
 help / color / mirror / Atom feed
From: Patrick Simmons <linuxrocks123@netscape.net>
To: linux-wireless@vger.kernel.org
Cc: Daniel Drake <dsd@gentoo.org>, Ulrich Kunitz <kune@deine-taler.de>
Subject: [PATCH] Fix SPARC64 unaligned access in zd_mac_rx
Date: Fri, 31 Jul 2009 01:59:30 -0600	[thread overview]
Message-ID: <4A72A462.6060107@netscape.net> (raw)

I'm running zd1211rw on SPARC64 and was getting a lot of "unaligned 
access" messages in dmesg.  I tracked the problem down to this line, and 
changing the cast to a memcpy fixes the issue.

Please CC me with any comments as I am not subscribed to the list.

Signed-off-by: Patrick Simmons <linuxrocks123@netscape.net>

--- a/drivers/net/wireless/zd1211rw/zd_mac.c    2009-07-30 
23:23:50.000000000 -0600
+++ b/drivers/net/wireless/zd1211rw/zd_mac.c    2009-07-30 
23:58:19.000000000 -0600
@@ -694,7 +694,7 @@
                        && !mac->pass_ctrl)
                return 0;
 
-       fc = *(__le16 *)buffer;
+       memcpy(&fc,buffer,sizeof(__le16));
        need_padding = ieee80211_is_data_qos(fc) ^ ieee80211_has_a4(fc);
 
        skb = dev_alloc_skb(length + (need_padding ? 2 : 0));


             reply	other threads:[~2009-07-31  8:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-07-31  7:59 Patrick Simmons [this message]
2009-07-31  8:39 ` [PATCH] Fix SPARC64 unaligned access in zd_mac_rx Johannes Berg
2009-08-01  5:23   ` David Miller
2009-08-01 10:40     ` Michael Buesch
2009-08-01 16:12       ` David Miller
2009-08-02  1:41         ` Patrick Simmons
2009-08-02  7:50           ` Johannes Berg
2009-08-02  8:24             ` Patrick Simmons
2009-08-02  8:34               ` Johannes Berg
2009-08-02  8:45                 ` Patrick Simmons
2009-08-02  8:46             ` [PATCH] zd1211rw: fix " Patrick Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A72A462.6060107@netscape.net \
    --to=linuxrocks123@netscape.net \
    --cc=dsd@gentoo.org \
    --cc=kune@deine-taler.de \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.