All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [RFC] Don't pass filename in multiboot command line
Date: Sat, 1 Aug 2009 17:05:29 +0200	[thread overview]
Message-ID: <20090801150529.GD23133@thorin> (raw)
In-Reply-To: <d7ead6de0908010737x319a647eodb696abd6f6d56a@mail.gmail.com>

On Sat, Aug 01, 2009 at 04:37:40PM +0200, Vladimir 'phcoder' Serbinenko wrote:
> > I agree with this.  But please wait a few days to give everyone a chance
> > to read it.
> >
> > Regarding the patch:
> >
> > There's a much simpler way to address this.  Just add something like:
> >
> >  cmdline_argv = argv + 1;
> >  cmdline_argc = argc - 1;
> >
> > at the beginning, and then use cmdline_argv and cmdline_argc instead of
> > correcting the off-by-one every time.
> Correcting the numbers is actually smaller part of the patch. The most
> of it is to make empty commandlines to be handled correctly (this
> couldn't happen previously)

Either there's an extra argv member that is always present and we want
to remove, or there's the possibility that the command-line is empty.
AFAICS we can't have both problems.

argv[0] corresponds to the filename, right?  In that case, it's not possible
to run multiboot without argv[0] (or at least, we shouldn't allow it).  Then
we can remove it unconditionally.

-- 
Robert Millan

  The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
  how) you may access your data; but nobody's threatening your freedom: we
  still allow you to remove your data and not access it at all."



  reply	other threads:[~2009-08-01 15:05 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-01 13:23 [RFC] Don't pass filename in multiboot command line Vladimir 'phcoder' Serbinenko
2009-08-01 14:34 ` Robert Millan
2009-08-01 14:37   ` Vladimir 'phcoder' Serbinenko
2009-08-01 15:05     ` Robert Millan [this message]
2009-08-01 15:13       ` Vladimir 'phcoder' Serbinenko
2009-08-02 21:38         ` Robert Millan
2009-08-02 21:42           ` Vladimir 'phcoder' Serbinenko
2009-08-02 22:41             ` Robert Millan
2009-08-14 15:20               ` Vladimir 'phcoder' Serbinenko
2009-08-27  1:58                 ` Seth Goldberg
2009-08-27  2:38                   ` Seth Goldberg
2009-08-27 10:55                     ` Michal Suchanek
2009-08-28 12:51                       ` Robert Millan
2009-11-24 11:21                 ` Thomas Schwinge
2009-11-24 11:34                   ` Robert Millan
2009-11-24 11:48                     ` Robert Millan
2009-11-24 13:02                       ` Samuel Thibault

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090801150529.GD23133@thorin \
    --to=rmh@aybabtu.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.