From: Bob Copeland <me@bobcopeland.com>
To: Julia Lawall <julia@diku.dk>
Cc: "Luis R. Rodriguez" <lrodriguez@atheros.com>,
Nick Kossifidis <mickflemm@gmail.com>,
Jiri Slaby <jirislaby@gmail.com>,
ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH] drivers/net/wireless/ath/ath5k: Change constant name
Date: Sat, 08 Aug 2009 16:20:01 +0000 [thread overview]
Message-ID: <20090808162001.GA18271@hash.localnet> (raw)
In-Reply-To: <Pine.LNX.4.64.0908081521210.27715@ask.diku.dk>
On Sat, Aug 08, 2009 at 03:22:26PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Elsewhere, the tqi_type field is compared to constants having a name
> beginning with AR5K_TX_QUEUE, rather than AR5K_TX_QUEUE_ID. I have thus
> converted AR5K_TX_QUEUE_ID_CAB to AR5K_TX_QUEUE_CAB. This does, however,
> change the value, so perhaps something else was wanted.
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Nice catch, thanks. Shouldn't cause any problem with 2.6.31 since we
don't use the CAB queue yet, but it was definitely wrong.
Acked-by: Bob Copeland <me@bobcopeland.com>
> diff --git a/drivers/net/wireless/ath/ath5k/qcu.c b/drivers/net/wireless/ath/ath5k/qcu.c
> index 6d5aaf0..eeebb9a 100644
> --- a/drivers/net/wireless/ath/ath5k/qcu.c
> +++ b/drivers/net/wireless/ath/ath5k/qcu.c
> @@ -362,7 +362,7 @@ int ath5k_hw_reset_tx_queue(struct ath5k_hw *ah, unsigned int queue)
> }
>
> if (tq->tqi_ready_time &&
> - (tq->tqi_type != AR5K_TX_QUEUE_ID_CAB))
> + (tq->tqi_type != AR5K_TX_QUEUE_CAB))
> ath5k_hw_reg_write(ah, AR5K_REG_SM(tq->tqi_ready_time,
> AR5K_QCU_RDYTIMECFG_INTVAL) |
> AR5K_QCU_RDYTIMECFG_ENABLE,
>
--
Bob Copeland %% www.bobcopeland.com
WARNING: multiple messages have this Message-ID (diff)
From: Bob Copeland <me@bobcopeland.com>
To: Julia Lawall <julia@diku.dk>
Cc: "Luis R. Rodriguez" <lrodriguez@atheros.com>,
Nick Kossifidis <mickflemm@gmail.com>,
Jiri Slaby <jirislaby@gmail.com>,
ath5k-devel@lists.ath5k.org, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH] drivers/net/wireless/ath/ath5k: Change constant name
Date: Sat, 8 Aug 2009 12:20:01 -0400 [thread overview]
Message-ID: <20090808162001.GA18271@hash.localnet> (raw)
In-Reply-To: <Pine.LNX.4.64.0908081521210.27715@ask.diku.dk>
On Sat, Aug 08, 2009 at 03:22:26PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Elsewhere, the tqi_type field is compared to constants having a name
> beginning with AR5K_TX_QUEUE, rather than AR5K_TX_QUEUE_ID. I have thus
> converted AR5K_TX_QUEUE_ID_CAB to AR5K_TX_QUEUE_CAB. This does, however,
> change the value, so perhaps something else was wanted.
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Nice catch, thanks. Shouldn't cause any problem with 2.6.31 since we
don't use the CAB queue yet, but it was definitely wrong.
Acked-by: Bob Copeland <me@bobcopeland.com>
> diff --git a/drivers/net/wireless/ath/ath5k/qcu.c b/drivers/net/wireless/ath/ath5k/qcu.c
> index 6d5aaf0..eeebb9a 100644
> --- a/drivers/net/wireless/ath/ath5k/qcu.c
> +++ b/drivers/net/wireless/ath/ath5k/qcu.c
> @@ -362,7 +362,7 @@ int ath5k_hw_reset_tx_queue(struct ath5k_hw *ah, unsigned int queue)
> }
>
> if (tq->tqi_ready_time &&
> - (tq->tqi_type != AR5K_TX_QUEUE_ID_CAB))
> + (tq->tqi_type != AR5K_TX_QUEUE_CAB))
> ath5k_hw_reg_write(ah, AR5K_REG_SM(tq->tqi_ready_time,
> AR5K_QCU_RDYTIMECFG_INTVAL) |
> AR5K_QCU_RDYTIMECFG_ENABLE,
>
--
Bob Copeland %% www.bobcopeland.com
WARNING: multiple messages have this Message-ID (diff)
From: Bob Copeland <me@bobcopeland.com>
To: Julia Lawall <julia@diku.dk>
Cc: "Luis R. Rodriguez" <lrodriguez@atheros.com>,
Nick Kossifidis <mickflemm@gmail.com>,
Jiri Slaby <jirislaby@gmail.com>,
ath5k-devel@venema.h4ckr.net, linux-wireless@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, linville@tuxdriver.com
Subject: Re: [PATCH] drivers/net/wireless/ath/ath5k: Change constant name
Date: Sat, 8 Aug 2009 12:20:01 -0400 [thread overview]
Message-ID: <20090808162001.GA18271@hash.localnet> (raw)
In-Reply-To: <Pine.LNX.4.64.0908081521210.27715@ask.diku.dk>
On Sat, Aug 08, 2009 at 03:22:26PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Elsewhere, the tqi_type field is compared to constants having a name
> beginning with AR5K_TX_QUEUE, rather than AR5K_TX_QUEUE_ID. I have thus
> converted AR5K_TX_QUEUE_ID_CAB to AR5K_TX_QUEUE_CAB. This does, however,
> change the value, so perhaps something else was wanted.
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Nice catch, thanks. Shouldn't cause any problem with 2.6.31 since we
don't use the CAB queue yet, but it was definitely wrong.
Acked-by: Bob Copeland <me@bobcopeland.com>
> diff --git a/drivers/net/wireless/ath/ath5k/qcu.c b/drivers/net/wireless/ath/ath5k/qcu.c
> index 6d5aaf0..eeebb9a 100644
> --- a/drivers/net/wireless/ath/ath5k/qcu.c
> +++ b/drivers/net/wireless/ath/ath5k/qcu.c
> @@ -362,7 +362,7 @@ int ath5k_hw_reset_tx_queue(struct ath5k_hw *ah, unsigned int queue)
> }
>
> if (tq->tqi_ready_time &&
> - (tq->tqi_type != AR5K_TX_QUEUE_ID_CAB))
> + (tq->tqi_type != AR5K_TX_QUEUE_CAB))
> ath5k_hw_reg_write(ah, AR5K_REG_SM(tq->tqi_ready_time,
> AR5K_QCU_RDYTIMECFG_INTVAL) |
> AR5K_QCU_RDYTIMECFG_ENABLE,
>
--
Bob Copeland %% www.bobcopeland.com
WARNING: multiple messages have this Message-ID (diff)
From: Bob Copeland <me-aXfl/3sk2vNUbtYUoyoikg@public.gmane.org>
To: Julia Lawall <julia-dAYI7NvHqcQ@public.gmane.org>
Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jiri Slaby <jirislaby-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
ath5k-devel-xDcbHBWguxEUs3QNXV6qNA@public.gmane.org,
linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linville-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org
Subject: Re: [PATCH] drivers/net/wireless/ath/ath5k: Change constant name
Date: Sat, 8 Aug 2009 12:20:01 -0400 [thread overview]
Message-ID: <20090808162001.GA18271@hash.localnet> (raw)
In-Reply-To: <Pine.LNX.4.64.0908081521210.27715-QfmoRoYWmW9knbxzx/v8hQ@public.gmane.org>
On Sat, Aug 08, 2009 at 03:22:26PM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia-dAYI7NvHqcQ@public.gmane.org>
>
> Elsewhere, the tqi_type field is compared to constants having a name
> beginning with AR5K_TX_QUEUE, rather than AR5K_TX_QUEUE_ID. I have thus
> converted AR5K_TX_QUEUE_ID_CAB to AR5K_TX_QUEUE_CAB. This does, however,
> change the value, so perhaps something else was wanted.
>
> Signed-off-by: Julia Lawall <julia-dAYI7NvHqcQ@public.gmane.org>
Nice catch, thanks. Shouldn't cause any problem with 2.6.31 since we
don't use the CAB queue yet, but it was definitely wrong.
Acked-by: Bob Copeland <me-aXfl/3sk2vNUbtYUoyoikg@public.gmane.org>
> diff --git a/drivers/net/wireless/ath/ath5k/qcu.c b/drivers/net/wireless/ath/ath5k/qcu.c
> index 6d5aaf0..eeebb9a 100644
> --- a/drivers/net/wireless/ath/ath5k/qcu.c
> +++ b/drivers/net/wireless/ath/ath5k/qcu.c
> @@ -362,7 +362,7 @@ int ath5k_hw_reset_tx_queue(struct ath5k_hw *ah, unsigned int queue)
> }
>
> if (tq->tqi_ready_time &&
> - (tq->tqi_type != AR5K_TX_QUEUE_ID_CAB))
> + (tq->tqi_type != AR5K_TX_QUEUE_CAB))
> ath5k_hw_reg_write(ah, AR5K_REG_SM(tq->tqi_ready_time,
> AR5K_QCU_RDYTIMECFG_INTVAL) |
> AR5K_QCU_RDYTIMECFG_ENABLE,
>
--
Bob Copeland %% www.bobcopeland.com
next prev parent reply other threads:[~2009-08-08 16:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-08 13:22 [PATCH] drivers/net/wireless/ath/ath5k: Change constant name Julia Lawall
2009-08-08 13:22 ` Julia Lawall
2009-08-08 13:22 ` Julia Lawall
2009-08-08 16:20 ` Bob Copeland [this message]
2009-08-08 16:20 ` Bob Copeland
2009-08-08 16:20 ` Bob Copeland
2009-08-08 16:20 ` Bob Copeland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090808162001.GA18271@hash.localnet \
--to=me@bobcopeland.com \
--cc=ath5k-devel@lists.ath5k.org \
--cc=jirislaby@gmail.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=lrodriguez@atheros.com \
--cc=mickflemm@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.