* [PATCH] drivers/net/wireless/ath/ath5k: Change constant name @ 2009-08-08 13:22 ` Julia Lawall 0 siblings, 0 replies; 7+ messages in thread From: Julia Lawall @ 2009-08-08 13:22 UTC (permalink / raw) To: Bob Copeland, Luis R. Rodriguez, Nick Kossifidis, Jiri Slaby, ath5k-devel, linux-wireless, netdev, linux-kernel, kernel-janitors From: Julia Lawall <julia@diku.dk> Elsewhere, the tqi_type field is compared to constants having a name beginning with AR5K_TX_QUEUE, rather than AR5K_TX_QUEUE_ID. I have thus converted AR5K_TX_QUEUE_ID_CAB to AR5K_TX_QUEUE_CAB. This does, however, change the value, so perhaps something else was wanted. Signed-off-by: Julia Lawall <julia@diku.dk> --- drivers/net/wireless/ath/ath5k/qcu.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/qcu.c b/drivers/net/wireless/ath/ath5k/qcu.c index 6d5aaf0..eeebb9a 100644 --- a/drivers/net/wireless/ath/ath5k/qcu.c +++ b/drivers/net/wireless/ath/ath5k/qcu.c @@ -362,7 +362,7 @@ int ath5k_hw_reset_tx_queue(struct ath5k_hw *ah, unsigned int queue) } if (tq->tqi_ready_time && - (tq->tqi_type != AR5K_TX_QUEUE_ID_CAB)) + (tq->tqi_type != AR5K_TX_QUEUE_CAB)) ath5k_hw_reg_write(ah, AR5K_REG_SM(tq->tqi_ready_time, AR5K_QCU_RDYTIMECFG_INTVAL) | AR5K_QCU_RDYTIMECFG_ENABLE, ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] drivers/net/wireless/ath/ath5k: Change constant name @ 2009-08-08 13:22 ` Julia Lawall 0 siblings, 0 replies; 7+ messages in thread From: Julia Lawall @ 2009-08-08 13:22 UTC (permalink / raw) To: Bob Copeland, Luis R. Rodriguez, Nick Kossifidis, Jiri Slaby, ath5k-devel, linux-wireless, netdev, linux-kernel, kernel-janitors From: Julia Lawall <julia@diku.dk> Elsewhere, the tqi_type field is compared to constants having a name beginning with AR5K_TX_QUEUE, rather than AR5K_TX_QUEUE_ID. I have thus converted AR5K_TX_QUEUE_ID_CAB to AR5K_TX_QUEUE_CAB. This does, however, change the value, so perhaps something else was wanted. Signed-off-by: Julia Lawall <julia@diku.dk> --- drivers/net/wireless/ath/ath5k/qcu.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/qcu.c b/drivers/net/wireless/ath/ath5k/qcu.c index 6d5aaf0..eeebb9a 100644 --- a/drivers/net/wireless/ath/ath5k/qcu.c +++ b/drivers/net/wireless/ath/ath5k/qcu.c @@ -362,7 +362,7 @@ int ath5k_hw_reset_tx_queue(struct ath5k_hw *ah, unsigned int queue) } if (tq->tqi_ready_time && - (tq->tqi_type != AR5K_TX_QUEUE_ID_CAB)) + (tq->tqi_type != AR5K_TX_QUEUE_CAB)) ath5k_hw_reg_write(ah, AR5K_REG_SM(tq->tqi_ready_time, AR5K_QCU_RDYTIMECFG_INTVAL) | AR5K_QCU_RDYTIMECFG_ENABLE, ^ permalink raw reply related [flat|nested] 7+ messages in thread
* [PATCH] drivers/net/wireless/ath/ath5k: Change constant name @ 2009-08-08 13:22 ` Julia Lawall 0 siblings, 0 replies; 7+ messages in thread From: Julia Lawall @ 2009-08-08 13:22 UTC (permalink / raw) To: Bob Copeland, Luis R. Rodriguez, Nick Kossifidis, Jiri Slaby, ath5k-devel, linux-wireless, netdev, linux-kernel, kernel-janitors From: Julia Lawall <julia@diku.dk> Elsewhere, the tqi_type field is compared to constants having a name beginning with AR5K_TX_QUEUE, rather than AR5K_TX_QUEUE_ID. I have thus converted AR5K_TX_QUEUE_ID_CAB to AR5K_TX_QUEUE_CAB. This does, however, change the value, so perhaps something else was wanted. Signed-off-by: Julia Lawall <julia@diku.dk> --- drivers/net/wireless/ath/ath5k/qcu.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/net/wireless/ath/ath5k/qcu.c b/drivers/net/wireless/ath/ath5k/qcu.c index 6d5aaf0..eeebb9a 100644 --- a/drivers/net/wireless/ath/ath5k/qcu.c +++ b/drivers/net/wireless/ath/ath5k/qcu.c @@ -362,7 +362,7 @@ int ath5k_hw_reset_tx_queue(struct ath5k_hw *ah, unsigned int queue) } if (tq->tqi_ready_time && - (tq->tqi_type != AR5K_TX_QUEUE_ID_CAB)) + (tq->tqi_type != AR5K_TX_QUEUE_CAB)) ath5k_hw_reg_write(ah, AR5K_REG_SM(tq->tqi_ready_time, AR5K_QCU_RDYTIMECFG_INTVAL) | AR5K_QCU_RDYTIMECFG_ENABLE, ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers/net/wireless/ath/ath5k: Change constant name 2009-08-08 13:22 ` Julia Lawall (?) (?) @ 2009-08-08 16:20 ` Bob Copeland -1 siblings, 0 replies; 7+ messages in thread From: Bob Copeland @ 2009-08-08 16:20 UTC (permalink / raw) To: Julia Lawall Cc: Luis R. Rodriguez, Nick Kossifidis, Jiri Slaby, ath5k-devel, linux-wireless, netdev, linux-kernel, kernel-janitors, linville On Sat, Aug 08, 2009 at 03:22:26PM +0200, Julia Lawall wrote: > From: Julia Lawall <julia@diku.dk> > > Elsewhere, the tqi_type field is compared to constants having a name > beginning with AR5K_TX_QUEUE, rather than AR5K_TX_QUEUE_ID. I have thus > converted AR5K_TX_QUEUE_ID_CAB to AR5K_TX_QUEUE_CAB. This does, however, > change the value, so perhaps something else was wanted. > > Signed-off-by: Julia Lawall <julia@diku.dk> Nice catch, thanks. Shouldn't cause any problem with 2.6.31 since we don't use the CAB queue yet, but it was definitely wrong. Acked-by: Bob Copeland <me@bobcopeland.com> > diff --git a/drivers/net/wireless/ath/ath5k/qcu.c b/drivers/net/wireless/ath/ath5k/qcu.c > index 6d5aaf0..eeebb9a 100644 > --- a/drivers/net/wireless/ath/ath5k/qcu.c > +++ b/drivers/net/wireless/ath/ath5k/qcu.c > @@ -362,7 +362,7 @@ int ath5k_hw_reset_tx_queue(struct ath5k_hw *ah, unsigned int queue) > } > > if (tq->tqi_ready_time && > - (tq->tqi_type != AR5K_TX_QUEUE_ID_CAB)) > + (tq->tqi_type != AR5K_TX_QUEUE_CAB)) > ath5k_hw_reg_write(ah, AR5K_REG_SM(tq->tqi_ready_time, > AR5K_QCU_RDYTIMECFG_INTVAL) | > AR5K_QCU_RDYTIMECFG_ENABLE, > -- Bob Copeland %% www.bobcopeland.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers/net/wireless/ath/ath5k: Change constant name @ 2009-08-08 16:20 ` Bob Copeland 0 siblings, 0 replies; 7+ messages in thread From: Bob Copeland @ 2009-08-08 16:20 UTC (permalink / raw) To: Julia Lawall Cc: kernel-janitors-u79uwXL29TY76Z2rM5mHXA, Jiri Slaby, netdev-u79uwXL29TY76Z2rM5mHXA, ath5k-devel-xDcbHBWguxEUs3QNXV6qNA, linux-wireless-u79uwXL29TY76Z2rM5mHXA, linux-kernel-u79uwXL29TY76Z2rM5mHXA, linville-2XuSBdqkA4R54TAoqtyWWQ On Sat, Aug 08, 2009 at 03:22:26PM +0200, Julia Lawall wrote: > From: Julia Lawall <julia-dAYI7NvHqcQ@public.gmane.org> > > Elsewhere, the tqi_type field is compared to constants having a name > beginning with AR5K_TX_QUEUE, rather than AR5K_TX_QUEUE_ID. I have thus > converted AR5K_TX_QUEUE_ID_CAB to AR5K_TX_QUEUE_CAB. This does, however, > change the value, so perhaps something else was wanted. > > Signed-off-by: Julia Lawall <julia-dAYI7NvHqcQ@public.gmane.org> Nice catch, thanks. Shouldn't cause any problem with 2.6.31 since we don't use the CAB queue yet, but it was definitely wrong. Acked-by: Bob Copeland <me-aXfl/3sk2vNUbtYUoyoikg@public.gmane.org> > diff --git a/drivers/net/wireless/ath/ath5k/qcu.c b/drivers/net/wireless/ath/ath5k/qcu.c > index 6d5aaf0..eeebb9a 100644 > --- a/drivers/net/wireless/ath/ath5k/qcu.c > +++ b/drivers/net/wireless/ath/ath5k/qcu.c > @@ -362,7 +362,7 @@ int ath5k_hw_reset_tx_queue(struct ath5k_hw *ah, unsigned int queue) > } > > if (tq->tqi_ready_time && > - (tq->tqi_type != AR5K_TX_QUEUE_ID_CAB)) > + (tq->tqi_type != AR5K_TX_QUEUE_CAB)) > ath5k_hw_reg_write(ah, AR5K_REG_SM(tq->tqi_ready_time, > AR5K_QCU_RDYTIMECFG_INTVAL) | > AR5K_QCU_RDYTIMECFG_ENABLE, > -- Bob Copeland %% www.bobcopeland.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers/net/wireless/ath/ath5k: Change constant name @ 2009-08-08 16:20 ` Bob Copeland 0 siblings, 0 replies; 7+ messages in thread From: Bob Copeland @ 2009-08-08 16:20 UTC (permalink / raw) To: Julia Lawall Cc: Luis R. Rodriguez, Nick Kossifidis, Jiri Slaby, ath5k-devel, linux-wireless, netdev, linux-kernel, kernel-janitors, linville On Sat, Aug 08, 2009 at 03:22:26PM +0200, Julia Lawall wrote: > From: Julia Lawall <julia@diku.dk> > > Elsewhere, the tqi_type field is compared to constants having a name > beginning with AR5K_TX_QUEUE, rather than AR5K_TX_QUEUE_ID. I have thus > converted AR5K_TX_QUEUE_ID_CAB to AR5K_TX_QUEUE_CAB. This does, however, > change the value, so perhaps something else was wanted. > > Signed-off-by: Julia Lawall <julia@diku.dk> Nice catch, thanks. Shouldn't cause any problem with 2.6.31 since we don't use the CAB queue yet, but it was definitely wrong. Acked-by: Bob Copeland <me@bobcopeland.com> > diff --git a/drivers/net/wireless/ath/ath5k/qcu.c b/drivers/net/wireless/ath/ath5k/qcu.c > index 6d5aaf0..eeebb9a 100644 > --- a/drivers/net/wireless/ath/ath5k/qcu.c > +++ b/drivers/net/wireless/ath/ath5k/qcu.c > @@ -362,7 +362,7 @@ int ath5k_hw_reset_tx_queue(struct ath5k_hw *ah, unsigned int queue) > } > > if (tq->tqi_ready_time && > - (tq->tqi_type != AR5K_TX_QUEUE_ID_CAB)) > + (tq->tqi_type != AR5K_TX_QUEUE_CAB)) > ath5k_hw_reg_write(ah, AR5K_REG_SM(tq->tqi_ready_time, > AR5K_QCU_RDYTIMECFG_INTVAL) | > AR5K_QCU_RDYTIMECFG_ENABLE, > -- Bob Copeland %% www.bobcopeland.com ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] drivers/net/wireless/ath/ath5k: Change constant name @ 2009-08-08 16:20 ` Bob Copeland 0 siblings, 0 replies; 7+ messages in thread From: Bob Copeland @ 2009-08-08 16:20 UTC (permalink / raw) To: Julia Lawall Cc: Luis R. Rodriguez, Nick Kossifidis, Jiri Slaby, ath5k-devel, linux-wireless, netdev, linux-kernel, kernel-janitors, linville On Sat, Aug 08, 2009 at 03:22:26PM +0200, Julia Lawall wrote: > From: Julia Lawall <julia@diku.dk> > > Elsewhere, the tqi_type field is compared to constants having a name > beginning with AR5K_TX_QUEUE, rather than AR5K_TX_QUEUE_ID. I have thus > converted AR5K_TX_QUEUE_ID_CAB to AR5K_TX_QUEUE_CAB. This does, however, > change the value, so perhaps something else was wanted. > > Signed-off-by: Julia Lawall <julia@diku.dk> Nice catch, thanks. Shouldn't cause any problem with 2.6.31 since we don't use the CAB queue yet, but it was definitely wrong. Acked-by: Bob Copeland <me@bobcopeland.com> > diff --git a/drivers/net/wireless/ath/ath5k/qcu.c b/drivers/net/wireless/ath/ath5k/qcu.c > index 6d5aaf0..eeebb9a 100644 > --- a/drivers/net/wireless/ath/ath5k/qcu.c > +++ b/drivers/net/wireless/ath/ath5k/qcu.c > @@ -362,7 +362,7 @@ int ath5k_hw_reset_tx_queue(struct ath5k_hw *ah, unsigned int queue) > } > > if (tq->tqi_ready_time && > - (tq->tqi_type != AR5K_TX_QUEUE_ID_CAB)) > + (tq->tqi_type != AR5K_TX_QUEUE_CAB)) > ath5k_hw_reg_write(ah, AR5K_REG_SM(tq->tqi_ready_time, > AR5K_QCU_RDYTIMECFG_INTVAL) | > AR5K_QCU_RDYTIMECFG_ENABLE, > -- Bob Copeland %% www.bobcopeland.com ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-08-08 16:21 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2009-08-08 13:22 [PATCH] drivers/net/wireless/ath/ath5k: Change constant name Julia Lawall 2009-08-08 13:22 ` Julia Lawall 2009-08-08 13:22 ` Julia Lawall 2009-08-08 16:20 ` Bob Copeland 2009-08-08 16:20 ` Bob Copeland 2009-08-08 16:20 ` Bob Copeland 2009-08-08 16:20 ` Bob Copeland
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.