From: Stephen Hemminger <shemminger@linux-foundation.org>
To: "Fischer, Anna" <anna.fischer@hp.com>
Cc: "Paul Congdon (UC Davis)" <ptcongdon@ucdavis.edu>,
"evb@yahoogroups.com" <evb@yahoogroups.com>,
Arnd Bergmann <arnd@arndb.de>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"bridge@lists.linux-foundation.org"
<bridge@lists.linux-foundation.org>,
"adobriyan@gmail.com" <adobriyan@gmail.com>,
Or Gerlitz <ogerlitz@voltaire.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [Bridge] [evb] RE: [PATCH][RFC] net/bridge: add basic VEPA support
Date: Mon, 10 Aug 2009 09:51:18 -0700 [thread overview]
Message-ID: <20090810095118.125fe966@nehalam> (raw)
In-Reply-To: <0199E0D51A61344794750DC57738F58E6D6AE99884@GVW1118EXC.americas.hpqcorp.net>
On Mon, 10 Aug 2009 16:32:01 +0000
"Fischer, Anna" <anna.fischer@hp.com> wrote:
> > Subject: Re: [evb] RE: [PATCH][RFC] net/bridge: add basic VEPA support
> >
> > On Monday 10 August 2009, Stephen Hemminger wrote:
> > > On Sun, 09 Aug 2009 14:19:08 +0300, Or Gerlitz
> > <ogerlitz@voltaire.com> wrote:
> > > > Looking in macvlan_set_multicast_list() it acts in a similar manner
> > to
> > > > macvlan_set_mac_address() in the sense that it calls dev_mc_sync().
> > I
> > > > assume what's left is to add macvlan_hash_xxx multicast logic to
> > > > map/unmap multicast groups to what macvlan devices want to receive
> > them
> > > > and this way the flooding can be removed, correct?
> > >
> > > The device can just flood all multicast packets, since the filtering
> > > is done on the receive path anyway.
>
> Is this handled by one of the additional patches? In the current kernel tree
> macvlan code it looks as if multicast filtering is only handled by the
> physical device driver, but not on particular macvlan devices.
>
>
> > But we'd still have to copy the frames to user space (for both
> > macvtap and raw packet sockets) and exit from the guest to inject
> > it into its stack, right?
>
> I think it would be nice if you can implement what Or describes for
> macvlan and avoid flooding, and it doesn't sound too hard to do.
>
> I guess one advantage for macvlan (over the bridge) is that you can
> program in all information you have for the ports attached to it, e.g.
> MAC addresses and multicast addresses. So you could take advantage of
> that whereas the bridge always floods multicast frames to all ports.
>
> How would this work though, if the OS inside the guest wants to register
> to a particular multicast address? Is this propagated through the backend
> drivers to the macvlan/macvtap interface?
Sure filtering is better, but multicast performance with large number
of guests is really a corner case, not the real performance issue.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <shemminger@linux-foundation.org>
To: "Fischer, Anna" <anna.fischer@hp.com>
Cc: Arnd Bergmann <arnd@arndb.de>, Or Gerlitz <ogerlitz@voltaire.com>,
"Paul Congdon (UC Davis)" <ptcongdon@ucdavis.edu>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"bridge@lists.linux-foundation.org"
<bridge@lists.linux-foundation.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"adobriyan@gmail.com" <adobriyan@gmail.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>,
"evb@yahoogroups.com" <evb@yahoogroups.com>
Subject: Re: [evb] RE: [PATCH][RFC] net/bridge: add basic VEPA support
Date: Mon, 10 Aug 2009 09:51:18 -0700 [thread overview]
Message-ID: <20090810095118.125fe966@nehalam> (raw)
In-Reply-To: <0199E0D51A61344794750DC57738F58E6D6AE99884@GVW1118EXC.americas.hpqcorp.net>
On Mon, 10 Aug 2009 16:32:01 +0000
"Fischer, Anna" <anna.fischer@hp.com> wrote:
> > Subject: Re: [evb] RE: [PATCH][RFC] net/bridge: add basic VEPA support
> >
> > On Monday 10 August 2009, Stephen Hemminger wrote:
> > > On Sun, 09 Aug 2009 14:19:08 +0300, Or Gerlitz
> > <ogerlitz@voltaire.com> wrote:
> > > > Looking in macvlan_set_multicast_list() it acts in a similar manner
> > to
> > > > macvlan_set_mac_address() in the sense that it calls dev_mc_sync().
> > I
> > > > assume what's left is to add macvlan_hash_xxx multicast logic to
> > > > map/unmap multicast groups to what macvlan devices want to receive
> > them
> > > > and this way the flooding can be removed, correct?
> > >
> > > The device can just flood all multicast packets, since the filtering
> > > is done on the receive path anyway.
>
> Is this handled by one of the additional patches? In the current kernel tree
> macvlan code it looks as if multicast filtering is only handled by the
> physical device driver, but not on particular macvlan devices.
>
>
> > But we'd still have to copy the frames to user space (for both
> > macvtap and raw packet sockets) and exit from the guest to inject
> > it into its stack, right?
>
> I think it would be nice if you can implement what Or describes for
> macvlan and avoid flooding, and it doesn't sound too hard to do.
>
> I guess one advantage for macvlan (over the bridge) is that you can
> program in all information you have for the ports attached to it, e.g.
> MAC addresses and multicast addresses. So you could take advantage of
> that whereas the bridge always floods multicast frames to all ports.
>
> How would this work though, if the OS inside the guest wants to register
> to a particular multicast address? Is this propagated through the backend
> drivers to the macvlan/macvtap interface?
Sure filtering is better, but multicast performance with large number
of guests is really a corner case, not the real performance issue.
next prev parent reply other threads:[~2009-08-10 16:51 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-07 20:35 [Bridge] [evb] RE: [PATCH][RFC] net/bridge: add basic VEPA support Yaron Haviv
2009-08-07 20:35 ` Yaron Haviv
2009-08-07 20:35 ` Yaron Haviv
2009-08-07 21:00 ` [Bridge] " Fischer, Anna
2009-08-07 21:00 ` Fischer, Anna
2009-08-08 9:22 ` Arnd Bergmann
2009-08-08 9:22 ` [Bridge] " Arnd Bergmann
2009-08-08 9:22 ` Arnd Bergmann
2009-08-07 21:00 ` Fischer, Anna
2009-08-07 21:06 ` [Bridge] " Paul Congdon (UC Davis)
2009-08-07 21:06 ` Paul Congdon (UC Davis)
2009-08-07 21:36 ` Stephen Hemminger
2009-08-07 21:36 ` [Bridge] " Stephen Hemminger
2009-08-07 21:36 ` Stephen Hemminger
2009-08-09 11:19 ` Or Gerlitz
2009-08-09 11:19 ` [Bridge] " Or Gerlitz
2009-08-09 11:19 ` Or Gerlitz
2009-08-10 15:20 ` [Bridge] " Stephen Hemminger
2009-08-10 15:20 ` Stephen Hemminger
2009-08-10 15:28 ` Arnd Bergmann
2009-08-10 15:28 ` [Bridge] " Arnd Bergmann
2009-08-10 15:28 ` Arnd Bergmann
2009-08-10 16:32 ` [Bridge] " Fischer, Anna
2009-08-10 16:32 ` Fischer, Anna
2009-08-10 16:51 ` Stephen Hemminger
2009-08-10 16:51 ` Stephen Hemminger [this message]
2009-08-10 16:51 ` Stephen Hemminger
2009-08-10 19:18 ` [Bridge] " Arnd Bergmann
2009-08-10 19:18 ` Arnd Bergmann
2009-08-10 19:18 ` Arnd Bergmann
2009-08-10 16:32 ` Fischer, Anna
2009-08-27 12:35 ` [Bridge] " Or Gerlitz
2009-08-27 12:35 ` Or Gerlitz
2009-08-27 12:35 ` Or Gerlitz
2009-08-10 15:20 ` Stephen Hemminger
2009-08-07 21:06 ` Paul Congdon (UC Davis)
[not found] ` <0199E0D51A61344794750DC57738F58E6D6A6CD803__29862.6656564467$1249679159$gmane$org@GVW1118EXC.americas.hpqcorp.net>
2009-08-08 8:50 ` Benny Amorsen
2009-08-08 8:50 ` [Bridge] " Benny Amorsen
2009-08-08 8:50 ` Benny Amorsen
2009-08-08 9:44 ` Arnd Bergmann
2009-08-08 9:44 ` [Bridge] " Arnd Bergmann
2009-08-08 9:44 ` Arnd Bergmann
-- strict thread matches above, loose matches on Subject: below --
2009-06-15 17:33 [Bridge] " Fischer, Anna
2009-08-07 4:00 ` Stephen Hemminger
2009-08-07 11:29 ` Arnd Bergmann
2009-08-07 19:44 ` [Bridge] [evb] " Paul Congdon (UC Davis)
2009-08-10 15:23 ` Arnd Bergmann
2009-08-10 15:59 ` Fischer, Anna
2009-08-10 16:16 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090810095118.125fe966@nehalam \
--to=shemminger@linux-foundation.org \
--cc=adobriyan@gmail.com \
--cc=anna.fischer@hp.com \
--cc=arnd@arndb.de \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=evb@yahoogroups.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@voltaire.com \
--cc=ptcongdon@ucdavis.edu \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.