All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Vegard Nossum <vegard.nossum@gmail.com>,
	Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-mm@kvack.org, Christoph Lameter <cl@linux-foundation.org>,
	David Rientjes <rientjes@google.com>,
	Matt Mackall <mpm@selenic.com>,
	Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [Patch] proc: drop write permission on 'timer_list' and 'slabinfo'
Date: Mon, 17 Aug 2009 11:48:22 +0200	[thread overview]
Message-ID: <20090817094822.GA17838@elte.hu> (raw)
In-Reply-To: <20090817094525.6355.88682.sendpatchset@localhost.localdomain>


* Amerigo Wang <amwang@redhat.com> wrote:

> /proc/timer_list and /proc/slabinfo are not supposed to be 
> written, so there should be no write permissions on it.

good catch!

> --- a/kernel/time/timer_list.c
> +++ b/kernel/time/timer_list.c

I have applied the timer_list bits to the timer tree. The SLUB/SLAB 
bits should go into the SLAB tree i guess.

Thanks,

	Ingo

WARNING: multiple messages have this Message-ID (diff)
From: Ingo Molnar <mingo@elte.hu>
To: Amerigo Wang <amwang@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Vegard Nossum <vegard.nossum@gmail.com>,
	Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-mm@kvack.org, Christoph Lameter <cl@linux-foundation.org>,
	David Rientjes <rientjes@google.com>,
	Matt Mackall <mpm@selenic.com>,
	Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [Patch] proc: drop write permission on 'timer_list' and 'slabinfo'
Date: Mon, 17 Aug 2009 11:48:22 +0200	[thread overview]
Message-ID: <20090817094822.GA17838@elte.hu> (raw)
In-Reply-To: <20090817094525.6355.88682.sendpatchset@localhost.localdomain>


* Amerigo Wang <amwang@redhat.com> wrote:

> /proc/timer_list and /proc/slabinfo are not supposed to be 
> written, so there should be no write permissions on it.

good catch!

> --- a/kernel/time/timer_list.c
> +++ b/kernel/time/timer_list.c

I have applied the timer_list bits to the timer tree. The SLUB/SLAB 
bits should go into the SLAB tree i guess.

Thanks,

	Ingo

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-08-17  9:49 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-17  9:43 [Patch] proc: drop write permission on 'timer_list' and 'slabinfo' Amerigo Wang
2009-08-17  9:43 ` Amerigo Wang
2009-08-17  9:48 ` Ingo Molnar [this message]
2009-08-17  9:48   ` Ingo Molnar
2009-08-17  9:54   ` Pekka Enberg
2009-08-17  9:54     ` Pekka Enberg
2009-08-17 16:29     ` Christoph Lameter
2009-08-17 16:29       ` Christoph Lameter
2009-08-17 16:35       ` Pekka Enberg
2009-08-17 16:35         ` Pekka Enberg
2009-08-17 16:41         ` Christoph Lameter
2009-08-17 16:41           ` Christoph Lameter
2009-08-18  1:59           ` Amerigo Wang
2009-08-18  1:59             ` Li Zefan
2009-08-18  1:59               ` Li Zefan
2009-08-18  3:08               ` Amerigo Wang
2009-08-18 12:00                 ` Wu Fengguang
2009-08-18 12:00                   ` Wu Fengguang
2009-08-19  2:36                   ` Amerigo Wang
2009-08-19  2:36                     ` Amerigo Wang
2009-08-19  2:37                     ` Wu Fengguang
2009-08-19  2:37                       ` Wu Fengguang
2009-08-19 10:39                       ` Amerigo Wang
2009-08-19 18:47                         ` Pekka Enberg
2009-08-19 18:47                           ` Pekka Enberg
2009-08-20 10:34                           ` Amerigo Wang
2009-08-20 10:34                             ` Amerigo Wang
2009-08-18 16:12               ` Pekka Enberg
2009-08-18 16:12                 ` Pekka Enberg
2009-08-17  9:51 ` [tip:timers/urgent] timers: Drop write permission on /proc/timer_list tip-bot for Amerigo Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090817094822.GA17838@elte.hu \
    --to=mingo@elte.hu \
    --cc=amwang@redhat.com \
    --cc=arjan@linux.intel.com \
    --cc=cl@linux-foundation.org \
    --cc=eduard.munteanu@linux360.ro \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mpm@selenic.com \
    --cc=penberg@cs.helsinki.fi \
    --cc=rientjes@google.com \
    --cc=tglx@linutronix.de \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.