All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amerigo Wang <amwang@redhat.com>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
	Christoph Lameter <cl@linux-foundation.org>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	Vegard Nossum <vegard.nossum@gmail.com>,
	Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
	Matt Mackall <mpm@selenic.com>,
	Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [Patch] proc: drop write permission on 'timer_list' and	'slabinfo'
Date: Wed, 19 Aug 2009 10:36:30 +0800	[thread overview]
Message-ID: <4A8B652E.40905@redhat.com> (raw)
In-Reply-To: <20090818120032.GA22152@localhost>

Wu Fengguang wrote:
> On Tue, Aug 18, 2009 at 11:08:30AM +0800, Amerigo Wang wrote:
>
>   
>> -	proc_create("slabinfo",S_IWUSR|S_IRUGO,NULL,&proc_slabinfo_operations);
>> +	proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations);
>>     
>
> Style nitpick. The spaces were packed to fit into 80-col I guess.
>
>   

Yeah, I noticed this too, the reason I didn't fix this is that I don't 
want to mix coding style fix with this one. We can fix it in another 
patch, if you want. :)

Thanks.


WARNING: multiple messages have this Message-ID (diff)
From: Amerigo Wang <amwang@redhat.com>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Li Zefan <lizf@cn.fujitsu.com>,
	Christoph Lameter <cl@linux-foundation.org>,
	Pekka Enberg <penberg@cs.helsinki.fi>,
	Ingo Molnar <mingo@elte.hu>,
	linux-kernel@vger.kernel.org,
	Vegard Nossum <vegard.nossum@gmail.com>,
	Eduard - Gabriel Munteanu <eduard.munteanu@linux360.ro>,
	Thomas Gleixner <tglx@linutronix.de>,
	linux-mm@kvack.org, David Rientjes <rientjes@google.com>,
	Matt Mackall <mpm@selenic.com>,
	Arjan van de Ven <arjan@linux.intel.com>
Subject: Re: [Patch] proc: drop write permission on 'timer_list' and	'slabinfo'
Date: Wed, 19 Aug 2009 10:36:30 +0800	[thread overview]
Message-ID: <4A8B652E.40905@redhat.com> (raw)
In-Reply-To: <20090818120032.GA22152@localhost>

Wu Fengguang wrote:
> On Tue, Aug 18, 2009 at 11:08:30AM +0800, Amerigo Wang wrote:
>
>   
>> -	proc_create("slabinfo",S_IWUSR|S_IRUGO,NULL,&proc_slabinfo_operations);
>> +	proc_create("slabinfo",S_IRUGO,NULL,&proc_slabinfo_operations);
>>     
>
> Style nitpick. The spaces were packed to fit into 80-col I guess.
>
>   

Yeah, I noticed this too, the reason I didn't fix this is that I don't 
want to mix coding style fix with this one. We can fix it in another 
patch, if you want. :)

Thanks.

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-08-19  2:35 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-17  9:43 [Patch] proc: drop write permission on 'timer_list' and 'slabinfo' Amerigo Wang
2009-08-17  9:43 ` Amerigo Wang
2009-08-17  9:48 ` Ingo Molnar
2009-08-17  9:48   ` Ingo Molnar
2009-08-17  9:54   ` Pekka Enberg
2009-08-17  9:54     ` Pekka Enberg
2009-08-17 16:29     ` Christoph Lameter
2009-08-17 16:29       ` Christoph Lameter
2009-08-17 16:35       ` Pekka Enberg
2009-08-17 16:35         ` Pekka Enberg
2009-08-17 16:41         ` Christoph Lameter
2009-08-17 16:41           ` Christoph Lameter
2009-08-18  1:59           ` Amerigo Wang
2009-08-18  1:59             ` Li Zefan
2009-08-18  1:59               ` Li Zefan
2009-08-18  3:08               ` Amerigo Wang
2009-08-18 12:00                 ` Wu Fengguang
2009-08-18 12:00                   ` Wu Fengguang
2009-08-19  2:36                   ` Amerigo Wang [this message]
2009-08-19  2:36                     ` Amerigo Wang
2009-08-19  2:37                     ` Wu Fengguang
2009-08-19  2:37                       ` Wu Fengguang
2009-08-19 10:39                       ` Amerigo Wang
2009-08-19 18:47                         ` Pekka Enberg
2009-08-19 18:47                           ` Pekka Enberg
2009-08-20 10:34                           ` Amerigo Wang
2009-08-20 10:34                             ` Amerigo Wang
2009-08-18 16:12               ` Pekka Enberg
2009-08-18 16:12                 ` Pekka Enberg
2009-08-17  9:51 ` [tip:timers/urgent] timers: Drop write permission on /proc/timer_list tip-bot for Amerigo Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A8B652E.40905@redhat.com \
    --to=amwang@redhat.com \
    --cc=arjan@linux.intel.com \
    --cc=cl@linux-foundation.org \
    --cc=eduard.munteanu@linux360.ro \
    --cc=fengguang.wu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=mingo@elte.hu \
    --cc=mpm@selenic.com \
    --cc=penberg@cs.helsinki.fi \
    --cc=rientjes@google.com \
    --cc=tglx@linutronix.de \
    --cc=vegard.nossum@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.