All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Kuninori Morimoto <morimoto.kuninori@renesas.com>,
	alsa-devel@alsa-project.org, lethal@linux-sh.org,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/3] Add SuperH FSI driver support for ALSA
Date: Wed, 19 Aug 2009 13:42:07 +0100	[thread overview]
Message-ID: <20090819124206.GA20838@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <s5hvdkkasgl.wl%tiwai@suse.de>

On Wed, Aug 19, 2009 at 02:39:06PM +0200, Takashi Iwai wrote:

> Note that it's snd_pcm_lib_malloc_pages(), not the kernel's standard
> one like alloc_pages().  The former frees the old buffer by itself
> when resized, so you don't need to call snd_pcm_lib_free_pages()
> (as long as it's called in hw_free callback).

Oh, so it does - I misread the code as only shrinking an existing
buffer.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Kuninori Morimoto <morimoto.kuninori@renesas.com>,
	alsa-devel@alsa-project.org, lethal@linux-sh.org,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-sh@vger.kernel.org
Subject: Re: [PATCH 1/3] Add SuperH FSI driver support for ALSA
Date: Wed, 19 Aug 2009 12:42:07 +0000	[thread overview]
Message-ID: <20090819124206.GA20838@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <s5hvdkkasgl.wl%tiwai@suse.de>

On Wed, Aug 19, 2009 at 02:39:06PM +0200, Takashi Iwai wrote:

> Note that it's snd_pcm_lib_malloc_pages(), not the kernel's standard
> one like alloc_pages().  The former frees the old buffer by itself
> when resized, so you don't need to call snd_pcm_lib_free_pages()
> (as long as it's called in hw_free callback).

Oh, so it does - I misread the code as only shrinking an existing
buffer.

  reply	other threads:[~2009-08-19 12:42 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-19 11:25 [PATCH 1/3] Add SuperH FSI driver support for ALSA Kuninori Morimoto
2009-08-19 11:25 ` Kuninori Morimoto
2009-08-19 12:28 ` Mark Brown
2009-08-19 12:28   ` Mark Brown
2009-08-19 12:39   ` Takashi Iwai
2009-08-19 12:39     ` Takashi Iwai
2009-08-19 12:42     ` Mark Brown [this message]
2009-08-19 12:42       ` Mark Brown
2009-08-19 13:59 ` Magnus Damm
2009-08-19 13:59   ` Magnus Damm
2009-08-19 14:44   ` Mark Brown
2009-08-19 14:44     ` Mark Brown
2009-08-20 12:11     ` Magnus Damm
2009-08-20 12:11       ` Magnus Damm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090819124206.GA20838@rakim.wolfsonmicro.main \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=lethal@linux-sh.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=morimoto.kuninori@renesas.com \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.