From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Cc: linuxppc-dev@ozlabs.org, Feng Kan <fkan@amcc.com>,
linux-mtd@lists.infradead.org,
Sean MacLennan <smaclennan@pikatech.com>
Subject: Re: [U-Boot] NAND ECC Error with wrong SMC ording bug
Date: Thu, 20 Aug 2009 07:01:21 +0200 [thread overview]
Message-ID: <200908200701.21076.sr@denx.de> (raw)
In-Reply-To: <20090820003851.1a532444@lappy.seanm.ca>
On Thursday 20 August 2009 06:38:51 Sean MacLennan wrote:
> > I see other boards using SMC as well, can someone comment on the
> > change I am proposing.
> > Should I change the correction algorithm or the calculate function?
> > If the later is preferred
> > it would mean the change must be pushed in both U-Boot and Linux.
>
> Odds are the calculate function is wrong. The correction algo is used
> by many nand drivers, I *assume* it is correct. The calculate function
> was set to agree with u-boot (1.3.0).
Yes, it seems that you changed the order in the calculation function while
reworking the NDFC driver for arch/powerpc. So we should probably change this
order back to the original version. And change it in U-Boot as well.
BTW: I didn't see any problems with ECC so far with the current code. Feng,
how did you spot this problem?
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] NAND ECC Error with wrong SMC ording bug
Date: Thu, 20 Aug 2009 07:01:21 +0200 [thread overview]
Message-ID: <200908200701.21076.sr@denx.de> (raw)
In-Reply-To: <20090820003851.1a532444@lappy.seanm.ca>
On Thursday 20 August 2009 06:38:51 Sean MacLennan wrote:
> > I see other boards using SMC as well, can someone comment on the
> > change I am proposing.
> > Should I change the correction algorithm or the calculate function?
> > If the later is preferred
> > it would mean the change must be pushed in both U-Boot and Linux.
>
> Odds are the calculate function is wrong. The correction algo is used
> by many nand drivers, I *assume* it is correct. The calculate function
> was set to agree with u-boot (1.3.0).
Yes, it seems that you changed the order in the calculation function while
reworking the NDFC driver for arch/powerpc. So we should probably change this
order back to the original version. And change it in U-Boot as well.
BTW: I didn't see any problems with ECC so far with the current code. Feng,
how did you spot this problem?
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2009-08-20 5:01 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 23:00 [PATCH 1/3 v3] powerpc/32: Always order writes to halves of 64-bit PTEs Paul Mackerras
2009-08-17 23:00 ` [PATCH 2/3 v3] powerpc: Allow perf_counters to access user memory at interrupt time Paul Mackerras
2009-08-18 4:24 ` Benjamin Herrenschmidt
2009-08-17 23:01 ` [PATCH 3/3 v3] perf_counter: powerpc: Add callchain support Paul Mackerras
2009-08-18 4:23 ` Benjamin Herrenschmidt
2009-08-18 0:00 ` [PATCH 1/3 v3] powerpc/32: Always order writes to halves of 64-bit PTEs Kumar Gala
2009-08-18 0:14 ` Paul Mackerras
2009-08-18 4:24 ` Benjamin Herrenschmidt
2009-08-19 23:16 ` NAND ECC Error with wrong SMC ording bug Feng Kan
2009-08-19 23:16 ` [U-Boot] " Feng Kan
2009-08-20 4:38 ` Sean MacLennan
2009-08-20 4:38 ` [U-Boot] " Sean MacLennan
2009-08-20 5:01 ` Stefan Roese [this message]
2009-08-20 5:01 ` Stefan Roese
2009-08-20 19:36 ` Sean MacLennan
2009-08-20 19:36 ` Sean MacLennan
2009-08-20 22:56 ` Victor Gallardo
2009-08-20 22:56 ` Victor Gallardo
2009-08-20 22:56 ` Victor Gallardo
2009-08-21 5:17 ` vimal singh
2009-08-21 5:17 ` vimal singh
2009-08-21 5:17 ` vimal singh
2009-08-21 6:26 ` Sean MacLennan
2009-08-21 6:26 ` Sean MacLennan
2009-08-21 6:27 ` Stefan Roese
2009-08-21 6:27 ` Stefan Roese
2009-08-21 6:30 ` Victor Gallardo
2009-08-21 6:30 ` Victor Gallardo
2009-08-21 6:30 ` Victor Gallardo
2009-08-20 23:42 ` Feng Kan
2009-08-20 23:42 ` Feng Kan
2009-08-21 7:59 ` Stefan Roese
2009-08-21 7:59 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908200701.21076.sr@denx.de \
--to=sr@denx.de \
--cc=fkan@amcc.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=smaclennan@pikatech.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.