From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Cc: linuxppc-dev@ozlabs.org, linux-mtd@lists.infradead.org,
vimal singh <vimal.newwork@gmail.com>,
Sean MacLennan <smaclennan@pikatech.com>
Subject: Re: [U-Boot] NAND ECC Error with wrong SMC ording bug
Date: Fri, 21 Aug 2009 08:27:13 +0200 [thread overview]
Message-ID: <200908210827.13700.sr@denx.de> (raw)
In-Reply-To: <ce9ab5790908202217t2430646co5059f308a23d7397@mail.gmail.com>
On Friday 21 August 2009 07:17:09 vimal singh wrote:
> > diff --git a/drivers/mtd/nand/ndfc.c b/drivers/mtd/nand/ndfc.c
> > index 89bf85a..497e175 100644
> > --- a/drivers/mtd/nand/ndfc.c
> > +++ b/drivers/mtd/nand/ndfc.c
> > @@ -101,9 +101,8 @@ static int ndfc_calculate_ecc(struct mtd_info *mtd,
> >
> > wmb();
> > ecc = in_be32(ndfc->ndfcbase + NDFC_ECC);
> > - /* The NDFC uses Smart Media (SMC) bytes order */
> > - ecc_code[0] = p[2];
> > - ecc_code[1] = p[1];
> > + ecc_code[0] = p[1];
> > + ecc_code[1] = p[2];
> > ecc_code[2] = p[3];
> >
> > return 0;
> >
> > Does anybody see a problem with my method of reproducing the bug? This
> > bug is deadly for our customers. I don't want to make the change unless
> > it is absolutely necessary..
>
> Just one question: did you enabled MTD_NAND_ECC_SMC in configs?
Yes, MTD_NAND_ECC_SMC is selected via Kconfig for this driver.
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office@denx.de
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Roese <sr@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] NAND ECC Error with wrong SMC ording bug
Date: Fri, 21 Aug 2009 08:27:13 +0200 [thread overview]
Message-ID: <200908210827.13700.sr@denx.de> (raw)
In-Reply-To: <ce9ab5790908202217t2430646co5059f308a23d7397@mail.gmail.com>
On Friday 21 August 2009 07:17:09 vimal singh wrote:
> > diff --git a/drivers/mtd/nand/ndfc.c b/drivers/mtd/nand/ndfc.c
> > index 89bf85a..497e175 100644
> > --- a/drivers/mtd/nand/ndfc.c
> > +++ b/drivers/mtd/nand/ndfc.c
> > @@ -101,9 +101,8 @@ static int ndfc_calculate_ecc(struct mtd_info *mtd,
> >
> > wmb();
> > ecc = in_be32(ndfc->ndfcbase + NDFC_ECC);
> > - /* The NDFC uses Smart Media (SMC) bytes order */
> > - ecc_code[0] = p[2];
> > - ecc_code[1] = p[1];
> > + ecc_code[0] = p[1];
> > + ecc_code[1] = p[2];
> > ecc_code[2] = p[3];
> >
> > return 0;
> >
> > Does anybody see a problem with my method of reproducing the bug? This
> > bug is deadly for our customers. I don't want to make the change unless
> > it is absolutely necessary..
>
> Just one question: did you enabled MTD_NAND_ECC_SMC in configs?
Yes, MTD_NAND_ECC_SMC is selected via Kconfig for this driver.
Cheers,
Stefan
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-0 Fax: (+49)-8142-66989-80 Email: office at denx.de
next prev parent reply other threads:[~2009-08-21 6:27 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 23:00 [PATCH 1/3 v3] powerpc/32: Always order writes to halves of 64-bit PTEs Paul Mackerras
2009-08-17 23:00 ` [PATCH 2/3 v3] powerpc: Allow perf_counters to access user memory at interrupt time Paul Mackerras
2009-08-18 4:24 ` Benjamin Herrenschmidt
2009-08-17 23:01 ` [PATCH 3/3 v3] perf_counter: powerpc: Add callchain support Paul Mackerras
2009-08-18 4:23 ` Benjamin Herrenschmidt
2009-08-18 0:00 ` [PATCH 1/3 v3] powerpc/32: Always order writes to halves of 64-bit PTEs Kumar Gala
2009-08-18 0:14 ` Paul Mackerras
2009-08-18 4:24 ` Benjamin Herrenschmidt
2009-08-19 23:16 ` NAND ECC Error with wrong SMC ording bug Feng Kan
2009-08-19 23:16 ` [U-Boot] " Feng Kan
2009-08-20 4:38 ` Sean MacLennan
2009-08-20 4:38 ` [U-Boot] " Sean MacLennan
2009-08-20 5:01 ` Stefan Roese
2009-08-20 5:01 ` Stefan Roese
2009-08-20 19:36 ` Sean MacLennan
2009-08-20 19:36 ` Sean MacLennan
2009-08-20 22:56 ` Victor Gallardo
2009-08-20 22:56 ` Victor Gallardo
2009-08-20 22:56 ` Victor Gallardo
2009-08-21 5:17 ` vimal singh
2009-08-21 5:17 ` vimal singh
2009-08-21 5:17 ` vimal singh
2009-08-21 6:26 ` Sean MacLennan
2009-08-21 6:26 ` Sean MacLennan
2009-08-21 6:27 ` Stefan Roese [this message]
2009-08-21 6:27 ` Stefan Roese
2009-08-21 6:30 ` Victor Gallardo
2009-08-21 6:30 ` Victor Gallardo
2009-08-21 6:30 ` Victor Gallardo
2009-08-20 23:42 ` Feng Kan
2009-08-20 23:42 ` Feng Kan
2009-08-21 7:59 ` Stefan Roese
2009-08-21 7:59 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200908210827.13700.sr@denx.de \
--to=sr@denx.de \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=smaclennan@pikatech.com \
--cc=u-boot@lists.denx.de \
--cc=vimal.newwork@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.