From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Add RGB555X and RGB565X formats to pxa-camera
Date: Mon, 7 Sep 2009 10:50:11 +0200 [thread overview]
Message-ID: <200909071050.11531.marek.vasut@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0909070818480.4822@axis700.grange>
Dne Po 7. z??? 2009 08:22:22 Guennadi Liakhovetski napsal(a):
> On Mon, 7 Sep 2009, Marek Vasut wrote:
> > Dne Ne 6. z?????? 2009 20:15:17 Guennadi Liakhovetski napsal(a):
> > > On Sun, 6 Sep 2009, Marek Vasut wrote:
> > > > Dne Ne 6. z?????? 2009 18:52:55 Guennadi Liakhovetski napsal(a):
> > > > > On Sun, 6 Sep 2009, Marek Vasut wrote:
> > > > > > Ah damn, I see what you mean. What the camera does is it swaps
> > > > > > the RED and BLUE channel:
> > > > > > 15 14 13 12 11 10 09 08 07 06 05 04 03 02 01 00
> > > > > > B4 B3 B2 B1 B0 G4 G3 G2 G1 G1 R4 R3 R2 R1 R1 --
> > > > > > so it's more a BGR555/565 then. I had to patch fswebcam for this.
> > > > >
> > > > > Ok, this is, of course, something different. In this case you,
> > > > > probably, could deceive the PXA to handle blue as red and the other
> > > > > way round, but still, I would prefer not to do that. Hence my
> > > > > suggestion remains - pass these formats as raw data.
> > > >
> > > > Which is bogus from the camera point of view.
> > >
> > > Not at all. This just means: the subdevice provides a pixel format,
> > > that the bridge (PXA) knows nothing specific about, but it can just
> > > pass it one-to-one (as raw data) to the user - don't see anything bogus
> > > in this. Different bridges have support for different pixel colour
> > > formats, but, I think, all bridges can pass data as raw (pass-through).
> > > Some bridges can _only_ do this, so, this is actually the default
> > > video-capture mode.
> >
> > But then you'll have to tell your software how to process the raw data
> > (in what format they are). If there was this RGB565X passthrough support,
> > the software could at least check if you are not forcing it to process
> > nonsense.
>
> There's no difference for user-space software. It requests BGR555 it gets
> BGR555 back, because that's the information the pxa driver will find in
> this format descriptor: if you take this data and put it in RAM in a
> certain way, you get BGR555.
How's it supposed to get BGR555 if the pxa-camera doesnt support that ? Will the
v4l2 layer convert it or something ?
>
> Thanks
> Guennadi
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/
WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marek.vasut@gmail.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: Eric Miao <eric.y.miao@gmail.com>,
linux-arm-kernel@lists.arm.linux.org.uk,
"Russell King - ARM Linux" <linux@arm.linux.org.uk>,
Linux Media Mailing List <linux-media@vger.kernel.org>,
Mike Rapoport <mike@compulab.co.il>,
Stefan Herbrechtsmeier <hbmeier@hni.uni-paderborn.de>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera
Date: Mon, 7 Sep 2009 10:50:11 +0200 [thread overview]
Message-ID: <200909071050.11531.marek.vasut@gmail.com> (raw)
In-Reply-To: <Pine.LNX.4.64.0909070818480.4822@axis700.grange>
Dne Po 7. září 2009 08:22:22 Guennadi Liakhovetski napsal(a):
> On Mon, 7 Sep 2009, Marek Vasut wrote:
> > Dne Ne 6. záÅà 2009 20:15:17 Guennadi Liakhovetski napsal(a):
> > > On Sun, 6 Sep 2009, Marek Vasut wrote:
> > > > Dne Ne 6. záÅà 2009 18:52:55 Guennadi Liakhovetski napsal(a):
> > > > > On Sun, 6 Sep 2009, Marek Vasut wrote:
> > > > > > Ah damn, I see what you mean. What the camera does is it swaps
> > > > > > the RED and BLUE channel:
> > > > > > 15 14 13 12 11 10 09 08 07 06 05 04 03 02 01 00
> > > > > > B4 B3 B2 B1 B0 G4 G3 G2 G1 G1 R4 R3 R2 R1 R1 --
> > > > > > so it's more a BGR555/565 then. I had to patch fswebcam for this.
> > > > >
> > > > > Ok, this is, of course, something different. In this case you,
> > > > > probably, could deceive the PXA to handle blue as red and the other
> > > > > way round, but still, I would prefer not to do that. Hence my
> > > > > suggestion remains - pass these formats as raw data.
> > > >
> > > > Which is bogus from the camera point of view.
> > >
> > > Not at all. This just means: the subdevice provides a pixel format,
> > > that the bridge (PXA) knows nothing specific about, but it can just
> > > pass it one-to-one (as raw data) to the user - don't see anything bogus
> > > in this. Different bridges have support for different pixel colour
> > > formats, but, I think, all bridges can pass data as raw (pass-through).
> > > Some bridges can _only_ do this, so, this is actually the default
> > > video-capture mode.
> >
> > But then you'll have to tell your software how to process the raw data
> > (in what format they are). If there was this RGB565X passthrough support,
> > the software could at least check if you are not forcing it to process
> > nonsense.
>
> There's no difference for user-space software. It requests BGR555 it gets
> BGR555 back, because that's the information the pxa driver will find in
> this format descriptor: if you take this data and put it in RAM in a
> certain way, you get BGR555.
How's it supposed to get BGR555 if the pxa-camera doesnt support that ? Will the
v4l2 layer convert it or something ?
>
> Thanks
> Guennadi
> ---
> Guennadi Liakhovetski, Ph.D.
> Freelance Open-Source Software Developer
> http://www.open-technology.de/
next prev parent reply other threads:[~2009-09-07 8:50 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200908031031.00676.marek.vasut@gmail.com>
[not found] ` <200908031052.59016.marek.vasut@gmail.com>
2009-08-03 9:17 ` [PATCH] Add RGB555X and RGB565X formats to pxa-camera Trilok Soni
2009-08-03 11:35 ` Eric Miao
2009-08-03 11:43 ` Trilok Soni
2009-08-03 12:31 ` Guennadi Liakhovetski
2009-08-03 12:59 ` Mike Rapoport
2009-09-04 19:05 ` Guennadi Liakhovetski
2009-09-04 19:05 ` Guennadi Liakhovetski
2009-09-06 6:03 ` Mike Rapoport
2009-09-06 6:03 ` Mike Rapoport
2009-08-03 13:59 ` Marek Vasut
2009-09-05 7:26 ` Marek Vasut
2009-09-05 7:26 ` Marek Vasut
2009-09-05 8:55 ` Guennadi Liakhovetski
2009-09-05 8:55 ` Guennadi Liakhovetski
2009-09-05 9:49 ` Marek Vasut
2009-09-05 9:49 ` Marek Vasut
2009-09-05 20:19 ` Guennadi Liakhovetski
2009-09-05 20:19 ` Guennadi Liakhovetski
2009-09-05 21:17 ` Marek Vasut
2009-09-05 21:17 ` Marek Vasut
2009-09-05 22:05 ` Guennadi Liakhovetski
2009-09-05 22:05 ` Guennadi Liakhovetski
2009-09-06 3:50 ` Marek Vasut
2009-09-06 3:50 ` Marek Vasut
2009-09-06 16:52 ` Guennadi Liakhovetski
2009-09-06 16:52 ` Guennadi Liakhovetski
2009-09-06 17:51 ` Marek Vasut
2009-09-06 17:51 ` Marek Vasut
2009-09-06 18:15 ` Guennadi Liakhovetski
2009-09-06 18:15 ` Guennadi Liakhovetski
2009-09-07 4:46 ` Marek Vasut
2009-09-07 4:46 ` Marek Vasut
2009-09-07 6:22 ` Guennadi Liakhovetski
2009-09-07 6:22 ` Guennadi Liakhovetski
2009-09-07 8:50 ` Marek Vasut [this message]
2009-09-07 8:50 ` Marek Vasut
2009-09-07 10:21 ` Robert Jarzmik
2009-09-07 10:21 ` Robert Jarzmik
2009-09-07 11:53 ` Marek Vasut
2009-09-07 11:53 ` Marek Vasut
2009-09-07 12:10 ` Guennadi Liakhovetski
2009-09-07 12:10 ` Guennadi Liakhovetski
2009-09-05 15:22 ` Jamie Lokier
2009-09-05 15:22 ` Jamie Lokier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200909071050.11531.marek.vasut@gmail.com \
--to=marek.vasut@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.