All of lore.kernel.org
 help / color / mirror / Atom feed
From: marek.vasut@gmail.com (Marek Vasut)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] Add RGB555X and RGB565X formats to pxa-camera
Date: Mon, 7 Sep 2009 13:53:42 +0200	[thread overview]
Message-ID: <200909071353.43080.marek.vasut@gmail.com> (raw)
In-Reply-To: <m2iqfvkqbl.fsf@arbois.toulouse.it.atosorigin.com>

Dne Po 7. z??? 2009 12:21:50 Robert Jarzmik napsal(a):
> Marek Vasut <marek.vasut@gmail.com> writes:
> > How's it supposed to get BGR555 if the pxa-camera doesnt support that ?
> > Will the v4l2 layer convert it or something ?
>
> In pxa_camera.c, function pxa_camera_get_formats() :
> >         default:
> >                 /* Generic pass-through */
> >                 formats++;
> >                 if (xlate) {
> >                         xlate->host_fmt = icd->formats + idx;
> >                         xlate->cam_fmt = icd->formats + idx;
> >                         xlate->buswidth = icd->formats[idx].depth;
> >                         xlate++;
> >                         dev_dbg(ici->dev,
> >                                 "Providing format %s in pass-through
> > mode\n", icd->formats[idx].name);
> >                 }
> >         }
>
> "Pass-through" means that if a sensors provides a cc, ie. BGR555 for
> example, the bridge (pxa_camera) will "forward" to RAM the image in the
> very same cc (ie. BGR555). In that case, the bridge is a dummy "sensor to
> RAM" bus translator if you prefer.
>
> Marek, you should activate debug trace and watch for yourself. You can
> trust Guennadi, when he says it will work, well ... it will work.
>
> If it's out of technical curiousity, check the function above.  If you're
> even more curious, there was a thread in linux-media about "RFC: bus
> configuration setup for sub-devices", a very interesting one, especially
> considering the "pass-through" issue.

That one should work for RGB565X ? (the piece of code you posted ?) It's 
interesting it didnt work for me ... ok, I'll take it it works then, whatever. 
I'll test it again when I have time.
>
> Cheers.
>
> --
> Robert

WARNING: multiple messages have this Message-ID (diff)
From: Marek Vasut <marek.vasut@gmail.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
	Eric Miao <eric.y.miao@gmail.com>,
	linux-arm-kernel@lists.arm.linux.org.uk,
	"Russell King - ARM Linux" <linux@arm.linux.org.uk>,
	Linux Media Mailing List <linux-media@vger.kernel.org>,
	Mike Rapoport <mike@compulab.co.il>,
	Stefan Herbrechtsmeier <hbmeier@hni.uni-paderborn.de>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] Add RGB555X and RGB565X formats to pxa-camera
Date: Mon, 7 Sep 2009 13:53:42 +0200	[thread overview]
Message-ID: <200909071353.43080.marek.vasut@gmail.com> (raw)
In-Reply-To: <m2iqfvkqbl.fsf@arbois.toulouse.it.atosorigin.com>

Dne Po 7. září 2009 12:21:50 Robert Jarzmik napsal(a):
> Marek Vasut <marek.vasut@gmail.com> writes:
> > How's it supposed to get BGR555 if the pxa-camera doesnt support that ?
> > Will the v4l2 layer convert it or something ?
>
> In pxa_camera.c, function pxa_camera_get_formats() :
> >         default:
> >                 /* Generic pass-through */
> >                 formats++;
> >                 if (xlate) {
> >                         xlate->host_fmt = icd->formats + idx;
> >                         xlate->cam_fmt = icd->formats + idx;
> >                         xlate->buswidth = icd->formats[idx].depth;
> >                         xlate++;
> >                         dev_dbg(ici->dev,
> >                                 "Providing format %s in pass-through
> > mode\n", icd->formats[idx].name);
> >                 }
> >         }
>
> "Pass-through" means that if a sensors provides a cc, ie. BGR555 for
> example, the bridge (pxa_camera) will "forward" to RAM the image in the
> very same cc (ie. BGR555). In that case, the bridge is a dummy "sensor to
> RAM" bus translator if you prefer.
>
> Marek, you should activate debug trace and watch for yourself. You can
> trust Guennadi, when he says it will work, well ... it will work.
>
> If it's out of technical curiousity, check the function above.  If you're
> even more curious, there was a thread in linux-media about "RFC: bus
> configuration setup for sub-devices", a very interesting one, especially
> considering the "pass-through" issue.

That one should work for RGB565X ? (the piece of code you posted ?) It's 
interesting it didnt work for me ... ok, I'll take it it works then, whatever. 
I'll test it again when I have time.
>
> Cheers.
>
> --
> Robert

  reply	other threads:[~2009-09-07 11:53 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200908031031.00676.marek.vasut@gmail.com>
     [not found] ` <200908031052.59016.marek.vasut@gmail.com>
2009-08-03  9:17   ` [PATCH] Add RGB555X and RGB565X formats to pxa-camera Trilok Soni
2009-08-03 11:35 ` Eric Miao
2009-08-03 11:43   ` Trilok Soni
2009-08-03 12:31   ` Guennadi Liakhovetski
2009-08-03 12:59     ` Mike Rapoport
2009-09-04 19:05       ` Guennadi Liakhovetski
2009-09-04 19:05         ` Guennadi Liakhovetski
2009-09-06  6:03         ` Mike Rapoport
2009-09-06  6:03           ` Mike Rapoport
2009-08-03 13:59     ` Marek Vasut
2009-09-05  7:26     ` Marek Vasut
2009-09-05  7:26       ` Marek Vasut
2009-09-05  8:55       ` Guennadi Liakhovetski
2009-09-05  8:55         ` Guennadi Liakhovetski
2009-09-05  9:49         ` Marek Vasut
2009-09-05  9:49           ` Marek Vasut
2009-09-05 20:19           ` Guennadi Liakhovetski
2009-09-05 20:19             ` Guennadi Liakhovetski
2009-09-05 21:17             ` Marek Vasut
2009-09-05 21:17               ` Marek Vasut
2009-09-05 22:05               ` Guennadi Liakhovetski
2009-09-05 22:05                 ` Guennadi Liakhovetski
2009-09-06  3:50                 ` Marek Vasut
2009-09-06  3:50                   ` Marek Vasut
2009-09-06 16:52                   ` Guennadi Liakhovetski
2009-09-06 16:52                     ` Guennadi Liakhovetski
2009-09-06 17:51                     ` Marek Vasut
2009-09-06 17:51                       ` Marek Vasut
2009-09-06 18:15                       ` Guennadi Liakhovetski
2009-09-06 18:15                         ` Guennadi Liakhovetski
2009-09-07  4:46                         ` Marek Vasut
2009-09-07  4:46                           ` Marek Vasut
2009-09-07  6:22                           ` Guennadi Liakhovetski
2009-09-07  6:22                             ` Guennadi Liakhovetski
2009-09-07  8:50                             ` Marek Vasut
2009-09-07  8:50                               ` Marek Vasut
2009-09-07 10:21                               ` Robert Jarzmik
2009-09-07 10:21                                 ` Robert Jarzmik
2009-09-07 11:53                                 ` Marek Vasut [this message]
2009-09-07 11:53                                   ` Marek Vasut
2009-09-07 12:10                                   ` Guennadi Liakhovetski
2009-09-07 12:10                                     ` Guennadi Liakhovetski
2009-09-05 15:22         ` Jamie Lokier
2009-09-05 15:22           ` Jamie Lokier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200909071353.43080.marek.vasut@gmail.com \
    --to=marek.vasut@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.