All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Luis Rodriguez <Luis.Rodriguez@atheros.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"penberg@cs.helsinki.fi" <penberg@cs.helsinki.fi>,
	"mcgrof@gmail.com" <mcgrof@gmail.com>
Subject: Re: [PATCH v3 0/5] kmemleak: few small cleanups and clear command support
Date: Tue, 8 Sep 2009 09:14:32 -0700	[thread overview]
Message-ID: <20090908161432.GA8839@mosca> (raw)
In-Reply-To: <1252344570.23780.110.camel@pc1117.cambridge.arm.com>

On Mon, Sep 07, 2009 at 10:29:30AM -0700, Catalin Marinas wrote:
> On Fri, 2009-09-04 at 17:44 -0700, Luis R. Rodriguez wrote:
> > Here is my third respin, this time rebased ontop of:
> >
> > git://linux-arm.org/linux-2.6 kmemleak
> >
> > As suggested by Catalin we now clear the list by only painting reported
> > unreferenced objects and the color we use is grey to ensure future
> > scans are possible on these same objects to account for new allocations
> > in the future referenced on the cleared objects.
> >
> > Patch 3 is now a little different, now with a paint_ptr() and
> > a __paint_it() helper.
> 
> Thanks for the patches. They look ok now, I'll merge them tomorrow to my
> kmemleak branch and give them a try.
> 
> > I tested this by clearing kmemleak after bootup, then writing my
> > own buggy module which kmalloc()'d onto some internal pointer,
> > scanned, unloaded, and scanned again and then saw a new shiny
> > report come up:
> 
> BTW, kmemleak comes with a test module which does this.

Thanks for the note, I'll use this in case I need to test more stuff.

  Luis

WARNING: multiple messages have this Message-ID (diff)
From: "Luis R. Rodriguez" <lrodriguez@atheros.com>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Luis Rodriguez <Luis.Rodriguez@Atheros.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"penberg@cs.helsinki.fi" <penberg@cs.helsinki.fi>,
	"mcgrof@gmail.com" <mcgrof@gmail.com>
Subject: Re: [PATCH v3 0/5] kmemleak: few small cleanups and clear command support
Date: Tue, 8 Sep 2009 09:14:32 -0700	[thread overview]
Message-ID: <20090908161432.GA8839@mosca> (raw)
In-Reply-To: <1252344570.23780.110.camel@pc1117.cambridge.arm.com>

On Mon, Sep 07, 2009 at 10:29:30AM -0700, Catalin Marinas wrote:
> On Fri, 2009-09-04 at 17:44 -0700, Luis R. Rodriguez wrote:
> > Here is my third respin, this time rebased ontop of:
> >
> > git://linux-arm.org/linux-2.6 kmemleak
> >
> > As suggested by Catalin we now clear the list by only painting reported
> > unreferenced objects and the color we use is grey to ensure future
> > scans are possible on these same objects to account for new allocations
> > in the future referenced on the cleared objects.
> >
> > Patch 3 is now a little different, now with a paint_ptr() and
> > a __paint_it() helper.
> 
> Thanks for the patches. They look ok now, I'll merge them tomorrow to my
> kmemleak branch and give them a try.
> 
> > I tested this by clearing kmemleak after bootup, then writing my
> > own buggy module which kmalloc()'d onto some internal pointer,
> > scanned, unloaded, and scanned again and then saw a new shiny
> > report come up:
> 
> BTW, kmemleak comes with a test module which does this.

Thanks for the note, I'll use this in case I need to test more stuff.

  Luis

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>

  reply	other threads:[~2009-09-08 16:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-05  0:44 [PATCH v3 0/5] kmemleak: few small cleanups and clear command support Luis R. Rodriguez
2009-09-05  0:44 ` Luis R. Rodriguez
2009-09-05  0:44 ` [PATCH v3 1/5] kmemleak: use bool for true/false questions Luis R. Rodriguez
2009-09-05  0:44   ` Luis R. Rodriguez
2009-09-05  0:44 ` [PATCH v3 2/5] kmemleak: add clear command support Luis R. Rodriguez
2009-09-05  0:44   ` Luis R. Rodriguez
2009-09-08 16:11   ` Catalin Marinas
2009-09-08 16:11     ` Catalin Marinas
2009-09-08 16:16     ` Luis R. Rodriguez
2009-09-08 16:16       ` Luis R. Rodriguez
2009-09-05  0:44 ` [PATCH v3 3/5] kmemleak: move common painting code together Luis R. Rodriguez
2009-09-05  0:44   ` Luis R. Rodriguez
2009-09-05  0:44 ` [PATCH v3 4/5] kmemleak: fix sparse warning over overshadowed flags Luis R. Rodriguez
2009-09-05  0:44   ` Luis R. Rodriguez
2009-09-05  8:49   ` Pekka Enberg
2009-09-05  8:49     ` Pekka Enberg
2009-09-05  0:44 ` [PATCH v3 5/5] kmemleak: fix sparse warning for static declarations Luis R. Rodriguez
2009-09-05  0:44   ` Luis R. Rodriguez
2009-09-07 17:29 ` [PATCH v3 0/5] kmemleak: few small cleanups and clear command support Catalin Marinas
2009-09-07 17:29   ` Catalin Marinas
2009-09-08 16:14   ` Luis R. Rodriguez [this message]
2009-09-08 16:14     ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090908161432.GA8839@mosca \
    --to=lrodriguez@atheros.com \
    --cc=Luis.Rodriguez@atheros.com \
    --cc=catalin.marinas@arm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mcgrof@gmail.com \
    --cc=penberg@cs.helsinki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.