From: Pekka Enberg <penberg@cs.helsinki.fi>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: catalin.marinas@arm.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, mcgrof@gmail.com
Subject: Re: [PATCH v3 4/5] kmemleak: fix sparse warning over overshadowed flags
Date: Sat, 05 Sep 2009 11:49:00 +0300 [thread overview]
Message-ID: <4AA225FC.7080601@cs.helsinki.fi> (raw)
In-Reply-To: <1252111494-7593-5-git-send-email-lrodriguez@atheros.com>
Luis R. Rodriguez wrote:
> A secondary irq_save is not required as a locking before it was
> already disabling irqs.
>
> This fixes this sparse warning:
> mm/kmemleak.c:512:31: warning: symbol 'flags' shadows an earlier one
> mm/kmemleak.c:448:23: originally declared here
>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
WARNING: multiple messages have this Message-ID (diff)
From: Pekka Enberg <penberg@cs.helsinki.fi>
To: "Luis R. Rodriguez" <lrodriguez@atheros.com>
Cc: catalin.marinas@arm.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, mcgrof@gmail.com
Subject: Re: [PATCH v3 4/5] kmemleak: fix sparse warning over overshadowed flags
Date: Sat, 05 Sep 2009 11:49:00 +0300 [thread overview]
Message-ID: <4AA225FC.7080601@cs.helsinki.fi> (raw)
In-Reply-To: <1252111494-7593-5-git-send-email-lrodriguez@atheros.com>
Luis R. Rodriguez wrote:
> A secondary irq_save is not required as a locking before it was
> already disabling irqs.
>
> This fixes this sparse warning:
> mm/kmemleak.c:512:31: warning: symbol 'flags' shadows an earlier one
> mm/kmemleak.c:448:23: originally declared here
>
> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-09-05 8:49 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-05 0:44 [PATCH v3 0/5] kmemleak: few small cleanups and clear command support Luis R. Rodriguez
2009-09-05 0:44 ` Luis R. Rodriguez
2009-09-05 0:44 ` [PATCH v3 1/5] kmemleak: use bool for true/false questions Luis R. Rodriguez
2009-09-05 0:44 ` Luis R. Rodriguez
2009-09-05 0:44 ` [PATCH v3 2/5] kmemleak: add clear command support Luis R. Rodriguez
2009-09-05 0:44 ` Luis R. Rodriguez
2009-09-08 16:11 ` Catalin Marinas
2009-09-08 16:11 ` Catalin Marinas
2009-09-08 16:16 ` Luis R. Rodriguez
2009-09-08 16:16 ` Luis R. Rodriguez
2009-09-05 0:44 ` [PATCH v3 3/5] kmemleak: move common painting code together Luis R. Rodriguez
2009-09-05 0:44 ` Luis R. Rodriguez
2009-09-05 0:44 ` [PATCH v3 4/5] kmemleak: fix sparse warning over overshadowed flags Luis R. Rodriguez
2009-09-05 0:44 ` Luis R. Rodriguez
2009-09-05 8:49 ` Pekka Enberg [this message]
2009-09-05 8:49 ` Pekka Enberg
2009-09-05 0:44 ` [PATCH v3 5/5] kmemleak: fix sparse warning for static declarations Luis R. Rodriguez
2009-09-05 0:44 ` Luis R. Rodriguez
2009-09-07 17:29 ` [PATCH v3 0/5] kmemleak: few small cleanups and clear command support Catalin Marinas
2009-09-07 17:29 ` Catalin Marinas
2009-09-08 16:14 ` Luis R. Rodriguez
2009-09-08 16:14 ` Luis R. Rodriguez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4AA225FC.7080601@cs.helsinki.fi \
--to=penberg@cs.helsinki.fi \
--cc=catalin.marinas@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lrodriguez@atheros.com \
--cc=mcgrof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.