From: Jens Axboe <jens.axboe@oracle.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>
Cc: a.p.zijlstra@chello.nl, trond.myklebust@fys.uio.no
Subject: [PATCH] nfs: fix bdi_unregister() before sb kill
Date: Thu, 17 Sep 2009 14:42:33 +0200 [thread overview]
Message-ID: <20090917124233.GJ23126@kernel.dk> (raw)
Hi,
This can cause a hang on NFS umount, since the bdi gets pruned before we
flush any pending dirty IO. Peter, can you check whether it fixes your
issue?
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
diff --git a/fs/nfs/super.c b/fs/nfs/super.c
index de93569..f1cc058 100644
--- a/fs/nfs/super.c
+++ b/fs/nfs/super.c
@@ -2190,8 +2190,8 @@ static void nfs_kill_super(struct super_block *s)
{
struct nfs_server *server = NFS_SB(s);
- bdi_unregister(&server->backing_dev_info);
kill_anon_super(s);
+ bdi_unregister(&server->backing_dev_info);
nfs_fscache_release_super_cookie(s);
nfs_free_server(server);
}
--
Jens Axboe
next reply other threads:[~2009-09-17 12:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-17 12:42 Jens Axboe [this message]
2009-09-17 19:40 ` [PATCH] nfs: fix bdi_unregister() before sb kill Jens Axboe
2009-09-17 19:47 ` Peter Zijlstra
2009-09-17 19:48 ` Jens Axboe
2009-09-17 23:16 ` Trond Myklebust
2009-09-18 6:40 ` Jens Axboe
2009-09-18 15:02 ` Jens Axboe
2009-09-18 16:19 ` Trond Myklebust
2009-09-18 17:36 ` Jens Axboe
2009-09-18 18:32 ` Jens Axboe
2009-09-18 18:40 ` Trond Myklebust
2009-09-18 18:46 ` Jens Axboe
2009-09-18 20:01 ` Jens Axboe
2009-09-18 20:05 ` Jens Axboe
2009-09-18 20:11 ` Trond Myklebust
2009-09-18 20:16 ` Peter Zijlstra
2009-09-18 20:22 ` Jens Axboe
2009-09-18 20:38 ` Peter Zijlstra
2009-09-18 20:44 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090917124233.GJ23126@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=a.p.zijlstra@chello.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.