All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] nfs: fix bdi_unregister() before sb kill
Date: Fri, 18 Sep 2009 22:44:09 +0200	[thread overview]
Message-ID: <20090918204409.GV23126@kernel.dk> (raw)
In-Reply-To: <1253306306.10538.80.camel@laptop>

On Fri, Sep 18 2009, Peter Zijlstra wrote:
> On Fri, 2009-09-18 at 22:22 +0200, Jens Axboe wrote:
> > On Fri, Sep 18 2009, Peter Zijlstra wrote:
> > > On Fri, 2009-09-18 at 20:32 +0200, Jens Axboe wrote:
> > > > Peter, if you have
> > > > the time, it would be nice if you could check whether this one works for
> > > > you too.
> > > 
> > > Doesn't make my machine happy :/
> > 
> > That looks like a double register. Irk, I see what it is... Can you try
> > this additional patch?
> 
> Still deeply unhappy,..
> 
> 1) double bdi registation
> 2) lockdep splat on bdi registration
> 3) NULL ptr deref on netfs automount
> 
> Also note the lockdep splat which I think is caused by these patches..

Sigh, I guess no love for me tonight. OK thanks for testing Peter, I
guess a real tested fix will have to wait for me to get behind the test
box.

-- 
Jens Axboe


      reply	other threads:[~2009-09-18 20:44 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-17 12:42 [PATCH] nfs: fix bdi_unregister() before sb kill Jens Axboe
2009-09-17 19:40 ` Jens Axboe
2009-09-17 19:47   ` Peter Zijlstra
2009-09-17 19:48     ` Jens Axboe
2009-09-17 23:16   ` Trond Myklebust
2009-09-18  6:40     ` Jens Axboe
2009-09-18 15:02       ` Jens Axboe
2009-09-18 16:19         ` Trond Myklebust
2009-09-18 17:36           ` Jens Axboe
2009-09-18 18:32             ` Jens Axboe
2009-09-18 18:40               ` Trond Myklebust
2009-09-18 18:46                 ` Jens Axboe
2009-09-18 20:01                   ` Jens Axboe
2009-09-18 20:05                     ` Jens Axboe
2009-09-18 20:11                       ` Trond Myklebust
2009-09-18 20:16               ` Peter Zijlstra
2009-09-18 20:22                 ` Jens Axboe
2009-09-18 20:38                   ` Peter Zijlstra
2009-09-18 20:44                     ` Jens Axboe [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090918204409.GV23126@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trond.myklebust@fys.uio.no \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.