Re: [lm-sensors] [PATCH] hwmon w83627hf: add mfd support.

[Rodolfo Giometti <giometti@enneenne.com>]

[-- Attachment #1.1: Type: text/plain, Size: 1839 bytes --]

On Thu, Sep 17, 2009 at 03:57:55PM +0200, Jean Delvare wrote:
> On Thu, 17 Sep 2009 15:51:20 +0200, Rodolfo Giometti wrote:
> > On Thu, Sep 17, 2009 at 03:34:50PM +0200, Jean Delvare wrote:
> > > Hi Rodolfo,
> > > 
> > > On Fri, 11 Sep 2009 17:07:05 +0200, Rodolfo Giometti wrote:
> > > > The file has been splitted up into two parts:
> > > 
> > > Spelling: split (it's an irregular verb.)
> > > 
> > > > 
> > > > * drivers/mfd/w83627hf-core.c      - detects the chip and define proper
> > > >                                      platform devices into mfd support
> > > > 
> > > > * drivers/hwmon/w83627hf.c         - implements the driver for hwmon
> > > >                                      functionality only
> > > > 
> > > > The patch also fixes up some non reentrant code and some C-style issues.
> > > 
> > > Sounds wrong. Mixing coding style cleanups with real changes makes
> > > reviewing much harder. You'll have to move these changes to a separate
> > > patch I'm afraid.
> > 
> > Ok, I'll repropose a patch.
> > 
> > I prefer propose a patch with real changes only, is that correct even
> > if checkpatch.pl says no? :)
> 
> If you run checkpath.pl on the patch and not the source files, it won't
> complain about the parts you're not touching.

I agree, but I'm going to create a new file by splitting an old one
and during such split I can just copy code from the old file which may
have a wrong style... should this code be fixed?

Ciao,

Rodolfo

-- 

GNU/Linux Solutions                  e-mail: giometti@enneenne.com
Linux Device Driver                          giometti@linux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti
Freelance ICT Italia - Consulente ICT Italia - www.consulenti-ict.it

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

[-- Attachment #2: Type: text/plain, Size: 153 bytes --]

_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors