From: Russell King <rmk@arm.linux.org.uk>
To: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Santosh Shilimkar <santosh.shilimkar@ti.com>,
tony@atomide.com, linux-arm-kernel@lists.infradead.org,
linux-arm-kernel@lists.arm.linux.org.uk,
linux-omap@vger.kernel.org,
Syed Rafiuddin <rafiuddin.syed@ti.com>
Subject: Re: [PATCH 1/2 v2] ARM: OMAP4: Fix NULL pointer dereference crash.
Date: Fri, 18 Sep 2009 12:51:04 +0100 [thread overview]
Message-ID: <20090918115104.GC4075@flint.arm.linux.org.uk> (raw)
In-Reply-To: <87hbvytich.fsf@deeprootsystems.com>
On Sun, Aug 23, 2009 at 10:56:14PM +0300, Kevin Hilman wrote:
> This should not be FOURPORT, it should just be a number. In this case,
> it should be 3 (the others start from zero.)
>
> The Zoom2 one should then be changed to something >= 4.
No it should not. There's an enum to control the numbering of these.
Use that.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
WARNING: multiple messages have this Message-ID (diff)
From: rmk@arm.linux.org.uk (Russell King)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2 v2] ARM: OMAP4: Fix NULL pointer dereference crash.
Date: Fri, 18 Sep 2009 12:51:04 +0100 [thread overview]
Message-ID: <20090918115104.GC4075@flint.arm.linux.org.uk> (raw)
In-Reply-To: <87hbvytich.fsf@deeprootsystems.com>
On Sun, Aug 23, 2009 at 10:56:14PM +0300, Kevin Hilman wrote:
> This should not be FOURPORT, it should just be a number. In this case,
> it should be 3 (the others start from zero.)
>
> The Zoom2 one should then be changed to something >= 4.
No it should not. There's an enum to control the numbering of these.
Use that.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2009-09-18 11:51 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-22 8:00 [PATCH 1/2 v2] ARM: OMAP4: Fix NULL pointer dereference crash Santosh Shilimkar
2009-08-22 8:00 ` Santosh Shilimkar
2009-08-22 8:00 ` [PATCH 2/2 v2] ARM: OMAP4: Bypass the clock check Santosh Shilimkar
2009-08-22 8:00 ` Santosh Shilimkar
2009-08-23 19:56 ` [PATCH 1/2 v2] ARM: OMAP4: Fix NULL pointer dereference crash Kevin Hilman
2009-08-23 19:56 ` Kevin Hilman
2009-08-24 11:49 ` Kevin Hilman
2009-08-24 11:49 ` Kevin Hilman
2009-08-24 12:26 ` Shilimkar, Santosh
2009-08-24 12:26 ` Shilimkar, Santosh
2009-08-24 12:39 ` Kevin Hilman
2009-08-24 12:39 ` Kevin Hilman
2009-09-18 11:51 ` Russell King [this message]
2009-09-18 11:51 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090918115104.GC4075@flint.arm.linux.org.uk \
--to=rmk@arm.linux.org.uk \
--cc=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=rafiuddin.syed@ti.com \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.