From: Kevin Hilman <khilman@deeprootsystems.com>
To: "Shilimkar, Santosh" <santosh.shilimkar@ti.com>
Cc: "tony@atomide.com" <tony@atomide.com>,
"rmk@arm.linux.org.uk" <rmk@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-arm-kernel@lists.arm.linux.org.uk"
<linux-arm-kernel@lists.arm.linux.org.uk>,
"linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"Syed, Rafiuddin" <rafiuddin.syed@ti.com>
Subject: Re: [PATCH 1/2 v2] ARM: OMAP4: Fix NULL pointer dereference crash.
Date: Mon, 24 Aug 2009 15:39:39 +0300 [thread overview]
Message-ID: <87tyzxper8.fsf@deeprootsystems.com> (raw)
In-Reply-To: <EAF47CD23C76F840A9E7FCE10091EFAB02BA434EC2@dbde02.ent.ti.com> (Santosh Shilimkar's message of "Mon\, 24 Aug 2009 17\:56\:00 +0530")
"Shilimkar, Santosh" <santosh.shilimkar@ti.com> writes:
>> >> static inline unsigned int serial_read_reg(struct plat_serial8250_port
>> *up,
>> >> int offset)
>> >> {
>> >> @@ -550,6 +564,17 @@ static struct omap_uart_state
>> omap_uart[OMAP_MAX_NR_PORTS] = {
>> >> },
>> >> },
>> >> },
>> >> +#ifdef CONFIG_ARCH_OMAP4
>> >> + {
>> >> + .pdev = {
>> >> + .name = "serial8250",
>> >> + .id = PLAT8250_DEV_FOURPORT,
>> >
>> > This should not be FOURPORT, it should just be a number. In this case,
>> > it should be 3 (the others start from zero.)
>>
>> Santosh,
>>
>> I've changed the .id field to '3' and will queue up this fix for the
>> next merge window along with my fixes queue[1]. Please let me know if you
>> want to do otherwise.
>
> This is fine Kevin. Thanks !!
>
> Bye the way I have also posted v3 version in which I changed the .id field to 3.
Yeah, saw that after I replied. Thanks!
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@deeprootsystems.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2 v2] ARM: OMAP4: Fix NULL pointer dereference crash.
Date: Mon, 24 Aug 2009 15:39:39 +0300 [thread overview]
Message-ID: <87tyzxper8.fsf@deeprootsystems.com> (raw)
In-Reply-To: <EAF47CD23C76F840A9E7FCE10091EFAB02BA434EC2@dbde02.ent.ti.com> (Santosh Shilimkar's message of "Mon\, 24 Aug 2009 17\:56\:00 +0530")
"Shilimkar, Santosh" <santosh.shilimkar@ti.com> writes:
>> >> static inline unsigned int serial_read_reg(struct plat_serial8250_port
>> *up,
>> >> int offset)
>> >> {
>> >> @@ -550,6 +564,17 @@ static struct omap_uart_state
>> omap_uart[OMAP_MAX_NR_PORTS] = {
>> >> },
>> >> },
>> >> },
>> >> +#ifdef CONFIG_ARCH_OMAP4
>> >> + {
>> >> + .pdev = {
>> >> + .name = "serial8250",
>> >> + .id = PLAT8250_DEV_FOURPORT,
>> >
>> > This should not be FOURPORT, it should just be a number. In this case,
>> > it should be 3 (the others start from zero.)
>>
>> Santosh,
>>
>> I've changed the .id field to '3' and will queue up this fix for the
>> next merge window along with my fixes queue[1]. Please let me know if you
>> want to do otherwise.
>
> This is fine Kevin. Thanks !!
>
> Bye the way I have also posted v3 version in which I changed the .id field to 3.
Yeah, saw that after I replied. Thanks!
Kevin
next prev parent reply other threads:[~2009-08-24 12:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-22 8:00 [PATCH 1/2 v2] ARM: OMAP4: Fix NULL pointer dereference crash Santosh Shilimkar
2009-08-22 8:00 ` Santosh Shilimkar
2009-08-22 8:00 ` [PATCH 2/2 v2] ARM: OMAP4: Bypass the clock check Santosh Shilimkar
2009-08-22 8:00 ` Santosh Shilimkar
2009-08-23 19:56 ` [PATCH 1/2 v2] ARM: OMAP4: Fix NULL pointer dereference crash Kevin Hilman
2009-08-23 19:56 ` Kevin Hilman
2009-08-24 11:49 ` Kevin Hilman
2009-08-24 11:49 ` Kevin Hilman
2009-08-24 12:26 ` Shilimkar, Santosh
2009-08-24 12:26 ` Shilimkar, Santosh
2009-08-24 12:39 ` Kevin Hilman [this message]
2009-08-24 12:39 ` Kevin Hilman
2009-09-18 11:51 ` Russell King
2009-09-18 11:51 ` Russell King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87tyzxper8.fsf@deeprootsystems.com \
--to=khilman@deeprootsystems.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=rafiuddin.syed@ti.com \
--cc=rmk@arm.linux.org.uk \
--cc=santosh.shilimkar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.