Re: [patch 00/11] new truncate sequence

[Al Viro <viro@ZenIV.linux.org.uk>]

On Tue, Sep 22, 2009 at 10:00:42PM +0200, Christoph Hellwig wrote:
> On Tue, Sep 22, 2009 at 04:04:44PM +0100, Al Viro wrote:
> > On Fri, Aug 21, 2009 at 02:35:04AM +1000, npiggin@suse.de wrote:
> > > Hi,
> > > 
> > > I have made a few small changes that were suggested, and converted
> > > a few more filesystems over. I didn't spend so much time on converting
> > > them this week so I think it should be best to just get it out now.
> > 
> > Umm... who calls jfs_setsize()?
> 
> Yeah, noticed this while looking over the series.  The JFS patch seems
> to be botched.

It is...  I really don't like some parts of that:
	* failing on foo_truncate() is all nice and proper, but
what to do about the quota transfer that has already happened?
Note that e.g. ext2_setattr() simply doesn't change uid/gid in
case of ext2_setsize() failure.  It does transfer quota, though.
And yes, nfsd can produce calls with both ATTR_SIZE and ATTR_UID
set.
	* way, _way_ too much boilerplate around the aforementioned
quota transfers.
	* if we don't do quota handling for minix and sysv (fair enough,
no quota support implemented for those), why the devil are we doing it
in simple_setattr()?

Anyway, #new-truncate in the usual VFS tree contains all "new truncate
scheme" stuff I've collected from the lists so far.  Additions are welcome...