Re: [patch 03/11] fs: introduce new truncate sequence

[Artem Bityutskiy <dedekind1@gmail.com>]

Hi,

just minor suggestions.

On 08/20/2009 07:35 PM, npiggin@suse.de wrote:
> +/**
> + * generic_setattr - copy simple metadata updates into the generic inode
> + * @inode:	the inode to be updated
> + * @attr:	the new attributes
> + *
> + * generic_setattr must be called with i_mutex held.
> + *
> + * generic_setattr updates the inode's metadata with that specified
> + * in attr. Noticably missing is inode size update, which is more complex
> + * as it requires pagecache updates. See simple_setsize.
> + *
> + * The inode is not marked as dirty after this operation. The rationale is
> + * that for "simple" filesystems, the struct inode is the inode storage.
> + * The caller is free to mark the inode dirty afterwards if needed.
> + */
> +void generic_setattr(struct inode *inode, struct iattr *attr)
>   {

Could you use 'const' for attr here?

> +/*
> + * note this function is deprecated, the new truncate sequence should be
> + * used instead -- see eg. simple_setsize, generic_setattr.
> + */
> +int inode_setattr(struct inode *inode, struct iattr * attr)
> +{

And for 'attr' here, as well as do a tiny clean-up and us '*attr', not '* attr'.
:-)

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html