Re: [patch 01/11] fs: new truncate helpers

[Artem Bityutskiy <dedekind1@gmail.com>]

Hi,

On 08/20/2009 07:35 PM, npiggin@suse.de wrote:
> +/**
> + * inode_newsize_ok - may this inode be truncated to a given size
> + * @inode:	the inode to be truncated
> + * @offset:	the new size to assign to the inode
> + * @Returns:	0 on success, -ve errno on failure
> + *
> + * inode_newsize_ok will check filesystem limits and ulimits to check that the
> + * new inode size is within limits. inode_newsize_ok will also send SIGXFSZ
> + * when necessary. Caller must not proceed with inode size change if failure is
> + * returned. @inode must be a file (not directory), with appropriate
> + * permissions to allow truncate (inode_newsize_ok does NOT check these
> + * conditions).
> + *
> + * inode_newsize_ok must be called with i_mutex held.
> + */
> +int inode_newsize_ok(struct inode *inode, loff_t offset)
> +{

Could you use 'const' for inode here?

-- 
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
--
To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html