All of lore.kernel.org
 help / color / mirror / Atom feed
From: Amit Shah <amit.shah@redhat.com>
To: "Richard W.M. Jones" <rjones@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports
Date: Tue, 20 Oct 2009 17:46:59 +0530	[thread overview]
Message-ID: <20091020121659.GD5487@amit-x200.redhat.com> (raw)
In-Reply-To: <20091020120559.GA24800@amd.home.annexia.org>

On (Tue) Oct 20 2009 [13:05:59], Richard W.M. Jones wrote:
> On Tue, Oct 20, 2009 at 05:31:23PM +0530, Amit Shah wrote:
> > How about (deprecated)? (We need to have this in some general policy of
> > deprecating command-line options.)
> 
> No, the important thing is that we can detect somehow that multiport
> virtio console is possible for some random version of qemu that we
> have to work with.
>
> The only feasible way we've been able to discover is to poke qemu with
> various arguments (usually, "qemu -help") and then match on substrings
> in the output.

Hm, probing with -device '?' will get you the new devices:

-device virtio-serial-pci and -device virtserialport are two new devices
added (along with -device virtconsole). 

> If there's a better way to do this, please let me know.

I'm not sure of that, but there should be.

> But for now, having "(multiport)" there allows us to detect that
> multiport virtio console is supported.

But suggesting -virtioconsole supports multiport is misleading and
further usage of -virtioconsole is not to be encouraged as well..

> > > I think you mean -device virtconsole here.
> > 
> > Yeah; thanks. Will fix.
> 
> So is this documentation correct or not?
> 
>   http://www.linux-kvm.org/page/VMchannel_Requirements#Invocation

Yes, that's updated very recently and is according to what we have now.

		Amit

  reply	other threads:[~2009-10-20 12:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-20  7:13 [Qemu-devel] [PATCH v9 0/3] virtio-console: Add support for multiple ports for generic guest-host communication Amit Shah
2009-10-20  7:13 ` [Qemu-devel] [PATCH v9 1/3] qdev: add string property Amit Shah
2009-10-20  7:13   ` [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports Amit Shah
2009-10-20  7:13     ` [Qemu-devel] [PATCH v9 3/3] virtio-console: Add a new virtserialport device for generic serial port support Amit Shah
2009-10-20  8:51       ` Gerd Hoffmann
2009-10-20  9:48         ` Amit Shah
2009-10-20 14:02           ` Gerd Hoffmann
2009-10-21  3:44             ` Amit Shah
2009-10-20  8:49     ` [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports Gerd Hoffmann
2009-10-20 11:08     ` Richard W.M. Jones
2009-10-20 12:01       ` Amit Shah
2009-10-20 12:05         ` Richard W.M. Jones
2009-10-20 12:16           ` Amit Shah [this message]
2009-10-20  8:56 ` [Qemu-devel] [PATCH v9 0/3] virtio-console: Add support for multiple ports for generic guest-host communication Gerd Hoffmann
2009-10-20  9:50   ` Amit Shah
2009-10-20 11:54 ` Dor Laor
2009-10-20 12:03   ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091020121659.GD5487@amit-x200.redhat.com \
    --to=amit.shah@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rjones@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.