All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@redhat.com>
To: Amit Shah <amit.shah@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v9 0/3] virtio-console: Add support for	multiple ports for generic guest-host communication
Date: Tue, 20 Oct 2009 10:56:40 +0200	[thread overview]
Message-ID: <4ADD7B48.2030704@redhat.com> (raw)
In-Reply-To: <1256022825-16180-1-git-send-email-amit.shah@redhat.com>

   Hi,

> This patch series fixes a few problems since the last send, mainly in
> the save/restore code and a few bugs shown by the automated test suite
> (located in a separate git repo, link below).

A bit hard to review in this form, especially the virtio-console.c 
changes, because you put everything upside down in that file.  Hard to 
do better though given the massive code reorganization ...

So I applied the bits and looked at the resulting tree instead.  Looks 
good overall, just a few minor nits, check the replies to the individual 
patches.  I think we are ready to go as soon as the linux kernel side is 
on the way to mainline.

cheers,
   Gerd

  parent reply	other threads:[~2009-10-20  8:56 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-20  7:13 [Qemu-devel] [PATCH v9 0/3] virtio-console: Add support for multiple ports for generic guest-host communication Amit Shah
2009-10-20  7:13 ` [Qemu-devel] [PATCH v9 1/3] qdev: add string property Amit Shah
2009-10-20  7:13   ` [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports Amit Shah
2009-10-20  7:13     ` [Qemu-devel] [PATCH v9 3/3] virtio-console: Add a new virtserialport device for generic serial port support Amit Shah
2009-10-20  8:51       ` Gerd Hoffmann
2009-10-20  9:48         ` Amit Shah
2009-10-20 14:02           ` Gerd Hoffmann
2009-10-21  3:44             ` Amit Shah
2009-10-20  8:49     ` [Qemu-devel] [PATCH v9 2/3] virtio-console: Add a virtio-serial bus, support for multiple ports Gerd Hoffmann
2009-10-20 11:08     ` Richard W.M. Jones
2009-10-20 12:01       ` Amit Shah
2009-10-20 12:05         ` Richard W.M. Jones
2009-10-20 12:16           ` Amit Shah
2009-10-20  8:56 ` Gerd Hoffmann [this message]
2009-10-20  9:50   ` [Qemu-devel] [PATCH v9 0/3] virtio-console: Add support for multiple ports for generic guest-host communication Amit Shah
2009-10-20 11:54 ` Dor Laor
2009-10-20 12:03   ` Amit Shah

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ADD7B48.2030704@redhat.com \
    --to=kraxel@redhat.com \
    --cc=amit.shah@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.