All of lore.kernel.org
 help / color / mirror / Atom feed
From: greg@kroah.com (Greg KH)
To: linux-arm-kernel@lists.infradead.org
Subject: staging/dream: add gpio and pmem support
Date: Wed, 28 Oct 2009 15:11:55 -0700	[thread overview]
Message-ID: <20091028221155.GA25429@kroah.com> (raw)
In-Reply-To: <20091028215612.GB8053@elf.ucw.cz>

On Wed, Oct 28, 2009 at 10:56:12PM +0100, Pavel Machek wrote:
> 
> > > > With this patch, will it build properly?
> > > 
> > > Its certainly way closer to building... it builds for me, with
> > > something like below; platform devices really are initialized from
> > > board-* files and get passed parameters.
> > 
> > Ick.  This isn't ok, we can't take patches for staging stuff in files
> > outside of drivers/staging/
> 
> I know, I was trying to show that ammount of required changes is very small.
> 
> > So for now, I've deleted the drivers/staging/dream/ directory from my
> > tree, which will get pushed for 2.6.33.  Please clean the code up and
> > get it into buildable shape and I will be glad to add the drivers back
> > into the staging directory at that time.
> 
> Ok, I got something that builds; verifying it on device is hard, as
> last kernel that boots there is 2.6.29...
> 
> Should I turn it into series and submit?

Yes please.

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: Greg KH <greg@kroah.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Arve Hj?nnev?g <arve@android.com>,
	kernel list <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Brian Swetland <swetland@google.com>
Subject: Re: staging/dream: add gpio and pmem support
Date: Wed, 28 Oct 2009 15:11:55 -0700	[thread overview]
Message-ID: <20091028221155.GA25429@kroah.com> (raw)
In-Reply-To: <20091028215612.GB8053@elf.ucw.cz>

On Wed, Oct 28, 2009 at 10:56:12PM +0100, Pavel Machek wrote:
> 
> > > > With this patch, will it build properly?
> > > 
> > > Its certainly way closer to building... it builds for me, with
> > > something like below; platform devices really are initialized from
> > > board-* files and get passed parameters.
> > 
> > Ick.  This isn't ok, we can't take patches for staging stuff in files
> > outside of drivers/staging/
> 
> I know, I was trying to show that ammount of required changes is very small.
> 
> > So for now, I've deleted the drivers/staging/dream/ directory from my
> > tree, which will get pushed for 2.6.33.  Please clean the code up and
> > get it into buildable shape and I will be glad to add the drivers back
> > into the staging directory at that time.
> 
> Ok, I got something that builds; verifying it on device is hard, as
> last kernel that boots there is 2.6.29...
> 
> Should I turn it into series and submit?

Yes please.

thanks,

greg k-h

  reply	other threads:[~2009-10-28 22:11 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-22  9:13 staging/dream: add gpio and pmem support Pavel Machek
2009-10-22  9:13 ` Pavel Machek
2009-10-26 23:43 ` Greg KH
2009-10-26 23:43   ` Greg KH
2009-10-27  0:17   ` Pavel Machek
2009-10-27  0:17     ` Pavel Machek
2009-10-27  3:00     ` Greg KH
2009-10-27  3:00       ` Greg KH
2009-10-27  8:19       ` Pavel Machek
2009-10-27  8:19         ` Pavel Machek
2009-10-27 16:57         ` Greg KH
2009-10-27 16:57           ` Greg KH
2009-10-27 19:33           ` Pavel Machek
2009-10-27 19:33             ` Pavel Machek
2009-10-27 20:44             ` Greg KH
2009-10-27 20:44               ` Greg KH
2009-10-27 23:25               ` Pavel Machek
2009-10-27 23:25                 ` Pavel Machek
2009-10-28 15:51                 ` Greg KH
2009-10-28 15:51                   ` Greg KH
2009-10-28 21:56                   ` Pavel Machek
2009-10-28 21:56                     ` Pavel Machek
2009-10-28 22:11                     ` Greg KH [this message]
2009-10-28 22:11                       ` Greg KH
2009-10-28 22:41                       ` Pavel Machek
2009-10-28 22:41                         ` Pavel Machek
2009-10-27 22:03             ` Brian Swetland
2009-10-27 22:03               ` Brian Swetland
2009-10-28 21:22               ` Pavel Machek
2009-10-28 21:22                 ` Pavel Machek
2009-10-28  8:59 ` Paulius Zaleckas
2009-10-28  8:59   ` Paulius Zaleckas
2009-10-28  9:05   ` Pavel Machek
2009-10-28  9:05     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20091028221155.GA25429@kroah.com \
    --to=greg@kroah.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.