All of lore.kernel.org
 help / color / mirror / Atom feed
From: paulius.zaleckas@gmail.com (Paulius Zaleckas)
To: linux-arm-kernel@lists.infradead.org
Subject: staging/dream: add gpio and pmem support
Date: Wed, 28 Oct 2009 10:59:36 +0200	[thread overview]
Message-ID: <4AE807F8.2040909@gmail.com> (raw)
In-Reply-To: <20091022091333.GA31023@elf.ucw.cz>

On 10/22/2009 12:13 PM, Pavel Machek wrote:
>
> This adds generic_gpio and pmem support, both are needed for other
> dream drivers.

Why you are not using existing gpiolib? That would make your driver a
lot smaller and cleaner... and possibly with less bugs...

Why not split gpio and pmem into separate patches?

> Signed-off-by: Pavel Machek<pavel@ucw.cz>

WARNING: multiple messages have this Message-ID (diff)
From: Paulius Zaleckas <paulius.zaleckas@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Arve Hj?nnev?g <arve@android.com>,
	kernel list <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	Brian Swetland <swetland@google.com>,
	greg@kroah.com
Subject: Re: staging/dream: add gpio and pmem support
Date: Wed, 28 Oct 2009 10:59:36 +0200	[thread overview]
Message-ID: <4AE807F8.2040909@gmail.com> (raw)
In-Reply-To: <20091022091333.GA31023@elf.ucw.cz>

On 10/22/2009 12:13 PM, Pavel Machek wrote:
>
> This adds generic_gpio and pmem support, both are needed for other
> dream drivers.

Why you are not using existing gpiolib? That would make your driver a
lot smaller and cleaner... and possibly with less bugs...

Why not split gpio and pmem into separate patches?

> Signed-off-by: Pavel Machek<pavel@ucw.cz>

  parent reply	other threads:[~2009-10-28  8:59 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-22  9:13 staging/dream: add gpio and pmem support Pavel Machek
2009-10-22  9:13 ` Pavel Machek
2009-10-26 23:43 ` Greg KH
2009-10-26 23:43   ` Greg KH
2009-10-27  0:17   ` Pavel Machek
2009-10-27  0:17     ` Pavel Machek
2009-10-27  3:00     ` Greg KH
2009-10-27  3:00       ` Greg KH
2009-10-27  8:19       ` Pavel Machek
2009-10-27  8:19         ` Pavel Machek
2009-10-27 16:57         ` Greg KH
2009-10-27 16:57           ` Greg KH
2009-10-27 19:33           ` Pavel Machek
2009-10-27 19:33             ` Pavel Machek
2009-10-27 20:44             ` Greg KH
2009-10-27 20:44               ` Greg KH
2009-10-27 23:25               ` Pavel Machek
2009-10-27 23:25                 ` Pavel Machek
2009-10-28 15:51                 ` Greg KH
2009-10-28 15:51                   ` Greg KH
2009-10-28 21:56                   ` Pavel Machek
2009-10-28 21:56                     ` Pavel Machek
2009-10-28 22:11                     ` Greg KH
2009-10-28 22:11                       ` Greg KH
2009-10-28 22:41                       ` Pavel Machek
2009-10-28 22:41                         ` Pavel Machek
2009-10-27 22:03             ` Brian Swetland
2009-10-27 22:03               ` Brian Swetland
2009-10-28 21:22               ` Pavel Machek
2009-10-28 21:22                 ` Pavel Machek
2009-10-28  8:59 ` Paulius Zaleckas [this message]
2009-10-28  8:59   ` Paulius Zaleckas
2009-10-28  9:05   ` Pavel Machek
2009-10-28  9:05     ` Pavel Machek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4AE807F8.2040909@gmail.com \
    --to=paulius.zaleckas@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.