Re: [PATCH] AMD IOMMU: Parse IVRS table early to prevent iommu_enabled from being disabled

[Wei Wang2 <wei.wang2@amd.com>]

[-- Attachment #1: Type: text/plain, Size: 970 bytes --]

On Wednesday 28 October 2009 19:03:17 Keir Fraser wrote:
> On 28/10/2009 17:46, "Wei Wang2" <wei.wang2@amd.com> wrote:
> >> Not nice. See if c/s 20381 fixes your problem. It's justa  cleanup of
> >> some VT-d code which should avoid the problem altogether.
> >>
> >>  -- Keir
> >
> > Thanks, I have not checked 20381 while creating this patch.
>
> That's because I created it in response to your patch! :-)
>
>  K.
>
> > I will test it again and send something new if necessary.

Keir,
Attached patch removes a BUG_ON condition, to boot amd iommu system correctly.
Thanks,
Wei

Signed-off-by: Wei Wang <wei.wang2@amd.com>
-- 
AMD GmbH, Germany
Operating System Research Center

Legal Information:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34
85609 Dornach b. München

Geschäftsführer: Andrew Bowd, Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis München
Registergericht München, HRB Nr. 43632

[-- Attachment #2: fix-bug-on.patch --]
[-- Type: text/x-diff, Size: 571 bytes --]

diff -r c1f2b68b6dca xen/drivers/passthrough/amd/iommu_init.c
--- a/xen/drivers/passthrough/amd/iommu_init.c	Wed Oct 28 17:27:47 2009 +0000
+++ b/xen/drivers/passthrough/amd/iommu_init.c	Thu Oct 29 12:46:00 2009 +0100
@@ -719,7 +719,7 @@ static int __init amd_iommu_setup_device
     int sys_mgt, dev_ex, lint1_pass, lint0_pass,
        nmi_pass, ext_int_pass, init_pass;
 
-    BUG_ON( (ivrs_bdf_entries == 0) || (iommu_enabled) );
+    BUG_ON( (ivrs_bdf_entries == 0) );
 
     /* allocate 'device table' on a 4K boundary */
     device_table.alloc_size = PAGE_SIZE <<

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel