From: Robert Millan <rmh@aybabtu.com>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [PATCH] turn grub-emu into a port
Date: Sat, 31 Oct 2009 11:29:03 +0100 [thread overview]
Message-ID: <20091031102903.GD12730@thorin> (raw)
In-Reply-To: <4AEC0EDB.4030901@gmail.com>
On Sat, Oct 31, 2009 at 11:18:03AM +0100, Vladimir 'phcoder' Serbinenko wrote:
> >> - return (tv.tv_sec * GRUB_TICKS_PER_SECOND
> >> - + (((tv.tv_sec % GRUB_TICKS_PER_SECOND) * 1000000 + tv.tv_usec)
> >> - * GRUB_TICKS_PER_SECOND / 1000000));
> >> + GRUB_COMPILE_TIME_ASSERT (GRUB_TICKS_PER_SECOND == 1000000);
> >> + return (tv.tv_sec * 1000000 + tv.tv_usec);
> I meant: keep GRUB_TICKS_PER_SECOND=1000000 per default but allow easy
> adjustment to any number by coder
Ah, you mean instead of assuming (and asserting) that they're 1000000, leave
it as a hardcoded "#define GRUB_TICKS_PER_SECOND 1000000" so that this can
be changed at source level?
Seems fine. If that's what you mean, I'll adjust the patch and add it to
experimental.
--
Robert Millan
The DRM opt-in fallacy: "Your data belongs to us. We will decide when (and
how) you may access your data; but nobody's threatening your freedom: we
still allow you to remove your data and not access it at all."
next prev parent reply other threads:[~2009-10-31 10:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-26 18:10 [PATCH] turn grub-emu into a port Robert Millan
2009-10-30 22:49 ` Robert Millan
2009-10-30 23:08 ` Vladimir 'phcoder' Serbinenko
2009-10-31 10:06 ` Robert Millan
2009-10-31 10:18 ` Vladimir 'phcoder' Serbinenko
2009-10-31 10:29 ` Robert Millan [this message]
2009-11-09 22:50 ` Robert Millan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091031102903.GD12730@thorin \
--to=rmh@aybabtu.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.